public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
@ 2019-03-08  2:56 Zhang, Chao B
  2019-03-08  3:07 ` Wang, Jian J
  2019-03-08  8:02 ` Laszlo Ersek
  0 siblings, 2 replies; 4+ messages in thread
From: Zhang, Chao B @ 2019-03-08  2:56 UTC (permalink / raw)
  To: edk2-devel; +Cc: Yao Jiewen, Jian Wang

Cc: Yao Jiewen <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
---
 Maintainers.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 7772926b2f..08a676b236 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -1,6 +1,6 @@
-EDK II Maintainers
+EDK II Maintainers
 ==================
 
 This file provides information about the primary maintainers for
 EDK II.
 
@@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com>
 
 SecurityPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
 M: Chao Zhang <chao.b.zhang@intel.com>
 M: Jiewen Yao <jiewen.yao@intel.com>
+M: Jian Wang <jian.j.wang@intel.com>
 
 ShellBinPkg
 W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
 M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
 M: Ray Ni <ray.ni@intel.com>          (Ia32/X64)
-- 
2.16.2.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
  2019-03-08  2:56 [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg Zhang, Chao B
@ 2019-03-08  3:07 ` Wang, Jian J
  2019-03-08  8:02 ` Laszlo Ersek
  1 sibling, 0 replies; 4+ messages in thread
From: Wang, Jian J @ 2019-03-08  3:07 UTC (permalink / raw)
  To: Zhang, Chao B, edk2-devel@lists.01.org; +Cc: Yao, Jiewen

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Zhang, Chao B
> Sent: Friday, March 08, 2019 10:57 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [Patch] Maintainers.txt: Change package maintainer and reviewer of
> SecurityPkg.
> 
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..08a676b236 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,6 +1,6 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================
> 
>  This file provides information about the primary maintainers for
>  EDK II.
> 
> @@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com>
> 
>  SecurityPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Chao Zhang <chao.b.zhang@intel.com>
>  M: Jiewen Yao <jiewen.yao@intel.com>
> +M: Jian Wang <jian.j.wang@intel.com>
> 
>  ShellBinPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
>  M: Ray Ni <ray.ni@intel.com>          (Ia32/X64)
> --
> 2.16.2.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
  2019-03-08  2:56 [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg Zhang, Chao B
  2019-03-08  3:07 ` Wang, Jian J
@ 2019-03-08  8:02 ` Laszlo Ersek
  2019-03-08  8:53   ` Zhang, Chao B
  1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2019-03-08  8:02 UTC (permalink / raw)
  To: Zhang, Chao B, edk2-devel; +Cc: Yao Jiewen, Jian J Wang, Gao, Liming

On 03/08/19 03:56, Zhang, Chao B wrote:
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..08a676b236 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,6 +1,6 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================

This hunk (which is now part of commit 6c05b958df53) is incorrect. It
adds a UTF-8 BOM to the beginning of the file.

Please remove the BOM urgently, before the stable tag.

Thanks
Laszlo

>  
>  This file provides information about the primary maintainers for
>  EDK II.
>  
> @@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com>
>  
>  SecurityPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Chao Zhang <chao.b.zhang@intel.com>
>  M: Jiewen Yao <jiewen.yao@intel.com>
> +M: Jian Wang <jian.j.wang@intel.com>
>  
>  ShellBinPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
>  M: Ray Ni <ray.ni@intel.com>          (Ia32/X64)
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
  2019-03-08  8:02 ` Laszlo Ersek
@ 2019-03-08  8:53   ` Zhang, Chao B
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Chao B @ 2019-03-08  8:53 UTC (permalink / raw)
  To: Laszlo Ersek, edk2-devel@lists.01.org; +Cc: Yao, Jiewen, Gao, Liming

HI Laszlo:
    Thanks for catching this. Sorry about the inconvenience.

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Friday, March 8, 2019 4:02 PM
To: Zhang, Chao B <chao.b.zhang@intel.com>; edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

On 03/08/19 03:56, Zhang, Chao B wrote:
> Cc: Yao Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Cc: Jian Wang <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..08a676b236 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,6 +1,6 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================

This hunk (which is now part of commit 6c05b958df53) is incorrect. It
adds a UTF-8 BOM to the beginning of the file.

Please remove the BOM urgently, before the stable tag.

Thanks
Laszlo

>
>  This file provides information about the primary maintainers for
>  EDK II.
>
> @@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com<mailto:kelly.steele@intel.com>>
>
>  SecurityPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
>  M: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> +M: Jian Wang <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>
>
>  ShellBinPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>      (Ia32/X64)
>  M: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>          (Ia32/X64)
>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-08  8:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-08  2:56 [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg Zhang, Chao B
2019-03-08  3:07 ` Wang, Jian J
2019-03-08  8:02 ` Laszlo Ersek
2019-03-08  8:53   ` Zhang, Chao B

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox