From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 87E35211D391D
 for <edk2-devel@lists.01.org>; Fri,  8 Mar 2019 00:02:03 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 0F453E6A8B;
 Fri,  8 Mar 2019 08:02:03 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-151.rdu2.redhat.com
 [10.10.120.151])
 by smtp.corp.redhat.com (Postfix) with ESMTP id CF0581001E6E;
 Fri,  8 Mar 2019 08:02:01 +0000 (UTC)
To: "Zhang, Chao B" <chao.b.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Yao Jiewen <jiewen.yao@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
 "Gao, Liming" <liming.gao@intel.com>
References: <20190308025638.81892-1-chao.b.zhang@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <6704daca-ee4e-79c8-f68d-004ddea3345a@redhat.com>
Date: Fri, 8 Mar 2019 09:02:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190308025638.81892-1-chao.b.zhang@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Fri, 08 Mar 2019 08:02:03 +0000 (UTC)
Subject: Re: [Patch] Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2019 08:02:03 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 03/08/19 03:56, Zhang, Chao B wrote:
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
> ---
>  Maintainers.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2f..08a676b236 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -1,6 +1,6 @@
> -EDK II Maintainers
> +EDK II Maintainers
>  ==================

This hunk (which is now part of commit 6c05b958df53) is incorrect. It
adds a UTF-8 BOM to the beginning of the file.

Please remove the BOM urgently, before the stable tag.

Thanks
Laszlo

>  
>  This file provides information about the primary maintainers for
>  EDK II.
>  
> @@ -237,10 +237,11 @@ M: Kelly Steele <kelly.steele@intel.com>
>  
>  SecurityPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>  M: Chao Zhang <chao.b.zhang@intel.com>
>  M: Jiewen Yao <jiewen.yao@intel.com>
> +M: Jian Wang <jian.j.wang@intel.com>
>  
>  ShellBinPkg
>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>  M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
>  M: Ray Ni <ray.ni@intel.com>          (Ia32/X64)
>