[edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[Hernandez, Ronal via groups.io]

[-- Attachment #1.1: Type: text/plain, Size: 1487 bytes --]

Hello All,

I am a firmware engineer at HPI, and I would like to make a patch contribution to the tianocore/edk2-test project.

The patch consists of adding a new test case to the UEFI Self-Certified Test project. Specifically, it adds two new test cases

to validate the EFI_RT_PROPERTIES_TABLE that was introduced in the UEFI Specification version 2.9. The two cases are,


  1.  Validate that the EFI_RT_PROPERTIES_TABLE is installed,
  2.  Validate that the EFI_RT_PROPERTIES_TABLE .RuntimeServicesSupported variable is populated.

Files Modified:

  *   uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompliantBBTestRequired_uefi.c
  *   uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompliantBBTest_uefi.inf
  *   uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.c
  *   uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h

Best Regards,
Ronal Hernandez
CMIT NB RnD - Firmware Engineer | HP Inc. [cid:image001.png@01DB463D.9BE50AF0] <https://www.hp.com/>
Mail:ronal.hernandez1@hp.com



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120875): https://edk2.groups.io/g/devel/message/120875
Mute This Topic: https://groups.io/mt/109931209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #1.2: Type: text/html, Size: 9391 bytes --]

[-- Attachment #2: image001.png --]
[-- Type: image/png, Size: 18676 bytes --]

Re: [edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[Ard Biesheuvel via groups.io]

On Thu, 5 Dec 2024 at 01:07, Hernandez, Ronal via groups.io
<ronal.hernandez1=hp.com@groups.io> wrote:
>
> Hello All,
>
>
>
> I am a firmware engineer at HPI, and I would like to make a patch contribution to the tianocore/edk2-test project.
>
>
>
> The patch consists of adding a new test case to the UEFI Self-Certified Test project. Specifically, it adds two new test cases
>
>
>
> to validate the EFI_RT_PROPERTIES_TABLE that was introduced in the UEFI Specification version 2.9. The two cases are,
>
>
>
> Validate that the EFI_RT_PROPERTIES_TABLE is installed,
> Validate that the EFI_RT_PROPERTIES_TABLE .RuntimeServicesSupported variable is populated.
>
>
>
> Files Modified:
>
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompliantBBTestRequired_uefi.c
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompliantBBTest_uefi.inf
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.c
> uefi-sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/Guid_uefi.h


Hello Ronal,

The EFI_RT_PROPERTIES_TABLE is optional, so I'm not sure what you want
to test here.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120878): https://edk2.groups.io/g/devel/message/120878
Mute This Topic: https://groups.io/mt/109931209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[Hernandez, Ronal via groups.io]

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

Thank you for your feedback, Ard Biesheuvel.

After reviewing the UEFI Specification our interpretation is that because it is now optional to support any of the EFI Runtime Services, the EFI_RT_PROPERTIES_TABLE needs to be published for the caller at runtime to know which runtime services have been implemented.

What we are testing in this patch is whether the EFI_RT_PROPERTIES_TABLE has been installed and whether the RuntimeServicesSupported value has been populated to reflect which optional runtime services are implemented.

> 
> 34. If a platform cannot support calls defined in EFI_RUNTIME_SERVICES
> after
> ExitBootServices() is called, that platform is permitted to provide
> implementations of those
> runtime services that return EFI_UNSUPPORTED when invoked at runtime. On
> such systems, an
> EFI_RT_PROPERTIES_TABLE configuration table should be published describing
> which runtime services
> are supported at runtime
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120882): https://edk2.groups.io/g/devel/message/120882
Mute This Topic: https://groups.io/mt/109931209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1889 bytes --]

Re: [edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[Ard Biesheuvel via groups.io]

On Thu, 5 Dec 2024 at 17:36, Hernandez, Ronal via groups.io
<ronal.hernandez1=hp.com@groups.io> wrote:
>
> Thank you for your feedback, Ard Biesheuvel.
>
> After reviewing the UEFI Specification our interpretation is that because it is now optional to support any of the EFI Runtime Services, the EFI_RT_PROPERTIES_TABLE needs to be published for the caller at runtime to know which runtime services have been implemented.
>

No. This table is optional.

Runtime services *MAY* return EFI_UNSUPPORTED at runtime if the
service in question cannot be supported after ExitBootServices().

If this does not apply to any runtime service, there is no requirement
to publish this table.


> What we are testing in this patch is whether the EFI_RT_PROPERTIES_TABLE has been installed and whether the RuntimeServicesSupported value has been populated to reflect which optional runtime services are implemented.
>

As I said, not doing so is permitted by the UEFI specl, and so it is
not an error.

> 34. If a platform cannot support calls defined in EFI_RUNTIME_SERVICES after
> ExitBootServices() is called, that platform is permitted to provide implementations of those
> runtime services that return EFI_UNSUPPORTED when invoked at runtime. On such systems, an
> EFI_RT_PROPERTIES_TABLE configuration table should be published describing which runtime services
> are supported at runtime

*On such systems* means systems where not all runtime services are
available at runtime. On systems where all runtime services are
available at runtime, there is no requirement to publish the table.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120883): https://edk2.groups.io/g/devel/message/120883
Mute This Topic: https://groups.io/mt/109931209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] tianocore/edk2-test patch contribution, Adding new EFI_RT_PROPERTIES_TABLE test case.

[Hernandez, Ronal via groups.io]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Given your following statement,

*On such systems* means systems where not all runtime services are
available at runtime. On systems where all runtime services are
available at runtime, there is no requirement to publish the table.

The EFI_RT_PROPERTIES_TABLE test being proposed here can be slightly modified to report a warning only for systems where not all runtime services are available at runtime and the EFI_RT_PROPERTIES_TABLE is not installed. This seems to be a valid test case for such systems and the logic can be modified to reflect that statement.

We believe this is a valuable addition to check one of the many new features that have been implemented to the UEFI Specification beyond version 2.7c.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120886): https://edk2.groups.io/g/devel/message/120886
Mute This Topic: https://groups.io/mt/109931209/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1655 bytes --]