From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, edk2-devel@lists.01.org
Cc: Dandan Bi <dandan.bi@intel.com>
Subject: Re: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues.
Date: Wed, 5 Sep 2018 09:57:18 +0200 [thread overview]
Message-ID: <6717b922-b4b2-9fcf-8595-9cd7a1d6eff4@redhat.com> (raw)
In-Reply-To: <20180905062218.13148-1-eric.dong@intel.com>
On 09/05/18 08:22, Eric Dong wrote:
> Fix trailing white spaces and invalid line ending issue.
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +-
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +-
> UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 377876643f..5c562d4759 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -1014,7 +1014,7 @@ WakeUpAP (
> CpuData = &CpuMpData->CpuData[Index];
> //
> // All AP(include disabled AP) will be woke up by INIT-SIPI-SIPI, but
> - // the AP procedure will be skipped for disabled AP because AP state
> + // the AP procedure will be skipped for disabled AP because AP state
> // is not CpuStateReady.
> //
> if (GetApState (CpuData) == CpuStateDisabled && !WakeUpDisabledAps) {
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 75f3fdda1d..773db76b61 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -257,7 +257,7 @@ struct _CPU_MP_DATA {
> // Whether need to use Init-Sipi-Sipi to wake up the APs.
> // Two cases need to set this value to TRUE. One is in HLT
> // loop mode, the other is resume from S3 which loop mode
> - // will be hardcode change to HLT mode by PiSmmCpuDxeSmm
> + // will be hardcode change to HLT mode by PiSmmCpuDxeSmm
> // driver.
> //
> BOOLEAN WakeUpByInitSipiSipi;
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> index 43a3b3b036..81036f0b12 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> @@ -67,4 +67,4 @@
> gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## SOMETIMES_CONSUMES
>
> [Guids]
> - gEdkiiS3SmmInitDoneGuid
> \ No newline at end of file
> + gEdkiiS3SmmInitDoneGuid
> diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> index 4143ee4bb1..fa7e107e39 100644
> --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c
> @@ -516,7 +516,7 @@ AllocateAcpiCpuData (
>
> //
> // Allocate buffer for empty RegisterTable and PreSmmInitRegisterTable for all CPUs
> - //
> + //
> TableSize = 2 * NumberOfCpus * sizeof (CPU_REGISTER_TABLE);
> RegisterTable = AllocatePages (EFI_SIZE_TO_PAGES (TableSize));
> ASSERT (RegisterTable != NULL);
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2018-09-05 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 6:22 [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues Eric Dong
2018-09-05 7:57 ` Laszlo Ersek [this message]
2018-09-06 12:04 ` Laszlo Ersek
2018-09-06 14:03 ` Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6717b922-b4b2-9fcf-8595-9cd7a1d6eff4@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox