From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC32A211093B0 for ; Wed, 5 Sep 2018 00:57:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8411340241C0; Wed, 5 Sep 2018 07:57:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-25.rdu2.redhat.com [10.10.121.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id AAFDC2156701; Wed, 5 Sep 2018 07:57:19 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org Cc: Dandan Bi References: <20180905062218.13148-1-eric.dong@intel.com> From: Laszlo Ersek Message-ID: <6717b922-b4b2-9fcf-8595-9cd7a1d6eff4@redhat.com> Date: Wed, 5 Sep 2018 09:57:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180905062218.13148-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 05 Sep 2018 07:57:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Wed, 05 Sep 2018 07:57:20 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch] UefiCpuPkg/MpInitLib: Fix ECC issues. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 07:57:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/05/18 08:22, Eric Dong wrote: > Fix trailing white spaces and invalid line ending issue. > > Cc: Dandan Bi > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +- > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 2 +- > UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 377876643f..5c562d4759 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -1014,7 +1014,7 @@ WakeUpAP ( > CpuData = &CpuMpData->CpuData[Index]; > // > // All AP(include disabled AP) will be woke up by INIT-SIPI-SIPI, but > - // the AP procedure will be skipped for disabled AP because AP state > + // the AP procedure will be skipped for disabled AP because AP state > // is not CpuStateReady. > // > if (GetApState (CpuData) == CpuStateDisabled && !WakeUpDisabledAps) { > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 75f3fdda1d..773db76b61 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -257,7 +257,7 @@ struct _CPU_MP_DATA { > // Whether need to use Init-Sipi-Sipi to wake up the APs. > // Two cases need to set this value to TRUE. One is in HLT > // loop mode, the other is resume from S3 which loop mode > - // will be hardcode change to HLT mode by PiSmmCpuDxeSmm > + // will be hardcode change to HLT mode by PiSmmCpuDxeSmm > // driver. > // > BOOLEAN WakeUpByInitSipiSipi; > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index 43a3b3b036..81036f0b12 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -67,4 +67,4 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## SOMETIMES_CONSUMES > > [Guids] > - gEdkiiS3SmmInitDoneGuid > \ No newline at end of file > + gEdkiiS3SmmInitDoneGuid > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > index 4143ee4bb1..fa7e107e39 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > @@ -516,7 +516,7 @@ AllocateAcpiCpuData ( > > // > // Allocate buffer for empty RegisterTable and PreSmmInitRegisterTable for all CPUs > - // > + // > TableSize = 2 * NumberOfCpus * sizeof (CPU_REGISTER_TABLE); > RegisterTable = AllocatePages (EFI_SIZE_TO_PAGES (TableSize)); > ASSERT (RegisterTable != NULL); > Reviewed-by: Laszlo Ersek