From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web09.77922.1629418602327194763
 for <devel@edk2.groups.io>;
 Thu, 19 Aug 2021 17:16:42 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=ECwm1u/s;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174])
	by linux.microsoft.com (Postfix) with ESMTPSA id 496A820C33B3;
	Thu, 19 Aug 2021 17:16:41 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 496A820C33B3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1629418601;
	bh=aAiRoADFOn/W8UW7moTqDyriIvSB9IvUBmOCqdvGtMg=;
	h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
	b=ECwm1u/ssx9ZLlIS5dU5MdyxAfgTYIAtJqCKxswlbs4F35d5x803dsP0TmVtv5WcI
	 NYxe/bESslYaA+HRShfnRekr755Lw7voI/on1haCo+g2tGxrv8WEdvMcdFiHmQsJtU
	 CQJi4NeHfVmcTDcy5eurXzZBTR3xBuFPP9aArThQ=
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 4/7] Platform/Intel: Early hook-up Acer Aspire VN7-572G
To: devel@edk2.groups.io, benjamin.doron00@gmail.com
Cc: Chasel Chiu <chasel.chiu@intel.com>,
 Nate DeSimone <nathaniel.l.desimone@intel.com>,
 Isaac Oram <isaac.w.oram@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>
References: <20210818184903.7445-1-benjamin.doron00@gmail.com>
 <20210818184903.7445-5-benjamin.doron00@gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
Message-ID: <67289c0a-4aa9-bf35-7c47-36fbb7ac2c8e@linux.microsoft.com>
Date: Thu, 19 Aug 2021 20:16:41 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210818184903.7445-5-benjamin.doron00@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

Carrying forward R-b from v2.

On 8/18/2021 2:48 PM, Benjamin Doron wrote:
> Note that the SKU IDs do not represent register values, they were chosen
> somewhat arbitrarily. We perform the mapping ourselves, so the
> definitions can be changed.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
>   Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h | 2 ++
>   Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec          | 1 +
>   Platform/Intel/build.cfg                                      | 1 +
>   3 files changed, 4 insertions(+)
> 
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> index e83c56252d2c..0db4fb23583e 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
> @@ -22,6 +22,8 @@ Kaby Lake Platform Board Identifiers
>   
> 
>   #define BoardIdSkylakeRvp3                  0x4
> 
>   #define BoardIdGalagoPro3                   0x20
> 
> +#define BoardIdRayleighSLx_dGPU             0x41
> 
> +#define BoardIdNewgateSLx_dGPU              0x42
> 
>   #define BoardIdKabyLakeYLpddr3Rvp3          0x60
> 
>   
> 
>   #define BoardIdUnknown1                     0xffff
> 
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> index 01d611661603..ac87fe486c4b 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
> @@ -20,6 +20,7 @@ PACKAGE_GUID = 0A8BA6E8-C8AC-4AC1-87AC-52772FA6AE5E
>   
> 
>   [Includes]
> 
>   Include
> 
> +AspireVn7Dash572G/Include
> 
>   GalagoPro3/Include
> 
>   KabylakeRvp3/Include
> 
>   Features/Tbt/Include
> 
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index eba25d36a806..28273347971d 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -57,6 +57,7 @@ BIOS_INFO_GUID =
>   # board_name = path_to_board_build_config.cfg
> 
>   BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
> 
>   BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> 
> +AspireVn7Dash572G = KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cfg
> 
>   GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> 
>   KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> 
>   UpXtreme = WhiskeylakeOpenBoardPkg/UpXtreme/build_config.cfg
>