* [PATCH] ShellPkg:Fix bug in FileBuffer.c
@ 2020-10-26 8:39 zhuenze
2020-11-03 0:59 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 4+ messages in thread
From: zhuenze @ 2020-10-26 8:39 UTC (permalink / raw)
To: devel
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2998
In the function FileBufferCutLine(),set the CutLine pointer to NULL,
The function header specifies that the pointer is valid on a successful
or failed return code.
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
index 5659ec9810..925d910ae2 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
@@ -2767,6 +2767,8 @@ FileBufferCutLine (
UINTN Row;
UINTN Col;
+ *CutLine = NULL;
+
if (FileBuffer.ReadOnly) {
StatusBarSetStatusString (L"Read Only File Can Not Be Modified");
return EFI_SUCCESS;
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
2020-10-26 8:39 [PATCH] ShellPkg:Fix bug in FileBuffer.c zhuenze
@ 2020-11-03 0:59 ` gaoliming
2020-11-03 5:05 ` Gao, Zhichao
0 siblings, 1 reply; 4+ messages in thread
From: gaoliming @ 2020-11-03 0:59 UTC (permalink / raw)
To: devel, zhuenze, zhichao.gao; +Cc: gaoliming
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: bounce+27952+66594+4905953+8761045@groups.io
> <bounce+27952+66594+4905953+8761045@groups.io> 代表 Enze Zhu
> 发送时间: 2020年10月26日 16:40
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2998
>
> In the function FileBufferCutLine(),set the CutLine pointer to NULL,
> The function header specifies that the pointer is valid on a successful
> or failed return code.
>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> index 5659ec9810..925d910ae2 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> @@ -2767,6 +2767,8 @@ FileBufferCutLine (
> UINTN Row;
> UINTN Col;
>
> + *CutLine = NULL;
> +
> if (FileBuffer.ReadOnly) {
> StatusBarSetStatusString (L"Read Only File Can Not Be Modified");
> return EFI_SUCCESS;
> --
> 2.27.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
2020-11-03 0:59 ` 回复: [edk2-devel] " gaoliming
@ 2020-11-03 5:05 ` Gao, Zhichao
2020-11-06 1:11 ` 回复: " gaoliming
0 siblings, 1 reply; 4+ messages in thread
From: Gao, Zhichao @ 2020-11-03 5:05 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
zhuenze@byosoft.com.cn
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Tuesday, November 3, 2020 9:00 AM
> To: devel@edk2.groups.io; zhuenze@byosoft.com.cn; Gao, Zhichao
> <zhichao.gao@intel.com>
> Cc: gaoliming@byosoft.com.cn
> Subject: 回复: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: bounce+27952+66594+4905953+8761045@groups.io
> > <bounce+27952+66594+4905953+8761045@groups.io> 代表 Enze Zhu
> > 发送时间: 2020年10月26日 16:40
> > 收件人: devel@edk2.groups.io
> > 主题: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2998
> >
> > In the function FileBufferCutLine(),set the CutLine pointer to NULL,
> > The function header specifies that the pointer is valid on a
> > successful or failed return code.
> >
> > Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> > ---
> > ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > index 5659ec9810..925d910ae2 100644
> > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > @@ -2767,6 +2767,8 @@ FileBufferCutLine (
> > UINTN Row;
> > UINTN Col;
> >
> > + *CutLine = NULL;
> > +
> > if (FileBuffer.ReadOnly) {
> > StatusBarSetStatusString (L"Read Only File Can Not Be Modified");
> > return EFI_SUCCESS;
> > --
> > 2.27.0.windows.1
> >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
2020-11-03 5:05 ` Gao, Zhichao
@ 2020-11-06 1:11 ` gaoliming
0 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2020-11-06 1:11 UTC (permalink / raw)
To: 'Gao, Zhichao', devel, zhuenze
Create PR https://github.com/tianocore/edk2/pull/1089
Thanks
Liming
> -----邮件原件-----
> 发件人: Gao, Zhichao <zhichao.gao@intel.com>
> 发送时间: 2020年11月3日 13:05
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn;
> zhuenze@byosoft.com.cn
> 主题: RE: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> > Sent: Tuesday, November 3, 2020 9:00 AM
> > To: devel@edk2.groups.io; zhuenze@byosoft.com.cn; Gao, Zhichao
> > <zhichao.gao@intel.com>
> > Cc: gaoliming@byosoft.com.cn
> > Subject: 回复: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66594+4905953+8761045@groups.io
> > > <bounce+27952+66594+4905953+8761045@groups.io> 代表 Enze Zhu
> > > 发送时间: 2020年10月26日 16:40
> > > 收件人: devel@edk2.groups.io
> > > 主题: [edk2-devel] [PATCH] ShellPkg:Fix bug in FileBuffer.c
> > >
> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2998
> > >
> > > In the function FileBufferCutLine(),set the CutLine pointer to NULL,
> > > The function header specifies that the pointer is valid on a
> > > successful or failed return code.
> > >
> > > Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> > > ---
> > > ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > index 5659ec9810..925d910ae2 100644
> > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> > > @@ -2767,6 +2767,8 @@ FileBufferCutLine (
> > > UINTN Row;
> > > UINTN Col;
> > >
> > > + *CutLine = NULL;
> > > +
> > > if (FileBuffer.ReadOnly) {
> > > StatusBarSetStatusString (L"Read Only File Can Not Be Modified");
> > > return EFI_SUCCESS;
> > > --
> > > 2.27.0.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-06 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-26 8:39 [PATCH] ShellPkg:Fix bug in FileBuffer.c zhuenze
2020-11-03 0:59 ` 回复: [edk2-devel] " gaoliming
2020-11-03 5:05 ` Gao, Zhichao
2020-11-06 1:11 ` 回复: " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox