From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by mx.groups.io with SMTP id smtpd.web08.1819.1629825680014987800 for ; Tue, 24 Aug 2021 10:21:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=b4OgE8Q3; spf=pass (domain: suse.com, ip: 194.104.111.102, mailfrom: jfehlig@suse.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1629825677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQjrL4jOJpH0kN5Zvj4lRHintSs7P0J3dhpzpN0xSYw=; b=b4OgE8Q354UHJcbO8P0nZcmwgUWbg6uPgcvNCt10vHv+QaqCfaKkum6GWokG3LEYJhs0B0 S2AkBTZqFV1Dj8RegT4DPJyQoKMsn/7xxgtLvYIhNGJra20W+bgEQrSKfktDl4sV+gLraf lmzUFwKPvgCpMp+4ArJIRuFJS4i3mmg= Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-34-NrwtgF2IOO2yli_f09iAJQ-1; Tue, 24 Aug 2021 19:21:15 +0200 X-MC-Unique: NrwtgF2IOO2yli_f09iAJQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NbGcsMV/PXt22xRg4KjyaP4IB+cg2NzRWHNd8m6yIm8K3i6ciefGyHhvgaAEmOQ1f0LwcXLchrIvm6XRyOGHgjoLg8l6+IMubhcwdRt4QWERtjBKxX4nSBenIriqU9+gUsum9dvawo4DlwU1N2Xh35/XJgYksIBN0YaG6vba/NRKTGKYWAQEtxmw+uIMOQqOT/auZz6vd4UV8uFRcQhQQ3uprpCeEicmZ70XUC2F2DxjoH+ZKl3S4H6QzraEeo3O+TmqQS9A83EX9WSXSjucnbhG0a1KLp6v5HAiOrwgbtpGF7qhHXSXPrqoXB1lzNNihxI8hwm5c0IKdLHVHk/Tag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aQjrL4jOJpH0kN5Zvj4lRHintSs7P0J3dhpzpN0xSYw=; b=XvL4EucFPU4cFjrQfc4dMOcUB2hrHlqaXJ6ugo2HtdefPhPrGhPleEjR5Qiz6VTrLkSkQ0ch/UJ3sMvGSs2socB+d3o9EDDpisGjiJyCCCr4QIKbWyeNwh2xqb2eBiZbpSkTqB+e0IE9RyJgifdh5MCLjj9w/qbhgZw0H0wFeQDRr4K4O/O3CwNTOxyjiGLquhioyGicuOYFR2IcL7PrMjySxcjydF5UbKdBoq13Y5GxaqfIDGGKL8jsVkhc01eoYf6S/oe0UsCS7a/Mr9t2bWxe7b3bHErw/2Odegv0oYByzjfIOgP/5ZKAW21tqFgrzJ2nJzXoGGvv5qQJVyakIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM0PR04MB6436.eurprd04.prod.outlook.com (2603:10a6:208:16b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Tue, 24 Aug 2021 17:21:14 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::58f1:9682:8c77:1fb9]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::58f1:9682:8c77:1fb9%3]) with mapi id 15.20.4436.025; Tue, 24 Aug 2021 17:21:14 +0000 Subject: Re: [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state To: Gary Lin , devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Anthony Perard , Julien Grall , Joey Li References: <20210823070925.10095-1-gary.lin@hpe.com> From: Jim Fehlig Message-ID: <67322735-0450-0128-8004-3946b44e8c58@suse.com> Date: Tue, 24 Aug 2021 11:21:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210823070925.10095-1-gary.lin@hpe.com> X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) Return-Path: jfehlig@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.7] (75.169.18.86) by FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.12 via Frontend Transport; Tue, 24 Aug 2021 17:21:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a4e2a19-f2f7-4cab-e6c9-08d967239341 X-MS-TrafficTypeDiagnostic: AM0PR04MB6436: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6Jvbmo+L3NkFE2TNp1MmcoRG3snolB9Ydi02A5rbTku/0tiW1l6Zj8q7qlydm549/5p0u/MNFMJ4q86aqxyGZmsCLYakYtF+krOFPiz/0GE179eyaEzzrSsqX/vIDyKL0v12f4Ij8PumqBj/se4YT3p6LXZJy5AlZQqHBeeygM5r8xCDw1t6OxCIPaHgzk9njErI4f6Mr5zJ1r10Qzo5gW48XF5i+oXgc8ejNkKsIbI9f5OlM2hn9ICa0pYa+vpcyHiP/zveTQd1LKOcj09s2EuPVdTW8c5ZuBRaP7r/byzlVJRqNOf2ED2XS4KLNKfIGXhiZfIisinGAr2uaZfGecK7V44Kuc0ppIe/XUrZKX94LIcJYZhTOohVEEAcI77VtiFuPn3LKK0pgu5IxE+Ro0R/kjFHc6KPFBQoL7qMrhkJays4V6aTGUXq+oxGGpJVMvIaOf4+YMRhfx5EeAGHfugbcBKFBD4h4BH9BOA2ipUGjTfcOKyCNfQHEnEXqWMbryWpLtIXGR3V4CVX0JnxMlA0aSXOtan4gEsNK6Th7h7/EitnAbMasssJA7KYmTU3daU6MqWZyLnpC5yxjYizg/ZHlVbJI5g1fja0X7KZv2ZSpwdNF9G6bVmR3ZFeQHJxbFCQtRvXIOeslZs4kT6GPbO8Lyxo2FrVxE2r0KlI8chITDH4kzFQbwhes8yzyI+gv9Z4NiaDIx7JxN9nyOzFtIEX+Oa2X59yjcUibHYUaScD7io3qxn0ECCA66zbLLBAb5X9vp+O2SNjs9gsRq9+vBCrXFe5Z075nxw9aCApeiNNHajvohi5p8mBsCR9CSwB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR04MB7970.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(39850400004)(376002)(396003)(83380400001)(66476007)(186003)(2616005)(16576012)(66946007)(6486002)(6666004)(66556008)(4326008)(107886003)(54906003)(956004)(38100700002)(966005)(316002)(478600001)(2906002)(8936002)(8676002)(36756003)(19627235002)(31696002)(53546011)(5660300002)(86362001)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SThvWjJHK0MrNVhyaEJDcm1pc0JuNG9vZnVWUEVPeWYrREtPaGp3MzlOb1kr?= =?utf-8?B?LzJJdDc0UlIyeTVNMTdabFVCVXpJU3Z6SnQxdkxQZVYwYW1RVngwbCtjbEdq?= =?utf-8?B?a3orcEVkdHNlOXBhTm9UMkVyTUNwQmhraHI3b3NhbEY1WUJsUHJKRnFNUVBV?= =?utf-8?B?R1JZcWt0UEpldjhVMUYyVjZPNW9XNVp4YVM4VXo2aGVHelVkeFFzeG5ONzRR?= =?utf-8?B?R2hRcUFuNnNaa1F0SGczaWpxSEUrVldja2JwVkdFU3ZKaFBXaGk5S2ppZHJ1?= =?utf-8?B?b2JFMVVSWEwyZktYeG5zVGhIdm94NnR5Ujl3emZXR1lFU0JIZ2VuWk8ydzFS?= =?utf-8?B?SmpDUGluby84UE5XZE1uMTdOWjE0ODl3UFFIWS9ibmVidHhqZFdQSUtsV25L?= =?utf-8?B?VmJ5ajc5bGlTb3JQblhJL2R4S0RYOU80MFIrRnd2c1ZCMlRKZHI4d3pIeHpj?= =?utf-8?B?em0vZjM4aGZCWmtMZVZFWnYveGtmMCtxSWFiWkdFQjE5aVF1ek5MTm92Tjc5?= =?utf-8?B?RHNYWCtvVUVLSGpUMXNka2ZVMHM1aWNBN0dkSEh0a2NoU1lCN0VMQ3RnRHM1?= =?utf-8?B?YU85WERVUmxOUFYrQnVzKzJsczc4R3ZMN1luUlpBZTRLRkN1ejFVNWJqRUpG?= =?utf-8?B?Y1Z3VzRBUjhBc2ovQ0F5Qm4vcjhjVFMwWEc4enRLNEc2aHVBQWxYZDBvODZK?= =?utf-8?B?aGI0dlhDRUxTdTh0NDFRVjZJR1EzOFhqenFXRXN1M29rZFYxdGM5MjdxSmJQ?= =?utf-8?B?a0RTRUVabkdwWHJqdE1EM0U1TGxVV29RWnBkajJpeWZMOVFkNEpQRXkxVEwv?= =?utf-8?B?Z2hibkZjOFphT1FDZ0lkODVqYWVGYm54RDNMaEVoZGNRUTlTR1dVREN0VTkr?= =?utf-8?B?TGNJSzVOMms3QmZoR3ZVVHdtL2JleDhQWEk3dWllRmhDY0ZwUlNRT1NGcGJ0?= =?utf-8?B?RGFrRFZtaWpONitaNjVGL2dmMTArcFYveXRZMTVIT29hLzRvMWlmQ0RkT2ZY?= =?utf-8?B?TndIS25rK1FrdVVkeHdZQUhtVGNIZ1NMN1o4dktCOW1sQjdmdHB2U1pTUmYv?= =?utf-8?B?em1EZkZPaHVnVm5ydlVDSE10MlhsbTBqT0ttZmUzRmdWVDVqZmNiU3FkdHQr?= =?utf-8?B?QWlzOXF0Y1BIVStrbVFHMFFTc0lmMVArcTNSUlZxeDVoNDZ4ZllMeDVKUnQz?= =?utf-8?B?RFBDbWRBYWZMNytxZktxS0JWMnlqVnVHaHNwNllOc1VPcnZUNGdMUEtpUnEr?= =?utf-8?B?dXJrbHBqeGlINEswSERYUnlpZWZ0VElDZ0lKSkZsU3V5Ym9XL2ZFWjk0UW02?= =?utf-8?B?NlBtdUQ3RHphM3BUeVNiMGRVZjRYUkJRL2VieFMwRkdoNFdsTU5odHFqKzJ4?= =?utf-8?B?VXJmQkN3cURub1BtNXFneHJiMWExc0dXTWwzdDl3QnJHMCtlaHBXck1jakxB?= =?utf-8?B?UHRaWUY0aHBIVW82NWdxVTE1VWVsckhOOWhZeExiMlViN2lVTUhEckZSRmZM?= =?utf-8?B?OFd5ZlBXZit2ODcxdlE0enc0bTg4ZGFLUUFXVGgzRGFFRjdmNXNubXk4SS85?= =?utf-8?B?RGFVTEVqc1k3TFdUVTNTNmlwbDdKV01saStsK0F2THpzRU9HelVGUmUvRUZa?= =?utf-8?B?aEsvMEs5KzdzeVNTTkZmelRtL1JSMnlEcmhRejVZRWVsZWszVzFoZ0ZKdHdk?= =?utf-8?B?N0pLSXRmeFVrdDVDZVNQNFNtTVNFVEhPd1B2TFc4NFJOSmtjTkdDQWpHaHg1?= =?utf-8?Q?8/dw1I5YdVMoRHOVKQP1b0F6cgWCDQO87yVbr5O?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a4e2a19-f2f7-4cab-e6c9-08d967239341 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 17:21:14.2757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xzy3jBYyY9Eb6p6QJQoVPYN7VY6MJgzHnsgpCTZvV3urbHFOBbF6OiAQPhfW9MXMrmjs9EP12ZDx6X8Gf8Q1wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6436 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/23/21 1:09 AM, Gary Lin wrote: > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. > > This patch series initializes PcdAcpiS3Enable in > . Besides, QemuFwCfgS3Enabled() is > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the > potential inconsistency. > > Bugzilla links: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > v3: > - Update the description per Anthony's suggestion > - Add the bugzilla links > - Move the QemuKernelLoaderFsDxe patch out of this patch series > and make it an independent patch > v2: > - Amend the description and address "HVM Direct Kernel Boot" > - Add the comment for the conditional test of QemuFwCfgS3Enabled() > - Remove unused QemuFwCfgLib > - Update my email address > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > Cc: Jim Fehlig > Cc: Joey Li > > Gary Lin (4): > OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization > OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support > OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 > support > OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support > > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 3 +-- > .../PlatformBootManagerLib.inf | 1 + > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 2 ++ > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 2 ++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 4 +--- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 4 +--- > OvmfPkg/XenPlatformPei/Platform.c | 13 +++++++++++++ > 8 files changed, 22 insertions(+), 9 deletions(-) Tested-by: Jim Fehlig Regards, Jim