From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mx.groups.io with SMTP id smtpd.web10.6434.1647312285095146685 for ; Mon, 14 Mar 2022 19:44:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=fm2 header.b=UBpb/YOQ; spf=pass (domain: bsdio.com, ip: 64.147.123.25, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 123C33201134; Mon, 14 Mar 2022 22:44:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 14 Mar 2022 22:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=RAN7HZzta/vXNr eiDonnsNQYQZwUnPm4QmBn0YDTE7g=; b=UBpb/YOQJwsSoZ21eX+JhYkCTdnvew aclkbG03nwE31D8jkdi5C4OQYEfafnlorbOhFgGKQ1KlBGiVxa0EOvY0qIMK7zLy lD5y9wY4imDSO3ibtNDnyVFCVDivET8Va1t3oQ9gs/XdkxA6WBEbM4Ec0X+evOnI UZ2ZyIJwfEPVesgOiMXdB+9NGzHYmWz+sn4sShHLm6cRl2Mrp73DksAplebtjwiV uip9JgYWei31d3i0Zsfc1dICL5LVUg4JSlXyge6fjKVMgOa6hiob+Qj1nKR08jqz 1CnLRYCRhmuHeKAQ2OMcX3QmSxadknn1L3uQVw95RUnE6yA6/w/FWvOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=RAN7HZzta/vXNreiDonnsNQYQZwUnPm4QmBn0YDTE7g=; b=Xyc3/DnX /aSIl1x30vfw6cHFDXRXnHsugYSlvo2s1Q/gkXT8rMSQyHY5TBfeQBsQZXzT5QPv 9OW/fdSlay4bUoTYuGFaeSn80TYeNV0XzQOL05F4souDXmRd4HQAo3N+194cNiLg p9WJ6ZRc+6iltvWaK4R9fb0cfcej9gBQov9AobyEj2NtBUcrBVSTyWoYf6uLXmRS U0i22/W4XxB1UJIJiuBgH4mD6pri53rEoxM272kLp7jZY7zD3rTx2mffPeTcIqAG O4gF1DdyEZGzuvR/Yt2VANUaWp+D4sJjAxTqNdWElRTLeVe2DlBCunlVnNektP6B dxLsSnMWpejZ8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvledggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepleduvedtledtvedvuedugeeuudeiiedtueduvdffueekfeejffduvdetjeev ffdvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Mar 2022 22:44:37 -0400 (EDT) Message-ID: <674fba2a-cd91-4d1d-2888-4f64238309ab@bsdio.com> Date: Mon, 14 Mar 2022 20:44:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH edk2-platforms 0/3] JunoPkg: Fix AcpiSsdtRootPci.asl to use spaces and reserve ECAM area To: devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , Sami Mujawar References: <20220305041955.20918-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: <20220305041955.20918-1-rebecca@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Could someone review this please? Thanks. Rebecca Cran On 3/4/22 21:19, Rebecca Cran wrote: > I noticed Linux reports a firmware bug with the current Juno ACPI > tables. These patches fix it by reserving the ECAM area with a RES0 > device, while also converting AcpiSsdtRootPci.asl from tabs to spaces > and using the standard Pcd from MdePkg for the ECAM base address. > > Rebecca Cran (3): > Platform/ARM/JunoPkg: Convert AcpiSsdtRootPci.asl from tabs to spaces > Platform/ARM/JunoPkg: Use MdePkg PcdPciExpressBaseAddress for ECAM > addr > Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device > > Platform/ARM/JunoPkg/ArmJuno.dec | 4 +- > Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf | 4 + > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 2 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 2 +- > Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 2 +- > Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.h | 2 +- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 2 +- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/AcpiTables.c | 2 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 4 +- > Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl | 301 ++++++++++---------- > 11 files changed, 172 insertions(+), 155 deletions(-) >