From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.45]) by mx.groups.io with SMTP id smtpd.web11.104982.1671027856350845552 for ; Wed, 14 Dec 2022 06:24:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=PqIcAX0U; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.45, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kds9wYdvcEENNcyXt7aRiRqB14rFvEJu4KLdaz0x6UpGA5ylTOnLWc9Fs+4X8aJDWjA0eitNP9Am+9uKLZ+X0LOeinTNziXLrBrDRRI16WgqLDkQ3hzfz8IVPxDdHT2wVggDfT9DIufw1whYnQyHqtfxwrJHOaOo2aJeHKRuhWCOLaHhb1zjiV6RyeD3oBMTRC09vB79LQ8F7r2GmiUwAfT9ZlPCsyTr67mt9T4DIl/MjcpYgEibpdLE2BWsKLTQK8W//3eHtTYAwt6CkBg9uqSEUwz3DhlMd9aMhr+hvLIIT4DqA6xCustZ8Ff5okUmJcEZmHB0j5+N3G/UQ+16YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p53L2f7ReYaPBr9R7MmSVjCsiHagaKo5kGHVqhBGPm4=; b=BYtIh+tjf8sxTqMqI8pKGerD064wRqSoxbE6mcumQcTDAyZJJhcyckOVAiIG/f15n8L2/T1uJeUoySifRbE07s3BfLdoPSu/q8vdVjaasDvVwasxK5n6UEPdgpPWD18lEFpDhvWVzr9MGlWwTqAHMG0mJa1szhsOsRUcaSBZwscAF8aQY0CZla6Tn6hvCMZwMbUpdHJ2cAacopOWf16/4Wz0ue8tkMPG/TJ9a/95bcMMXdzc+2Og2R51h7Ko1pKPmmPJvHXF3CF3Sb9x/H0V9eyS4uzKXp4oeGNa5rWa8++MmJs6dbCItbaF7NzRg+A44bEUmOHRnsPGLlI6S5vVIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p53L2f7ReYaPBr9R7MmSVjCsiHagaKo5kGHVqhBGPm4=; b=PqIcAX0U4h1/bAZONKabDRMaRKwQuvarH5x800VxbOKywJ5UjsJ+raQKmQKARBl3r13j2VSSBxbGnB4Ya7nHtPTGuFrcQQQlddZAZVD9Jym4+2qY6n5D0OoMzdz0Rf0FUTS2wP+OhlyrGP7y4+TMwGp5rTaIubPthtZsc+ojtkU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by BN9PR12MB5116.namprd12.prod.outlook.com (2603:10b6:408:119::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.11; Wed, 14 Dec 2022 14:24:14 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::8200:4042:8db4:63d7%4]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 14:24:14 +0000 Message-ID: <67510982-d217-768c-0367-102ab82f78be@amd.com> Date: Wed, 14 Dec 2022 08:24:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH V2 1/4] OvmfPkg/IoMmuDxe: Reserve shared memory region for DMA operation To: "Xu, Min M" , "devel@edk2.groups.io" Cc: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Gerd Hoffmann References: <20221213054824.53-1-min.m.xu@intel.com> <20221213054824.53-2-min.m.xu@intel.com> From: "Lendacky, Thomas" In-Reply-To: X-ClientProxiedBy: BL0PR02CA0034.namprd02.prod.outlook.com (2603:10b6:207:3c::47) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|BN9PR12MB5116:EE_ X-MS-Office365-Filtering-Correlation-Id: 9ce6c5c9-8afe-4124-9673-08dadddee014 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yc9v/GGAqpK7ZdxE81LhDj+7jDeNFRmYlkIlQfPswVPq/xczT8AMcmsd8JcZFaC5gSwpt+pNxVRWDwm77FYgphFS1SDfLFytCHs/i46SStaKnvPGMhkgBSlTXCnyfev/KL0R6ie1/lE2Vxcu4rBXi2mZSC9IpF/CSCW5uljspl/Ia6oEhkMGKa5s4tSa71jAr6WBvWPT4j95ZJZFA4xS/TwBpwHlvZ2PxW82Lgr3Z+WD9iiA8gXxGpkGJklRjXeLg234HsB8xmwKDYUWfRUkMOWPxzVb9hLS0lK9Pt6XkMAe9EfW6pbBwq+EDwN57z6nEbkw4jyP3gSK0lhxSbNx9GEK4ZYncLq2TjSrWCZlTLJDoZ+WyMWS/ChTfgeAf1zpBHsbkaAq4MmBaGy14aYuWeDO8CmS3ZYE9LXutyMhRRzFZ63yGWyLUo7exgadPsrLVgZV758DYZYat7sLwAw0KOJeFtmfy91/kco98luIU5sN0Kh+0W78QqsduTL8dirFFtNAL0EwOi/s7cXqSR0apjMZYhUXkhJejsjIzrhCt76HaI2PC0WfXGNN/ihBnQ97jPxUQM2V4IWQCGlpLPSWihV1ekJfu0Ugq3lC5kDd0mLrSvTIg8Q3a5eToTONgeg8n743x9JfT25s4drKyuPor4ptZ+IFKUP8BYoi7Y9nTzb3jUMzPZarXpyL7p+1glAAkW06ftRM5XKACLtcbqvILKiTVYQv5zMOD3cw9ZY975mk/oJhhhvxYdlROsTz8Yq+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(396003)(366004)(136003)(39860400002)(376002)(346002)(451199015)(36756003)(38100700002)(31696002)(86362001)(6666004)(316002)(66946007)(66556008)(478600001)(186003)(26005)(6512007)(53546011)(31686004)(966005)(110136005)(54906003)(6506007)(6486002)(66476007)(2906002)(2616005)(41300700001)(8676002)(4326008)(5660300002)(83380400001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2laR1dxSVBIdmtRc1NGRFIvMlpGUHF4TDBxekdXRkxjTjhMTnZYbjRjcm5a?= =?utf-8?B?NFI3TXlXQTk2N1lidUtldFc5a0JRcndwMU1WaHYxYytHTWhEZ00vZjRMRVdN?= =?utf-8?B?NXYzcjhpZzJWTkRtZWVhZ0gySkNwS0IvdmhsbG16bVZzeDFCa3U0eUp4VzQ4?= =?utf-8?B?SlZJVVVxWlBxZksrRmtxVmYvT0ZGUGxHQ0t3ZDZGRDdYZHg5dzJHdkNMMUpZ?= =?utf-8?B?VjJmbE5ZWlczWHNNVnZWVzhlMlJ6aXl5b0xjYzduTktRSklob3lIZmRHd1VP?= =?utf-8?B?ZjM5ME52VFNtd3lZOFZWMlRPeFVRMHdOeE9kZGZPbmQ3QlFXY2U4YmF2ZGhz?= =?utf-8?B?NEJ3N05ydkJRQ0c4QlB1SGtIM0k5UDVpOFptcFBEMW1WL0FlQ0IxNUNZS3B0?= =?utf-8?B?K2dqU3NzcWduTG9YZGVFRmtuR2NqRlRGY05UdVZRdzFqUVp0VnlUNC9rbXVF?= =?utf-8?B?UDJPeXg3dzFORUdIUUVEMk9sMWdtWDFXaW5sSlpKVEl2dEZHOUZiK3dMTVcw?= =?utf-8?B?OHVEU0RkUExTdE0rcEU4Y2RGVnhYaHM5UlVqUUI4djBwck5VNXA2akZSb2ZI?= =?utf-8?B?RUxxdWZKMUEzeGF5NUJqcGcwV1lyTEU2dXZIbGQvNVdBaEFDT3RpaC95K3lF?= =?utf-8?B?RGNsYnF6QUR3NklwcGh0cko5VEZlSzZpcGJ0SXNDd0U5VWJ3OUxTUFNUeVJr?= =?utf-8?B?QU1FUUlWR3gvQ3lQSnhEUzBTZnU5bUI3cFcraDU5YzdpaGM2YlB6YVNlR1Nw?= =?utf-8?B?MThIajVtMDdaNzNzUlorZHNCYTVLbWZuOHQxSEs2c2hTNUJqeHFPWWNNc3h6?= =?utf-8?B?dkRWSmVsV3A1M2dvbm1oaFpCMWVteEdSSGpNMm1USlNHQUt2d1VDYmQ0Wi9w?= =?utf-8?B?ZkdXRW0rL3pUOFlnTVNkWDNsNmwxR1pwaEhwbWVtVysyMFRtRWI3WWJ2TGV6?= =?utf-8?B?K28vNUFTRjdXUWJ2MVNBdFZKN0hGdi9CbHVoMTd2SHJLOUo1WE1uVHpablRQ?= =?utf-8?B?UThXL3Zpdnp0WTFqUHZPTUs4bXBubWRTVE8xWm1FNk5uT2pPTGFsOWxyMllL?= =?utf-8?B?b2p2eVJXQktHS3NoMzhSQVVaRTYvcFdMZW4rUllUclgvSG5vSmdUU1JSak9p?= =?utf-8?B?NzIwZ1hxUlRTck5zS1dIWm96SDQ1U2gxVjFQUld4RG5YMGhVKzJpK21lWUlj?= =?utf-8?B?VHVsK3poMENOaWE2UWJEOS9EZVRyQmZlNjFwWlZiYnEraUpidVpwSDhlbFhz?= =?utf-8?B?eTY2MGtYd04rMm5waTllMjREZHl2d05GaWh6ODg4cHVJRnpVZnRJWVB6MkZ6?= =?utf-8?B?N3FpUjR5THNrKzlWSUR5NFR2VnVmeTROSG1BVzVmTW5BZE9JZ1dQMzdENHlS?= =?utf-8?B?OUhMdkxNVDZVUzNYYXlqWHRUbXhwekc1eXVtaDcrdVYyWGR2OUJJOWJzNjFG?= =?utf-8?B?Y0J2N1NwNENVWEZ4TFBtcTZWaittSEt1ZVNZNHBsVjRNajhRa1pXMEcxekdQ?= =?utf-8?B?RkwxaENDT1pSbjZwOEhiZThXcnJJN1BzOFFmNGZMU2Q4aTVGSnVYRThIRlpk?= =?utf-8?B?ckpjTWlJTUN6Yi93QWxNRld5SGdEWFVDSW1XQTNnYjRRaFE5OHZpQnJvUUZk?= =?utf-8?B?azNsbk9OUjdDeUh0MlRlMjVIMnRqSU0rZUsxditSQTByTGNsdk1FMUVybmxX?= =?utf-8?B?M1Jlc3VzZzNZRmhpZ3NjdTRxQXRqdU1zMm91SUhyTmt5Q1N5U1UrRUhuRGho?= =?utf-8?B?K1BWU04wWXc0RVU5UjVLMndseERNRnJlNC9xZFhzVHkxMGF2NjBRSDBVcGRY?= =?utf-8?B?QnFFUWl0L2pjV1djYUczU2VpYkNzR1JmaGh2RWJ0dkVqQXl5dE5wd051NllX?= =?utf-8?B?bm1OMFRBbEhGZUR4YzArbGJId2NlQmRWQ1ZlYTNHQzVzQXA1ZzlscDc3UUtK?= =?utf-8?B?UDFMUVVCYmJDa0E3SURLOFJJYnNUM3hBUXdFc09FaWxJckh2OHhkclgvd0Ju?= =?utf-8?B?NCtRZkR4aDFlbS9qdlJndllQTUcvdG9PK2Vtb21MZll3Ym9YQXZ1N3J5bjdY?= =?utf-8?B?akZaeS9saDlDZm5WdDJ1Si9GMVJ1Z0dSeHp3dlBLZDVZNzYxclB1U1JUSXRG?= =?utf-8?Q?crFPxOkUJLjA6zMCbDFiSM32w?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce6c5c9-8afe-4124-9673-08dadddee014 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 14:24:13.9832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H0+n3aR3eNwyO42jfinVr4prt463dVHxue4sSsHOH5GI0fPIT6uExbc42mWwFgqCY6SKacIcLavZTO9s5F9NDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5116 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/22 18:02, Xu, Min M wrote: > On December 14, 2022 12:04 AM, Lendacky, Thomas wrote: >> >> On 12/12/22 23:48, Min Xu wrote: >>> From: Min M Xu >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4171 >>> >> >> This patch causes crashes for SEV guests and breaks bisect-ability of the >> EDK2 tree. See below... >> >>> /** >>> @@ -878,6 +860,11 @@ IoMmuUnmapAllMappings ( >>> TRUE // MemoryMapLocked >>> ); >>> } >>> + >>> + // >>> + // Release the reserved shared memory as well. >>> + // >>> + IoMmuReleaseReservedSharedMem (TRUE); >> >> This call is the reason for the crash. You'll need to check for whether there >> has been any shared memory reserved before attempting to free it (in the >> case of SEV that doesn't happen until patch #3 of the series). I think adding >> the check in IoMmuReleaseReservedSharedMem() itself might be best, since >> you can also experience this crash should the below allocation fail, too. >> > Ah, yes. In IoMmuReleaseReservedSharedMem we should first check mReservedSharedMemSupported to see if there is any reserved memory. I test it in my side and there is no crash. > Tom, if this check is added, do you experience any crash? If I add a check for mReservedSharedMemSupported at the start of the funciton and return early if FALSE, then I don't experience a crash. Thanks, Tom > > Thanks > Min