public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* "via Groups.io"
@ 2019-11-12 13:51 Laszlo Ersek
  2019-11-12 13:59 ` Laszlo Ersek
  0 siblings, 1 reply; 6+ messages in thread
From: Laszlo Ersek @ 2019-11-12 13:51 UTC (permalink / raw)
  To: edk2-devel-groups-io
  Cc: Brian Richardson, Leif Lindholm, David Woodhouse, Rebecca Cran

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

Hi,

I've noticed that, recently, the messages I post are reflected by
groups.io with a sender named

  "Laszlo Ersek via Groups.Io"

This is nothing short of brain-damaged, and should be reverted
immediately.

Now, I'm 100% sure that I personally haven't changed anything in either
my email setup, or in my groups.io account. Therefore, it is either a
change in groups.io, or a change in the Red Hat email infrastructure.

Unfortunately, I can't tell where I should start looking / complaining.
Can someone give me hints please?

I've compared the email headers on the following two messages (both
attached, for convenience):

- Last correctly reflected message:
  http://mid.mail-archive.com/927a6e50-1106-92d1-3480-4d4492ca2340@redhat.com
  https://edk2.groups.io/g/devel/message/50310

- First incorrectly (with munged sender) reflected message:
  http://mid.mail-archive.com/0a690fc0-e551-b94e-e129-d5f02d76a62a@redhat.com
  https://edk2.groups.io/g/devel/message/50365

In the bogus message, I see a bunch of "mimecast.com" references, plus
headers like: "ARC-Message-Signature", "ARC-Seal",
"ARC-Authentication-Results".

Is this another botched anti-spam attempt?

Thanks
Laszlo

[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 9028 bytes --]

From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate
Date: Fri, 8 Nov 2019 18:12:17 +0100
Message-ID: <927a6e50-1106-92d1-3480-4d4492ca2340@redhat.com>

Hi Mike,

On 11/07/19 20:26, Michael D Kinney wrote:
> Laszlo,
> 
> The hub command line utility also shows an option to
> create a fork without using the GitHub UI.  But since I
> already have all the relevant forks I needed, I have not
> tried this feature yet.

sorry, I was unclear with my "fork on github.com" adjustment.

I didn't mean that people were required to use the github *UI* for the
fork operation.

Instead, I meant that the data store inside <github.com> had to learn
about the "fork relationship" between the tianocore/edk2-staging repo,
and the <MaintainerAccount>/edk2-staging repo.

Because, in my vocabulary, if I enter my local *edk2* clone, and run the
following commands:

$ git remote add -f --no-tags staging \
    https://github.com/tianocore/edk2-staging.git
$ git checkout -b ci-test-1 staging/edk2-ci
$ [modify files]
$ git add ...
$ git commit
$ git push lersek-edk2 ci-test-1

then I *have* forked the edk2-staging repo. It's because now I'm
exposing a public topic branch that is the derivative of the
edk2-staging/edk2-ci branch.

But, this is not what the test procedure requires. The test procedure
requires each maintainer to tell github explicitly, "I am now forking
edk2-staging under my account, the way github (re)defines 'forking'".
That's *not* what "forking" means in base git terminology, in my
opinion, regardless of whether a maintainer implements the github kind
of forking on the github WebUI, or with the "hub" command line utility.

In brief, I wanted to say, "what github (the service) calls a fork is
quite a bit more restrictive than what base git calls a fork, so please
let's clearly require the github kind in the instructions".

Thanks
Laszlo


>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Thursday, November 7, 2019 3:01 AM
>> To: devel@edk2.groups.io; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] EDK II Maintainers please test
>> the pull request commit gate
>>
>> On 11/07/19 03:24, Michael D Kinney wrote:
>>> EDK II Maintainers,
>>>
>>> Please take a few minutes to test the GitHub pull
>> request commit gate
>>> feature under review in the edk2-staging/edk2-ci
>> branch.  This will be
>>> the only method to push patches to the edk2 repo in
>> the near future,
>>> and we want all current EDK II Maintainers to make
>> sure they know how
>>> to use this new process on the edk2-staging repo
>> before it is
>>> activated on the
>>> edk2 repo.
>>>
>>> Please perform the following steps:
>>> * Create a personal fork of the edk2-staging repo.
>>
>> Slight but relevant clarification: please create a
>> personal fork of the edk2-staging repo *on GitHub.com*.
>>
>>> * Check out the edk2-ci branch from your personal
>>>   fork of the edk2-staging repo
>>> * Create a new branch based on the edk2-ci branch
>>> * Edit the file SampleFile.txt in the root of this
>>>   branch and add an Acked-by: <your email> tag to
>>>   the end of this file.
>>> * Submit a pull request against the Tianocore
>>>   edk2-staging/edk2-ci.  Set the 'push' label so
>>>   the change to SampleFile.txt will be committed
>>>   if all checks pass.
>>>
>>>   NOTE: Make sure you select the 'edk2-ci' branch.
>>>   The default branch for the edk2-staging repo is
>>>   the 'about' branch and the pull request will not
>>>   work against the 'about' branch.
>>>
>>> * Verify that all checks pass and your change to
>>>   SampleFile.txt was merged into the
>>>   edk2-staging/edk2-ci branch.
>>>
>>> For those that prefer command line tools over a WebUI,
>> the command
>>> line utility called 'hub' can be used to submit a pull
>> request and
>>> check the status of a pull request.
>>>
>>> * https://github.com/github/hub
>>> * https://github.com/github/hub/releases
>>> * https://hub.github.com/hub.1.html
>>
>> I've gone through the above (except the personal Acked-
>> by tag) earlier,
>> successfully:
>>
>> https://github.com/tianocore/edk2-staging/pull/99
>>
>> Thanks!
>> Laszlo
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50310): https://edk2.groups.io/g/devel/message/50310
Mute This Topic: https://groups.io/mt/44980130/1721875
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [lersek@redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


[-- Attachment #3: Attached Message --]
[-- Type: message/rfc822, Size: 8155 bytes --]

From: "Laszlo Ersek via Groups.Io" <lersek=redhat.com@groups.io>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>, Andrew Fish <afish@apple.com>, Leif Lindholm <leif.lindholm@linaro.org>, Liming Gao <liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch v5 03/22] pip_requirements.txt: Add python pip requirements file
Date: Mon, 11 Nov 2019 10:58:03 +0100
Message-ID: <0a690fc0-e551-b94e-e129-d5f02d76a62a@redhat.com>

Hi Mike,

On 11/11/19 09:40, Michael D Kinney wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> Add pip requirements file that is used to install the
> python pip modules build from the edk2-pytool-library and
> edk2-pytool-extensions repositories.
> 
> These python modules provide the extensions required to
> perform EDK II Continuous Integration(CI) builds.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
>  pip_requirements.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 pip_requirements.txt
> 
> diff --git a/pip_requirements.txt b/pip_requirements.txt
> new file mode 100644
> index 0000000000..4ad72cfc98
> --- /dev/null
> +++ b/pip_requirements.txt

Is the underscore (ASCII 0x5F) a typo / misunderstanding, or is it
intentional?

I never tested "pip_requirements.txt"; I tested "pip-requirements.txt"
(hyphen, ASCII 0x2D).

Thanks
Laszlo

> @@ -0,0 +1,17 @@
> +## @file
> +# EDK II Python PIP requirements file
> +#
> +# This file provides the list of python components to install using PIP.
> +#
> +# Copyright (c) Microsoft Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +# https://pypi.org/project/pip/
> +# https://pip.pypa.io/en/stable/user_guide/#requirements-files
> +# https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format
> +#
> +##
> +
> +edk2-pytool-library==0.10.*
> +edk2-pytool-extensions==0.12.*
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50365): https://edk2.groups.io/g/devel/message/50365
Mute This Topic: https://groups.io/mt/52458143/1721875
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [lersek@redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-13  7:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-12 13:51 "via Groups.io" Laszlo Ersek
2019-11-12 13:59 ` Laszlo Ersek
2019-11-12 14:30   ` Laszlo Ersek
2019-11-12 17:37     ` [edk2-devel] " Brian Richardson
2019-11-12 17:42       ` Laszlo Ersek
2019-11-13  7:59         ` test message, please ignore Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox