From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B384A21CFA5FB for ; Wed, 16 Aug 2017 09:50:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7114725A798; Wed, 16 Aug 2017 16:53:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7114725A798 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-59.phx2.redhat.com [10.3.116.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28ED06063C; Wed, 16 Aug 2017 16:53:23 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <1502710605-8058-1-git-send-email-brijesh.singh@amd.com> <1502710605-8058-12-git-send-email-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <67654c35-806c-dbd5-1891-4ece6dd805c9@redhat.com> Date: Wed, 16 Aug 2017 18:53:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502710605-8058-12-git-send-email-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 16 Aug 2017 16:53:25 +0000 (UTC) Subject: Re: [PATCH v2 11/23] OvmfPkg/VirtioLib: take VirtIo instance in VirtioRingInit/VirtioRingUninit X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 16:50:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/14/17 13:36, Brijesh Singh wrote: > Passing the VirtIo protocol instance will allow the vring to use > VIRTIO_DEVICE_PROTOCOL.AllocateSharedPages () to allocate vring buffer. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/Include/Library/VirtioLib.h | 14 ++++++++++---- > OvmfPkg/Library/VirtioLib/VirtioLib.c | 14 ++++++++++---- > OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 7 ++++--- > OvmfPkg/VirtioGpuDxe/Commands.c | 7 ++++--- > OvmfPkg/VirtioNetDxe/SnpInitialize.c | 9 +++++---- > OvmfPkg/VirtioNetDxe/SnpShutdown.c | 5 +++-- > OvmfPkg/VirtioRngDxe/VirtioRng.c | 7 ++++--- > OvmfPkg/VirtioScsiDxe/VirtioScsi.c | 7 ++++--- > 8 files changed, 44 insertions(+), 26 deletions(-) All comments from my previous review have been addressed, so: Reviewed-by: Laszlo Ersek Thanks! Laszlo