public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] Get HobListPtr before calling the Multiphase FSPS
@ 2023-06-09 12:48 kurugodx
  0 siblings, 0 replies; 4+ messages in thread
From: kurugodx @ 2023-06-09 12:48 UTC (permalink / raw)
  To: devel
  Cc: kurugodx, Chasel Chiu, Nate DeSimone, Duggapu Chinni B,
	Chen Gang C, Star Zeng, Ted Kuo, Ashraf Ali S, Susovan Mohapatra

REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480

In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler
and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so
that BL will be able to get the correct FspHobListPtr value

Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
---
 IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 08fe0fdb7e..c9ed78ef62 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
 
   DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
 
+  //
+  // Get FspHobList
+  //
+  GuidHob = GetFirstGuidHob (&gFspHobGuid);
+  ASSERT (GuidHob != NULL);
+  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
+  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
+
   if (Status == FSP_STATUS_VARIABLE_REQUEST) {
     //
     // call to Variable request handler
-- 
2.26.2.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] Get HobListPtr before calling the Multiphase FSPS
@ 2023-06-09 13:39 kurugodx
  2023-06-09 13:55 ` Ashraf Ali S
  2023-06-09 15:58 ` Chiu, Chasel
  0 siblings, 2 replies; 4+ messages in thread
From: kurugodx @ 2023-06-09 13:39 UTC (permalink / raw)
  To: devel
  Cc: kurugodx, Chasel Chiu, Nate DeSimone, Duggapu Chinni B,
	Chen Gang C, Star Zeng, Ted Kuo, Ashraf Ali S, Susovan Mohapatra

REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480

In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler
and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so
that BL will be able to get the correct FspHobListPtr value

Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
---
 .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 08fe0fdb7e..1d4dd60577 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
 
   DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
 
+  //
+  // Get FspHobList
+  //
+  GuidHob = GetFirstGuidHob (&gFspHobGuid);
+  ASSERT (GuidHob != NULL);
+  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
+  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
+
   if (Status == FSP_STATUS_VARIABLE_REQUEST) {
     //
     // call to Variable request handler
@@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify (
     DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status));
   }
 
-  //
-  // Now FspHobList complete, process it
-  //
-  GuidHob = GetFirstGuidHob (&gFspHobGuid);
-  ASSERT (GuidHob != NULL);
-  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
-  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
   PostFspsHobProcess (FspHobListPtr);
 
   //
-- 
2.41.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] Get HobListPtr before calling the Multiphase FSPS
  2023-06-09 13:39 kurugodx
@ 2023-06-09 13:55 ` Ashraf Ali S
  2023-06-09 15:58 ` Chiu, Chasel
  1 sibling, 0 replies; 4+ messages in thread
From: Ashraf Ali S @ 2023-06-09 13:55 UTC (permalink / raw)
  To: Aishwarya, KurugoduMelmatamX, devel@edk2.groups.io
  Cc: Chiu, Chasel, Desimone, Nathaniel L, Duggapu, Chinni B,
	Chen, Gang C, Zeng, Star, Kuo, Ted, Mohapatra, Susovan

Reviewed-by: Ashraf Ali S <ashraf.ali.s@intel.com>

-----Original Message-----
From: Aishwarya, KurugoduMelmatamX <kurugodumelmatamx.aishwarya@intel.com> 
Sent: Friday, June 9, 2023 7:10 PM
To: devel@edk2.groups.io
Cc: Aishwarya, KurugoduMelmatamX <kurugodumelmatamx.aishwarya@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Chen, Gang C <gang.c.chen@intel.com>; Zeng, Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>; Mohapatra, Susovan <susovan.mohapatra@intel.com>
Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS

REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480

In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value

Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
Cc: Chen Gang C <gang.c.chen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Ted Kuo <ted.kuo@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
---
 .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
index 08fe0fdb7e..1d4dd60577 100644
--- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
+++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
@@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
 
   DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
 
+  //
+  // Get FspHobList
+  //
+  GuidHob = GetFirstGuidHob (&gFspHobGuid);  ASSERT (GuidHob != NULL);  
+ FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);  DEBUG 
+ ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
+
   if (Status == FSP_STATUS_VARIABLE_REQUEST) {
     //
     // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify (
     DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status));
   }
 
-  //
-  // Now FspHobList complete, process it
-  //
-  GuidHob = GetFirstGuidHob (&gFspHobGuid);
-  ASSERT (GuidHob != NULL);
-  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
-  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
   PostFspsHobProcess (FspHobListPtr);
 
   //
--
2.41.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] Get HobListPtr before calling the Multiphase FSPS
  2023-06-09 13:39 kurugodx
  2023-06-09 13:55 ` Ashraf Ali S
@ 2023-06-09 15:58 ` Chiu, Chasel
  1 sibling, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2023-06-09 15:58 UTC (permalink / raw)
  To: Aishwarya, KurugoduMelmatamX, devel@edk2.groups.io
  Cc: Desimone, Nathaniel L, Duggapu, Chinni B, Chen, Gang C,
	Zeng, Star, Kuo, Ted, S, Ashraf Ali, Mohapatra, Susovan


Please update the subject per format requirement -
    PackageName: title

With this update, Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Aishwarya, KurugoduMelmatamX
> <kurugodumelmatamx.aishwarya@intel.com>
> Sent: Friday, June 9, 2023 6:40 AM
> To: devel@edk2.groups.io
> Cc: Aishwarya, KurugoduMelmatamX
> <kurugodumelmatamx.aishwarya@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B
> <chinni.b.duggapu@intel.com>; Chen, Gang C <gang.c.chen@intel.com>; Zeng,
> Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>; Mohapatra, Susovan
> <susovan.mohapatra@intel.com>
> Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS
> 
> REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480
> 
> In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and
> FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will
> be able to get the correct FspHobListPtr value
> 
> Signed-off-by: kurugodx <kurugodumelmatamx.aishwarya@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Chen Gang C <gang.c.chen@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> ---
>  .../FspsWrapperPeim/FspsWrapperPeim.c             | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> index 08fe0fdb7e..1d4dd60577 100644
> --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c
> @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify (
> 
>    DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status));
> 
> +  //
> +  // Get FspHobList
> +  //
> +  GuidHob = GetFirstGuidHob (&gFspHobGuid);  ASSERT (GuidHob != NULL);
> + FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);  DEBUG
> + ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
> +
>    if (Status == FSP_STATUS_VARIABLE_REQUEST) {
>      //
>      // call to Variable request handler @@ -356,13 +364,6 @@
> PeiMemoryDiscoveredNotify (
>      DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status
> = %r\n", Status));
>    }
> 
> -  //
> -  // Now FspHobList complete, process it
> -  //
> -  GuidHob = GetFirstGuidHob (&gFspHobGuid);
> -  ASSERT (GuidHob != NULL);
> -  FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob);
> -  DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr));
>    PostFspsHobProcess (FspHobListPtr);
> 
>    //
> --
> 2.41.0.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-09 15:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 12:48 [PATCH] Get HobListPtr before calling the Multiphase FSPS kurugodx
  -- strict thread matches above, loose matches on Subject: below --
2023-06-09 13:39 kurugodx
2023-06-09 13:55 ` Ashraf Ali S
2023-06-09 15:58 ` Chiu, Chasel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox