Re: 回复: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

["Rebecca Cran" <rebecca@nuviainc.com>]

Thanks. Yes, I'll send a new patch series for 1-4,6 and create a new PR.


-- 

Rebecca Cran


On 10/27/20 12:32 AM, gaoliming wrote:
> Leif:
>    If no objection, I agree to merge patch 4/6 just after next stable tag 202011.
>
> Rebecca:
>    Can you create PR for other 5 patches? I can help merge them.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+66605+4905953+8761045@groups.io
>> <bounce+27952+66605+4905953+8761045@groups.io> 代表 Leif Lindholm
>> 发送时间: 2020年10月27日 1:48
>> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
>> 抄送: rebecca@nuviainc.com; 'Michael D Kinney'
>> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Ray
>> Ni' <ray.ni@intel.com>; 'Zhichao Gao' <zhichao.gao@intel.com>
>> 主题: Re: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h
>> fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
>>
>> Hi Liming,
>>
>> I agree 4/6 is invasive, but I also think industry standard headers
>> should match the specifications they implement.
>>
>> If 5-6/6 do not depend on 4/6, then I agree the others can be merged
>> first.
>> Depending on perceived impact, perhaps 4/6 could be held back until
>> just after next stable tag?
>>
>> Best Regards,
>>
>> Leif
>>
>> On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote:
>>> Rebecca:
>>>    Patch 4/6 may be safe. But, we may need more time to collect the
>> feedback.
>>>
>>>    Other patches are clear. I suggest to merge them first.
>>>
>>> Thanks
>>> Liming
>>>> -----邮件原件-----
>>>> 发件人: bounce+27952+66523+4905953+8761045@groups.io
>>>> <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca
>> Cran
>>>> 发送时间: 2020年10月22日 10:21
>>>> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
>>>> 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu'
>>>> <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao'
>>>> <zhichao.gao@intel.com>
>>>> 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and
>>>> SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
>>>>
>>>> On 10/21/20 7:46 PM, gaoliming wrote:
>>>>>     They are the good change. But for patch 4/6, it changes the
>> structure
>>>>> field name. It may bring the impact to the platform code. I don't
>>> suggest to
>>>>> do the renaming field only for typo purpose. Other changes are good to
>>> me.
>>>>   From looking at the code in edk2-platforms, it seems the common
>> pattern
>>>> is to use positional arguments instead of designated initializers. Of
>>>> course there could be platforms outside of TianoCore which use the field
>>>> names, but it looks like a relatively safe change.
>>>>
>>>>
>>>> --
>>>> Rebecca Cran
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>
>
>
>
> 
>
>