From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by mx.groups.io with SMTP id smtpd.web08.14511.1603809230533325623 for ; Tue, 27 Oct 2020 07:33:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=QLVl0fwO; spf=pass (domain: nuviainc.com, ip: 209.85.167.177, mailfrom: rebecca@nuviainc.com) Received: by mail-oi1-f177.google.com with SMTP id z23so1493257oic.1 for ; Tue, 27 Oct 2020 07:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=0D5pBkuDf3MTvGJgZ0JkVs4LmsDFPI9SZLvPhiMfHwo=; b=QLVl0fwOjyMXwhSJr31iT6kbwtOHcaAsA2FYOwKBT01lQKhMP1GCvxiF0KvOx1zIqE YQ/T72NHKUW+Tb4tqi7Aa3Y26HGJzwgWUljf9uYZ+PlXYPUaJX4K6omxH5VeVXp19Up5 fK5OVvqpN50bbdNi/Dsns53IhgaAmODK88bFCX2odLZxe/sopKgOQQJPiyJ8NxBawoVX PoYIdJ+4ljWFJLwWYwxOJgaBux8RBJLjx4dPzh8NtGpEAUGFnfXT+IedSMeGo/7vcwFW rUTY5sluZ6iC3J6M+yoqQAII6LiX1N1yLnhUQh27YJKbdk73AgkJcsaEQ+K+o4ww1J+E UUoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=0D5pBkuDf3MTvGJgZ0JkVs4LmsDFPI9SZLvPhiMfHwo=; b=F7CMFhdJ49TvAi8SR/T9JnXwBjZy98vpHE3L2ISogYyMODQLIK+PJwcGR+dVifurnS gBjdFOObP1oOiA3oaSfiWe6mxhPKakXuyrSpJdr3If0NU9fZ2Vllt4TvgeOt/0fk2wcQ /9oINrKLEW5K4IQd0xgVR6YVrEvTHXHsULWj/L2KQHPjXDh7DOJnrgTtfSZaon0rp47l Z8v1Da/hcCo8h8zAAWSQlHpSuvkS0G8/LOJqSBaNadpAl8wO+v9Z7GNdXDgqJgHOGOV1 mARQypcbuyGRKuHG1Zzftd7sEK7URqW82zOeuntS4SCZC2v3Jxn7JPi5CNPrjG17sE0g w+tA== X-Gm-Message-State: AOAM531FEC+MeETE/6RfUXAkPxwFnDx9bMOlVojSdND0kWaUhNLgPtmk 4rYNGGbPP3i7+NmdWujHW8atFiJ2dJQICQ== X-Google-Smtp-Source: ABdhPJz+ZaMW6IGdKaaSZyH5vKvxXSg3peqp9cusf8HLzd1j8oimdd46JpovCgeGAkosApxaqWCguw== X-Received: by 2002:a54:4094:: with SMTP id i20mr1792397oii.0.1603809229854; Tue, 27 Oct 2020 07:33:49 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (muon.bluestop.org. [65.103.231.193]) by smtp.gmail.com with ESMTPSA id v21sm989273oto.65.2020.10.27.07.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 07:33:49 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0ggMC82XSBzbWJpb3N2aWV3IGFuZCBTbUJpb3MuaCBmaXhlcywgYWRkIFNNQklPUyAzLjQuMCBBUk02NCBTb0MgSUQgZGVmaW5pdGlvbg==?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, leif@nuviainc.com Cc: 'Michael D Kinney' , 'Zhiguang Liu' , 'Ray Ni' , 'Zhichao Gao' References: <20201021184115.25712-1-rebecca@nuviainc.com> <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com> <003301d6ab36$bb724460$3256cd20$@byosoft.com.cn> <20201026174755.GG1664@vanye> <002b01d6ac2b$026ce330$0746a990$@byosoft.com.cn> From: "Rebecca Cran" Message-ID: <678b561f-1d72-be02-ce9f-5a0e8d420fcd@nuviainc.com> Date: Tue, 27 Oct 2020 08:33:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <002b01d6ac2b$026ce330$0746a990$@byosoft.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Thanks. Yes, I'll send a new patch series for 1-4,6 and create a new PR. -- Rebecca Cran On 10/27/20 12:32 AM, gaoliming wrote: > Leif: > If no objection, I agree to merge patch 4/6 just after next stable tag 202011. > > Rebecca: > Can you create PR for other 5 patches? I can help merge them. > > Thanks > Liming >> -----邮件原件----- >> 发件人: bounce+27952+66605+4905953+8761045@groups.io >> 代表 Leif Lindholm >> 发送时间: 2020年10月27日 1:48 >> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn >> 抄送: rebecca@nuviainc.com; 'Michael D Kinney' >> ; 'Zhiguang Liu' ; 'Ray >> Ni' ; 'Zhichao Gao' >> 主题: Re: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h >> fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition >> >> Hi Liming, >> >> I agree 4/6 is invasive, but I also think industry standard headers >> should match the specifications they implement. >> >> If 5-6/6 do not depend on 4/6, then I agree the others can be merged >> first. >> Depending on perceived impact, perhaps 4/6 could be held back until >> just after next stable tag? >> >> Best Regards, >> >> Leif >> >> On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: >>> Rebecca: >>> Patch 4/6 may be safe. But, we may need more time to collect the >> feedback. >>> >>> Other patches are clear. I suggest to merge them first. >>> >>> Thanks >>> Liming >>>> -----邮件原件----- >>>> 发件人: bounce+27952+66523+4905953+8761045@groups.io >>>> 代表 Rebecca >> Cran >>>> 发送时间: 2020年10月22日 10:21 >>>> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn >>>> 抄送: 'Michael D Kinney' ; 'Zhiguang Liu' >>>> ; 'Ray Ni' ; 'Zhichao Gao' >>>> >>>> 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and >>>> SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition >>>> >>>> On 10/21/20 7:46 PM, gaoliming wrote: >>>>> They are the good change. But for patch 4/6, it changes the >> structure >>>>> field name. It may bring the impact to the platform code. I don't >>> suggest to >>>>> do the renaming field only for typo purpose. Other changes are good to >>> me. >>>> From looking at the code in edk2-platforms, it seems the common >> pattern >>>> is to use positional arguments instead of designated initializers. Of >>>> course there could be platforms outside of TianoCore which use the field >>>> names, but it looks like a relatively safe change. >>>> >>>> >>>> -- >>>> Rebecca Cran >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >> >> >> > > > > > > >