From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 18 Jul 2019 14:17:39 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8C91759474; Thu, 18 Jul 2019 21:17:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-25.ams2.redhat.com [10.36.116.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id C30495C236; Thu, 18 Jul 2019 21:17:31 +0000 (UTC) Subject: Re: [PATCH 0/3] add GetMaintainer.py helper script To: Leif Lindholm , edk2-devel-groups-io Cc: Andrew Fish , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao , "Wu, Hao A" , Stefan Berger References: <20190712170128.6495-1-leif.lindholm@linaro.org> From: "Laszlo Ersek" Message-ID: <6799dc07-2d8c-0ad1-286e-23b2b68c413a@redhat.com> Date: Thu, 18 Jul 2019 23:17:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 18 Jul 2019 21:17:38 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/18/19 18:27, Leif Lindholm wrote: > Laszlo, Hao - I have prepared a set for pushing as below. > > (Reviewed-by: Leif Lindholm for all of your > patches.) > *But*, I need a review from Bob and/or Liming before I push the final one: > "BaseTools: add GetMaintainer.py script" - > https://edk2.groups.io/g/devel/message/43666 > > I have verified reviews/acks by all affected reviewers, except for Stefan > Berger for Ovmf TCG/TPM2. Stefan's R-b has arrived as well: http://mid.mail-archive.com/7201b3fb-d84b-30e0-61c8-bf9bb9defa7a@linux.ibm.com So, I agree, those four patches regarding OvmfPkg reviewership are now fully approved. Please pick up Phil's feedback as well. > While I would prefer to have that too, this is a file format shift - not a > change in responsibility areas. > Laszlo, do you agree? > If so, I can push 1-7/8 as is. See above -- then I'm OK. Thank you! Laszlo > > / > Leif > > Hao A Wu (1): > Maintainers.txt: Fine-grained review ownership for MdeModulePkg > > Laszlo Ersek (4): > Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" > Maintainers.txt: split out section "OvmfPkg: Xen-related modules" > Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related > modules" > Maintainers.txt: split out section "OvmfPkg: CSM modules" > > Leif Lindholm (3): > Maintainers.txt: update for filesystem area descriptions > Maintainers.txt: add wildcard path association for Arm/AArch64 > BaseTools: add GetMaintainer.py script > > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm > wrote: > >> Changes are available directly from: >> >> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-v1 >> >> This series adds new tags to the Maintainers.txt format, making it possible >> to describe which filesystem paths are looked after by which people, and >> hence automating the extraction of a list over who should be cc:d on a >> patch >> submission. >> >> Remaining shorcomings in v1: >> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines >> interspersed with the tag lines. These lines will be removed as areas of >> responsibility is formally rewritten as tags. >> - * Wildcard support is not fully filesystem compliant except in first or >> last position in the file pattern (it translates as regex .* elsewhere). >> However, actual cases of mismatch are expected to be unlikely, and they >> will be false positives rather than false negatives - so I think this is >> good enough at least for a start. >> - Provides no information of why certain people or meiling lists were >> picked - it just bundles all recipients up, deduplicates them, and >> prints them out. >> >> Using the script requires the gitpython module to be installed. >> >> Worthwhile mentioning outside the ChangeLog is the added -l flag, which >> lets you look up what a given path would return in the way of matches. >> E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" >> would return: >> --- >> Non/Existing/Path >> "Non/Existing/Path": no maintainers found, looking for default >> Andrew Fish >> Laszlo Ersek >> Leif Lindholm >> Michael D Kinney >> devel@edk2.groups.io >> --- >> >> This series would still result in GetMaintainers.py missing some >> maintainers/reviewers due to descriptions in prose rather than filename >> patterns. My preferred way of handling this would be to merge 1-2/3 as >> soon as found acceptable, following up and merging patches to update >> ArmVirtPkg, MdeModulePkg, and OvmfPkg, and finally once the file is >> consistent, proceed to merge 3/3. >> >> Changelog: >> v1: >> - Rebase to current Maintainers.txt. >> - Fix typos and missed bits in Maintainers.txt. >> - Get rid of the magic '' filename, let the single-char '*' >> wildcard resolve this (_using_ the magic '' filename in the >> script, but treating it as if it was a file in the top-level directory). >> - Add -l flag to script to look up which maintainers would be returned for >> a given path (which need not exist). >> rfc: >> - Split patches up >> - one for new Maintainers.txt format (documentation and F: tags). >> - one for adding a new wilcards responsibility area for */Arm, */AArch64 >> - one for the GetMaintainer.py script >> - Reworked wildcard handling based on Laszlo's explanation >> - Trailing / covers everything under that directory >> - Trailing * does not cover subdirectories >> - Added support for X: tag >> - Added support for magic '' pathname >> - Also prints mailing list addresses for matching L: tags >> >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Michael D Kinney >> Cc: Bob Feng >> Cc: Liming Gao >> Cc: Philippe Mathieu-Daude >> Cc: "Wu, Hao A" >> >> Leif Lindholm (3): >> Maintainers.txt: update for filesystem area descriptions >> Maintainers.txt: add wildcard path association for Arm/AArch64 >> BaseTools: add GetMaintainer.py script >> >> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ >> Maintainers.txt | 54 ++++++++ >> 2 files changed, 244 insertions(+) >> create mode 100644 BaseTools/Scripts/GetMaintainer.py >> >> -- >> 2.20.1 >> >> >