From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6BEF61A1E1B for ; Tue, 23 Aug 2016 14:23:25 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D06223F720; Tue, 23 Aug 2016 21:23:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-164.phx2.redhat.com [10.3.116.164]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7NLNI1Y028167; Tue, 23 Aug 2016 17:23:20 -0400 To: Ard Biesheuvel , edk2-devel@ml01.01.org References: <1471847752-26574-1-git-send-email-ard.biesheuvel@linaro.org> <1471847752-26574-2-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <679bfdec-9bec-18b9-ba2c-d27669f93fef@redhat.com> Date: Tue, 23 Aug 2016 17:23:14 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471847752-26574-2-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 23 Aug 2016 21:23:24 +0000 (UTC) Subject: Re: [PATCH 1/5] ArmVirtPkg/PciHostBridgeDxe: don't set linux, pci-probe-only DT property X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 21:23:25 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/22/16 02:35, Ard Biesheuvel wrote: > Setting the linux,pci-probe-only was intended to align OSes booting via > DT with OSes booting via ACPI in the way they honor the PCI configuration > performed by the firmware. However, ACPI on arm64 does not currently honor > the firmware's PCI configuration, and the linux,pci-probe-only completely > prevents any PCI reconfiguration from occurring under the OS, including > what is needed to support PCI hotplug. > > Since the primary use case was OS access to the GOP framebuffer (which > breaks when the framebuffer BAR is moved when the OS reconfigures the > PCI), we can undo this change now that ArmVirtQemu has moved to a GOP > implementation that does not expose a raw framebuffer in the first place. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c | 38 -------------------- > 1 file changed, 38 deletions(-) > > diff --git a/ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c b/ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c > index 5063782bb392..669c90355889 100644 > --- a/ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c > +++ b/ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c > @@ -79,42 +79,6 @@ PCI_HOST_BRIDGE_INSTANCE mPciHostBridgeInstanceTemplate = { > // Implementation > // > > -STATIC > -VOID > -SetLinuxPciProbeOnlyProperty ( > - IN FDT_CLIENT_PROTOCOL *FdtClient > - ) > -{ > - INT32 Node; > - UINT32 Tmp; > - EFI_STATUS Status; > - > - if (!FeaturePcdGet (PcdPureAcpiBoot)) { > - // > - // Set the /chosen/linux,pci-probe-only property to 1, so that the PCI > - // setup we will perform in the firmware is honored by the Linux OS, > - // rather than torn down and done from scratch. This is generally a more > - // sensible approach, and aligns with what ACPI based OSes do typically. > - // > - // In case we are exposing an emulated VGA PCI device to the guest, which > - // may subsequently get exposed via the Graphics Output protocol and > - // driven as an efifb by Linux, we need this setting to prevent the > - // framebuffer from becoming unresponsive. > - // > - Status = FdtClient->GetOrInsertChosenNode (FdtClient, &Node); > - > - if (!EFI_ERROR (Status)) { > - Tmp = SwapBytes32 (1); > - Status = FdtClient->SetNodeProperty (FdtClient, Node, > - "linux,pci-probe-only", &Tmp, sizeof (Tmp)); > - } > - if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_WARN, > - "Failed to set /chosen/linux,pci-probe-only property\n")); > - } > - } > -} > - > // > // We expect the "ranges" property of "pci-host-ecam-generic" to consist of > // records like this. > @@ -293,8 +257,6 @@ ProcessPciHost ( > // > ASSERT (PcdGet64 (PcdPciExpressBaseAddress) == ConfigBase); > > - SetLinuxPciProbeOnlyProperty (FdtClient); > - > DEBUG ((EFI_D_INFO, "%a: Config[0x%Lx+0x%Lx) Bus[0x%x..0x%x] " > "Io[0x%Lx+0x%Lx)@0x%Lx Mem[0x%Lx+0x%Lx)@0x%Lx\n", __FUNCTION__, ConfigBase, > ConfigSize, *BusMin, *BusMax, *IoBase, *IoSize, *IoTranslation, *MmioBase, > I suggest to note in the commit message that this patch effectively undoes commit 8b816c624dd407e1590d7c399c69ab307af3ef33. Can be done without a resend, if you agree. Reviewed-by: Laszlo Ersek 0 (Further review feedback will likely be very slow, for the known reasons -- I try to process my email backlog whenever I find a reasonable time slot. For larger patches, larger slots are necessary.) Thanks! Laszlo