From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 15 Jul 2019 10:08:15 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5120C18B2C0; Mon, 15 Jul 2019 17:08:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-21.ams2.redhat.com [10.36.117.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id F319460BEC; Mon, 15 Jul 2019 17:08:10 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 3/3] BaseTools: add GetMaintainer.py script To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: Andrew Fish , Michael D Kinney , Philippe Mathieu-Daude , Bob Feng , Liming Gao References: <20190712170128.6495-1-leif.lindholm@linaro.org> <20190712170128.6495-4-leif.lindholm@linaro.org> <20190713104128.pvydmrzbbg7kalkh@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <67add03c-cec8-8a45-f180-0b4c2ed8dac0@redhat.com> Date: Mon, 15 Jul 2019 19:08:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190713104128.pvydmrzbbg7kalkh@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 15 Jul 2019 17:08:14 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/13/19 12:41, Leif Lindholm wrote: > On Sat, Jul 13, 2019 at 12:58:18AM +0200, Laszlo Ersek wrote: >> On 07/12/19 19:01, Leif Lindholm wrote: >>> Add a new script GetMaintainer.py that uses the new Maintainer.txt format >>> to determine which addresses to cc on patch submission. >>> >>> Signed-off-by: Leif Lindholm >>> Reviewed-by: Philippe Mathieu-Daude >>> Tested-by: Philippe Mathieu-Daude >>> --- >>> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++++ >>> 1 file changed, 190 insertions(+) >>> create mode 100644 BaseTools/Scripts/GetMaintainer.py >> >> I should really re-review this from zero, but it's 0:55 AM again. :/ >> >> Anyway, I think this script is a good candidate for gradual improvements >> (should such ever become necessary, that is). The script doesn't have to >> be perfect to be incredibly useful. >> >> Acked-by: Laszlo Ersek > > Thanks! > >> ... Did you have me in mind for the ArmVirtPkg and OvmfPkg pathname >> patterns, for replacing the natural language pointers? :) > > That would be ideal, thanks. I might miss something if I did it. > I would be happy to push them together with 1-2/3 once ready. Posted: [edk2-devel] [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames https://edk2.groups.io/g/devel/message/43728 http://mid.mail-archive.com/20190715170431.13955-1-lersek@redhat.com (The mail-archive.com link will start working after mail-archive.com indexes the message. Oh, the beauty of stable message identifiers! :) ) Thanks Laszlo