From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by mx.groups.io with SMTP id smtpd.web10.895.1571124792414782447
 for <devel@edk2.groups.io>;
 Tue, 15 Oct 2019 00:33:12 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 03E78B9AA7;
	Tue, 15 Oct 2019 07:33:12 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.ams2.redhat.com [10.36.116.178])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 16C7E5C1D4;
	Tue, 15 Oct 2019 07:33:08 +0000 (UTC)
Subject: Re: [PATCH V4 10/10] MdeModulePkg: Enable variable runtime cache by default
To: Michael Kubacki <michael.a.kubacki@intel.com>, devel@edk2.groups.io
Cc: Dandan Bi <dandan.bi@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>, Eric Dong <eric.dong@intel.com>,
 Liming Gao <liming.gao@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Jian J Wang <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>
References: <20191014233001.33024-1-michael.a.kubacki@intel.com>
 <20191014233001.33024-11-michael.a.kubacki@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <67af4253-d06b-64e2-3a23-05b873040e58@redhat.com>
Date: Tue, 15 Oct 2019 09:33:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20191014233001.33024-11-michael.a.kubacki@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 15 Oct 2019 07:33:12 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 10/15/19 01:30, Michael Kubacki wrote:
> This change enables the variable runtime cache by default by setting
> gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in
> MdeModulePkg.dec to TRUE.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index a00835cb84..f2ff35d052 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -651,7 +651,7 @@
>    #   TRUE  - The UEFI variable runtime cache is enabled.<BR>
>    #   FALSE - The UEFI variable runtime cache is disabled.<BR>
>    # @Prompt Enable the UEFI variable runtime cache.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE|BOOLEAN|0x00010039
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|TRUE|BOOLEAN|0x00010039
>  
>    ## Indicates if the statistics about variable usage will be collected. This information is
>    #  stored as a vendor configuration table into the EFI system table.
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you!
Laszlo