Re: [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller

[Laszlo Ersek <lersek@redhat.com>]

Hi Liming,

On 08/09/18 15:22, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: extra_flags_rhbz1540244_v2
> 
> Version 1 of this set was posted at
> 
>   http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
>   https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
> 
> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
> generator and the "antlr" parser generator) are not modified. Relative
> to v1:
> 
> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
>   been dropped,
> 
> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
>   "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
>   and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
>   caller".
> 
> In other words, v2 is a proper subset of v1, so that PCCTS is left
> alone.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>

do you have any comments on patches #4 and #5?

Thanks,
Laszlo