From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 629FB210EB11F
 for <edk2-devel@lists.01.org>; Wed, 15 Aug 2018 10:19:21 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id C4186402315B;
 Wed, 15 Aug 2018 17:19:20 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-100.rdu2.redhat.com
 [10.10.120.100])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 329DB1006EAF;
 Wed, 15 Aug 2018 17:19:19 +0000 (UTC)
From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
References: <20180809132258.21874-1-lersek@redhat.com>
Message-ID: <67ba2d48-e31f-92c5-e7bd-4453b4899b61@redhat.com>
Date: Wed, 15 Aug 2018 19:19:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180809132258.21874-1-lersek@redhat.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.6]); Wed, 15 Aug 2018 17:19:20 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
 Wed, 15 Aug 2018 17:19:20 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v2 0/5] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Aug 2018 17:19:22 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Liming,

On 08/09/18 15:22, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: extra_flags_rhbz1540244_v2
> 
> Version 1 of this set was posted at
> 
>   http://mid.mail-archive.com/20180726004415.13381-1-lersek@redhat.com
>   https://lists.01.org/pipermail/edk2-devel/2018-July/027606.html
> 
> In version 2 (i.e., this version), the PCCTS tools (the "dlg" lexer
> generator and the "antlr" parser generator) are not modified. Relative
> to v1:
> 
> - "[PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles" has
>   been dropped,
> 
> - the "BaseTools/Source/C/VfrCompile/Pccts" hunks have been removed from
>   "[PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller"
>   and "[PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS from the
>   caller".
> 
> In other words, v2 is a proper subset of v1, so that PCCTS is left
> alone.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>

do you have any comments on patches #4 and #5?

Thanks,
Laszlo