Re: [edk2-devel] [PATCH edk2-platforms v2 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 19.01.2024 o 20:18, Leif Lindholm pisze:
>> +UINT64
>> +SbsaQemuGetCpuNumaNode (
>> +  IN UINTN   CpuId
>> +  )
>> +{
>> +  UINTN SmcResult;
>> +  UINTN Arg0;
>> +  UINTN Arg1;
>> +
>> +  Arg0 = CpuId;
>> +
>> +  SmcResult = ArmCallSmc0 (SIP_SVC_GET_CPU_NODE, &Arg0, &Arg1, NULL);

> It does seem a bit wasteful we're making the same call twice per core,
> discarding one of the results.
> Could we have an init function that allocates an array and
> prepopulates it, with the Get-functions just returning values from the array?

We have discussed it over IRC and decided to merge working version first.

EDK2 statically links libraries into modules so "static struct" solution 
I tried to use does not work. Turning SbsaHardwareInfoLib into protocol 
would probably solve the problem but that's out of my knowledge of EDK2 
internals.

Also do not like idea of memory buffer with some DynamicPcd pointing to it.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115350): https://edk2.groups.io/g/devel/message/115350
Mute This Topic: https://groups.io/mt/103758014/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-