From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 5E2D080402
 for <edk2-devel@lists.01.org>; Thu, 23 Mar 2017 10:28:42 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id AEEC27F3EC;
 Thu, 23 Mar 2017 17:28:42 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AEEC27F3EC
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com;
 spf=pass smtp.mailfrom=lersek@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AEEC27F3EC
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com
 [10.3.116.84])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 0A0471915A;
 Thu, 23 Mar 2017 17:28:40 +0000 (UTC)
To: Qin Long <qin.long@intel.com>, edk2-devel@lists.01.org
References: <20170323131932.6168-1-qin.long@intel.com>
Cc: ard.biesheuvel@linaro.org, ting.ye@intel.com, ronald.cron@arm.com,
 jiaxin.wu@intel.com, glin@suse.com
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <67c6f25e-49c7-d2e9-835f-d249f3b48c3d@redhat.com>
Date: Thu, 23 Mar 2017 18:28:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170323131932.6168-1-qin.long@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.25]); Thu, 23 Mar 2017 17:28:42 +0000 (UTC)
Subject: Re: [PATCH v2 00/11] Upgrade CryptoPkg to use the OpenSSL 1.1.0xx/stable release
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Mar 2017 17:28:42 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 03/23/17 14:19, Qin Long wrote:
> V2 Changes:
>   1. Re-format patch series & handle some format fixes
>      (as Laszlo Ersek's comments);
>   2. Updated TlsLib Wrapper (as Thomas Palmer's comments);
>   3. Add "ENGINESDIR" definition to support OpenSSL build if
>      engine is enabled (as Moso Lee's comments)

Was #3 a public comment? I don't recall seeing it on the list.

(Not arguing against #3, I just think that comments should preferably be
public.)

Thanks,
Laszlo