From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2277.1595019417901572548 for ; Fri, 17 Jul 2020 13:56:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f1NuraWT; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595019417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T+Tq+svE/eAJzl0SnmSYQQXkoMUKwZ/i940rZ46slEA=; b=f1NuraWTIuaIQBbi1dZ8c9IxDMwzcr7V+DQIo3laIYX3f+l2a5fqyMmaeohVOHNrskFfoA vQfemCjkcljpeMRoSthG8ZySeDvb6MZ9GtK79WVwmaFI1n3Np3iT02qLzGXJtf+hqmSwgv zmlHK5puBJ8gEkpisq4/3WX3BxEDKJo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-si3mNvGbP2qSmhsQlatFAg-1; Fri, 17 Jul 2020 16:56:53 -0400 X-MC-Unique: si3mNvGbP2qSmhsQlatFAg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B156800484; Fri, 17 Jul 2020 20:56:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-68.ams2.redhat.com [10.36.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DF7A78521; Fri, 17 Jul 2020 20:56:48 +0000 (UTC) Subject: Re: [PATCH v3 00/11] Introduce LsiScsi driver to OvmfPkg To: Gary Lin , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel References: <20200717061130.8881-1-glin@suse.com> From: "Laszlo Ersek" Message-ID: <67eb0afc-8232-fce2-af81-6e6bc58db754@redhat.com> Date: Fri, 17 Jul 2020 22:56:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200717061130.8881-1-glin@suse.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/17/20 08:11, Gary Lin wrote: > This patch series implement the driver for LSI 53C895A SCSI controller > for OVMF so that the user can access the storage devices connected to > QEMU "lsi" controller. The driver is disabled by default since LSI > 53C895A is considered as a legacy device. To enable the driver, please > add "-D LSI_SCSI_ENABLE" when building OvmfPkg. > > The patch series is also available in my git branch: > https://github.com/lcp/edk2/tree/ovmf-lsi-v3 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > > v3: > - Set DStat, SIst0, and SIst1 to 0 before using them > - Amend the if statements for the DMA data instruction and add the > assertions for the data direction > - Also set SenseDataLength to 0 on the error path > - Fix typos and amend comments > - Squash "Calculate the transferred bytes" into "Process the SCSI > Request Packet" > - Amend the error handling of the calculation of transferred bytes > - Squash the spurious newline > v2: > - Fix the mixed-case GUID string > - Remove "STATIC" from LsiScsiControllerSupported() > - Move the closing of PciIo protocol to the right patch > - Add asserts for PcdLsiScsiMaxTargetLimit and PcdLsiScsiMaxLunLimit > - Handle the "Target" array correctly > - Use BITx macros for the bit constants > - Replace 0x10000 with SIZE_64KB macro for the DMA buffer data array > - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need > 64-bit DMA address > - Fix a typo > - Fix the coding style of the instructions for the script. > - Improve the error handling in LsiScsiProcessRequest() > - Calculate the transferred bytes after the execution of the script > > Gary Lin (11): > OvmfPkg/LsiScsiDxe: Create the empty driver > OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding > OvmfPkg/LsiScsiDxe: Report the name of the driver > OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi > OvmfPkg/LsiScsiDxe: Install stubbed EXT_SCSI_PASS_THRU > OvmfPkg/LsiScsiDxe: Report Targets and LUNs > OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device > OvmfPkg/LsiScsiDxe: Map DMA buffer > OvmfPkg/LsiScsiDxe: Examine the incoming SCSI Request Packet > OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet > Maintainers.txt: Add Gary Lin as the reviewer for LsiScsi driver > > Maintainers.txt | 4 + > OvmfPkg/Include/IndustryStandard/LsiScsi.h | 105 ++ > OvmfPkg/LsiScsiDxe/LsiScsi.c | 1210 ++++++++++++++++++++ > OvmfPkg/LsiScsiDxe/LsiScsi.h | 202 ++++ > OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 46 + > OvmfPkg/OvmfPkg.dec | 8 + > OvmfPkg/OvmfPkgIa32.dsc | 4 + > OvmfPkg/OvmfPkgIa32.fdf | 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | 4 + > OvmfPkg/OvmfPkgIa32X64.fdf | 3 + > OvmfPkg/OvmfPkgX64.dsc | 4 + > OvmfPkg/OvmfPkgX64.fdf | 3 + > 12 files changed, 1596 insertions(+) > create mode 100644 OvmfPkg/Include/IndustryStandard/LsiScsi.h > create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.c > create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsi.h > create mode 100644 OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf > Merged in commit range 6ff53d2a1374..3d8327496762, via . Thanks! Laszlo