Re: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance.

[Laszlo Ersek <lersek@redhat.com>]

On 09/25/18 03:11, Jiaxin Wu wrote:
> *v2: The first three patches(1/2/3) are the same with version 1, just update the last two
> patches (4/5):
> I) <MdeModulePkg/MdeModulePkg.dec: Define one PCD for PXE to specify MTFTP windowsize.>
> This patch has been discarded since we rename and redefine the PCD in NetworkPkg instead 
> of MdeModulePkg. The replacement is: 
> [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize.
> II) <NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.>
> Since the new PCD (PcdPxeTftpWindowSize) was renamed/defined in NetworkPkg instead of 
> MdeModulePkg, we udpate the consuming PXE driver. The new version patch is:
> [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886
> 
> The series patches are to support the TFTP windowsize option described in RFC 7440.
> TFTP shell command and UEFI PXE driver will use the feature to benefit the download 
> performance.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Carsey Jaben <jaben.carsey@intel.com>
> Cc: Shao Ming <ming.shao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (5):
>   MdeModulePke/Mtftp4Dxe: Support windowsize in read request operation.
>   NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation.
>   ShellPkg/TftpDynamicCommand: Add one option for tftp command to
>     specify windowsize.
>   NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize.
>   NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize.

You didn't include the (unchanged) patches #1 through #3 from the v1
series in this posting. Hence, a reminder: please don't forget to pick
up my T-b for patches #1 and #2, from:

http://mid.mail-archive.com/bbd4d8e9-6470-8cc8-ff7d-6b154adbd7ce@redhat.com

I'll comment more elsewhere under the v2 posting.

Thanks!
Laszlo