From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8EEBB21130057 for ; Tue, 25 Sep 2018 13:07:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 186CB3082142; Tue, 25 Sep 2018 20:07:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 976A73091375; Tue, 25 Sep 2018 20:07:38 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Shao Ming , Carsey Jaben , Fu Siyuan References: <20180925011145.14316-1-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <67fec876-3103-df2e-d2db-707d8c2bf144@redhat.com> Date: Tue, 25 Sep 2018 22:07:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925011145.14316-1-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 25 Sep 2018 20:07:40 +0000 (UTC) Subject: Re: [PATCH v2 0/5] Support windowsize to benefit tftp/pxe download performance. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 20:07:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: The first three patches(1/2/3) are the same with version 1, just update the last two > patches (4/5): > I) > This patch has been discarded since we rename and redefine the PCD in NetworkPkg instead > of MdeModulePkg. The replacement is: > [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize. > II) > Since the new PCD (PcdPxeTftpWindowSize) was renamed/defined in NetworkPkg instead of > MdeModulePkg, we udpate the consuming PXE driver. The new version patch is: > [PATCH v2 5/5] NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > The series patches are to support the TFTP windowsize option described in RFC 7440. > TFTP shell command and UEFI PXE driver will use the feature to benefit the download > performance. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Carsey Jaben > Cc: Shao Ming > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > > Jiaxin Wu (5): > MdeModulePke/Mtftp4Dxe: Support windowsize in read request operation. > NetworkPkg/Mtftp6Dxe: Support windowsize in read request operation. > ShellPkg/TftpDynamicCommand: Add one option for tftp command to > specify windowsize. > NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize. > NetworkPkg/UefiPxeBcDxe: Use the specified MTFTP windowsize. You didn't include the (unchanged) patches #1 through #3 from the v1 series in this posting. Hence, a reminder: please don't forget to pick up my T-b for patches #1 and #2, from: http://mid.mail-archive.com/bbd4d8e9-6470-8cc8-ff7d-6b154adbd7ce@redhat.com I'll comment more elsewhere under the v2 posting. Thanks! Laszlo