* [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
@ 2019-02-23 5:18 Rebecca Cran
2019-02-23 5:21 ` Rebecca Cran
2019-02-25 10:06 ` Laszlo Ersek
0 siblings, 2 replies; 12+ messages in thread
From: Rebecca Cran @ 2019-02-23 5:18 UTC (permalink / raw)
To: edk2-devel; +Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Rebecca Cran
---
Maintainers.txt | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7f1061d6c1..d9d3d840c5 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -31,11 +31,10 @@ Descriptions of section entries:
EDK II
------
-W: http://www.tianocore.org/edk2/
-L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
+W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
+L: https://lists.01.org/mailman/listinfo/edk2-devel
T: git - https://github.com/tianocore/edk2.git
T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
-T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
Tianocore Stewards
@@ -203,7 +202,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
M: Ruiyu Ni <ruiyu.ni@intel.com>
OvmfPkg
-W: http://www.tianocore.org/ovmf/
+W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
M: Jordan Justen <jordan.l.justen@intel.com>
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-23 5:18 [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror Rebecca Cran
@ 2019-02-23 5:21 ` Rebecca Cran
2019-02-25 10:06 ` Laszlo Ersek
1 sibling, 0 replies; 12+ messages in thread
From: Rebecca Cran @ 2019-02-23 5:21 UTC (permalink / raw)
To: edk2-devel; +Cc: Andrew Fish, Leif Lindholm, Michael D Kinney
On 2/22/19 10:18 PM, Rebecca Cran wrote:
> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
I removed the sourceforge git mirror because the latest changeset is
from a couple of weeks ago. We already have Github and Bitbucket, so I'm
not sure of the value of having a third mirror that's relatively slow to
clone and gets outdated?
--
Rebecca Cran
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-23 5:18 [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror Rebecca Cran
2019-02-23 5:21 ` Rebecca Cran
@ 2019-02-25 10:06 ` Laszlo Ersek
2019-02-25 13:36 ` Gao, Liming
1 sibling, 1 reply; 12+ messages in thread
From: Laszlo Ersek @ 2019-02-25 10:06 UTC (permalink / raw)
To: Rebecca Cran, edk2-devel; +Cc: Michael D Kinney
On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
> ---
> Maintainers.txt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7f1061d6c1..d9d3d840c5 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -31,11 +31,10 @@ Descriptions of section entries:
>
> EDK II
> ------
> -W: http://www.tianocore.org/edk2/
> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
> +L: https://lists.01.org/mailman/listinfo/edk2-devel
> T: git - https://github.com/tianocore/edk2.git
> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
> T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>
> Tianocore Stewards
> @@ -203,7 +202,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
> M: Ruiyu Ni <ruiyu.ni@intel.com>
>
> OvmfPkg
> -W: http://www.tianocore.org/ovmf/
> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
> M: Jordan Justen <jordan.l.justen@intel.com>
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
I can help push this change, but first let's wait for more feedback. I
think the only point that might see a bit of discussion is dropping
<git.code.sf.net> (as you highlight in your followup).
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-25 10:06 ` Laszlo Ersek
@ 2019-02-25 13:36 ` Gao, Liming
2019-02-25 19:36 ` Laszlo Ersek
0 siblings, 1 reply; 12+ messages in thread
From: Gao, Liming @ 2019-02-25 13:36 UTC (permalink / raw)
To: Laszlo Ersek, Rebecca Cran, edk2-devel@lists.01.org; +Cc: Kinney, Michael D
I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. Seemly, it doesn't work. So, I agree to remove it.
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
> Sent: Monday, February 25, 2019 6:07 PM
> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
>
> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
> > ---
> > Maintainers.txt | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 7f1061d6c1..d9d3d840c5 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -31,11 +31,10 @@ Descriptions of section entries:
> >
> > EDK II
> > ------
> > -W: http://www.tianocore.org/edk2/
> > -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
> > +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
> > +L: https://lists.01.org/mailman/listinfo/edk2-devel
> > T: git - https://github.com/tianocore/edk2.git
> > T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
> > -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
> > T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
> >
> > Tianocore Stewards
> > @@ -203,7 +202,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
> > M: Ruiyu Ni <ruiyu.ni@intel.com>
> >
> > OvmfPkg
> > -W: http://www.tianocore.org/ovmf/
> > +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
> > M: Jordan Justen <jordan.l.justen@intel.com>
> > M: Laszlo Ersek <lersek@redhat.com>
> > M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> I can help push this change, but first let's wait for more feedback. I
> think the only point that might see a bit of discussion is dropping
> <git.code.sf.net> (as you highlight in your followup).
>
> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-25 13:36 ` Gao, Liming
@ 2019-02-25 19:36 ` Laszlo Ersek
2019-02-25 23:56 ` Gao, Liming
0 siblings, 1 reply; 12+ messages in thread
From: Laszlo Ersek @ 2019-02-25 19:36 UTC (permalink / raw)
To: Gao, Liming, Rebecca Cran, edk2-devel@lists.01.org; +Cc: Kinney, Michael D
On 02/25/19 14:36, Gao, Liming wrote:
> I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. Seemly, it doesn't work. So, I agree to remove it.
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
Do we consider this a bugfix, suitable to be pushed during the soft
feature freeze?
I suggest that we do.
Thanks,
Laszlo
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
>> Sent: Monday, February 25, 2019 6:07 PM
>> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
>>
>> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
>>> ---
>>> Maintainers.txt | 7 +++----
>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>> index 7f1061d6c1..d9d3d840c5 100644
>>> --- a/Maintainers.txt
>>> +++ b/Maintainers.txt
>>> @@ -31,11 +31,10 @@ Descriptions of section entries:
>>>
>>> EDK II
>>> ------
>>> -W: http://www.tianocore.org/edk2/
>>> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
>>> +L: https://lists.01.org/mailman/listinfo/edk2-devel
>>> T: git - https://github.com/tianocore/edk2.git
>>> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>>> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>>> T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>>>
>>> Tianocore Stewards
>>> @@ -203,7 +202,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
>>> M: Ruiyu Ni <ruiyu.ni@intel.com>
>>>
>>> OvmfPkg
>>> -W: http://www.tianocore.org/ovmf/
>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
>>> M: Jordan Justen <jordan.l.justen@intel.com>
>>> M: Laszlo Ersek <lersek@redhat.com>
>>> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> I can help push this change, but first let's wait for more feedback. I
>> think the only point that might see a bit of discussion is dropping
>> <git.code.sf.net> (as you highlight in your followup).
>>
>> Thanks!
>> Laszlo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-25 19:36 ` Laszlo Ersek
@ 2019-02-25 23:56 ` Gao, Liming
2019-02-26 12:28 ` Laszlo Ersek
0 siblings, 1 reply; 12+ messages in thread
From: Gao, Liming @ 2019-02-25 23:56 UTC (permalink / raw)
To: Laszlo Ersek, Rebecca Cran, edk2-devel@lists.01.org; +Cc: Kinney, Michael D
Yes. This is a bug fix. I agree to push it for Q1 release.
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Laszlo Ersek
>Sent: Tuesday, February 26, 2019 3:36 AM
>To: Gao, Liming <liming.gao@intel.com>; Rebecca Cran
><rebecca@bluestop.org>; edk2-devel@lists.01.org
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>outdated sourceforge git mirror
>
>On 02/25/19 14:36, Gao, Liming wrote:
>> I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2.
>Seemly, it doesn't work. So, I agree to remove it.
>>
>> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>Do we consider this a bugfix, suitable to be pushed during the soft
>feature freeze?
>
>I suggest that we do.
>
>Thanks,
>Laszlo
>
>
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Laszlo Ersek
>>> Sent: Monday, February 25, 2019 6:07 PM
>>> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>outdated sourceforge git mirror
>>>
>>> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
>>>> ---
>>>> Maintainers.txt | 7 +++----
>>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>>> index 7f1061d6c1..d9d3d840c5 100644
>>>> --- a/Maintainers.txt
>>>> +++ b/Maintainers.txt
>>>> @@ -31,11 +31,10 @@ Descriptions of section entries:
>>>>
>>>> EDK II
>>>> ------
>>>> -W: http://www.tianocore.org/edk2/
>>>> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
>>>> +L: https://lists.01.org/mailman/listinfo/edk2-devel
>>>> T: git - https://github.com/tianocore/edk2.git
>>>> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>>>> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>>>> T: svn (read-only, deprecated) -
>https://svn.code.sf.net/p/edk2/code/trunk/edk2
>>>>
>>>> Tianocore Stewards
>>>> @@ -203,7 +202,7 @@ W:
>https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
>>>> M: Ruiyu Ni <ruiyu.ni@intel.com>
>>>>
>>>> OvmfPkg
>>>> -W: http://www.tianocore.org/ovmf/
>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
>>>> M: Jordan Justen <jordan.l.justen@intel.com>
>>>> M: Laszlo Ersek <lersek@redhat.com>
>>>> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>>
>>>
>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>
>>> I can help push this change, but first let's wait for more feedback. I
>>> think the only point that might see a bit of discussion is dropping
>>> <git.code.sf.net> (as you highlight in your followup).
>>>
>>> Thanks!
>>> Laszlo
>
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror
2019-02-25 23:56 ` Gao, Liming
@ 2019-02-26 12:28 ` Laszlo Ersek
0 siblings, 0 replies; 12+ messages in thread
From: Laszlo Ersek @ 2019-02-26 12:28 UTC (permalink / raw)
To: Rebecca Cran; +Cc: Gao, Liming, edk2-devel@lists.01.org, Kinney, Michael D
Rebecca,
On 02/26/19 00:56, Gao, Liming wrote:
> Yes. This is a bug fix. I agree to push it for Q1 release.
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Tuesday, February 26, 2019 3:36 AM
>> To: Gao, Liming <liming.gao@intel.com>; Rebecca Cran
>> <rebecca@bluestop.org>; edk2-devel@lists.01.org
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>> outdated sourceforge git mirror
>>
>> On 02/25/19 14:36, Gao, Liming wrote:
>>> I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2.
>> Seemly, it doesn't work. So, I agree to remove it.
>>>
>>> Reviewed-by: Liming Gao <liming.gao@intel.com>
>>
>> Do we consider this a bugfix, suitable to be pushed during the soft
>> feature freeze?
>>
>> I suggest that we do.
I've tried applying this patch, and found two issues.
First, you didn't add:
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
Second, this patch is based on a very outdated state of the edk2 tree. I
have to apply it on top of commit 2d4fd226da42 ("BaseTools GenFw: Fix
XCODE5 build issue", 2019-01-15); otherwise it doesn't apply. It runs
into a conflict with commit 1f7b74831544 ("Maintainers.txt: Update mail
address", 2019-01-15).
I could fix issue #2 with a rebase myself; however, issue #1 has to be
fixed by you. Please post a v3, addressing both issues, and also picking
up the feedback tags that you received in this thread (from Liming and
myself).
Thanks,
Laszlo
>>>> -----Original Message-----
>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>>>> Sent: Monday, February 25, 2019 6:07 PM
>>>> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>>>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow,
>> outdated sourceforge git mirror
>>>>
>>>> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote:
>>>>> ---
>>>>> Maintainers.txt | 7 +++----
>>>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/Maintainers.txt b/Maintainers.txt
>>>>> index 7f1061d6c1..d9d3d840c5 100644
>>>>> --- a/Maintainers.txt
>>>>> +++ b/Maintainers.txt
>>>>> @@ -31,11 +31,10 @@ Descriptions of section entries:
>>>>>
>>>>> EDK II
>>>>> ------
>>>>> -W: http://www.tianocore.org/edk2/
>>>>> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
>>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II
>>>>> +L: https://lists.01.org/mailman/listinfo/edk2-devel
>>>>> T: git - https://github.com/tianocore/edk2.git
>>>>> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
>>>>> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>>>>> T: svn (read-only, deprecated) -
>> https://svn.code.sf.net/p/edk2/code/trunk/edk2
>>>>>
>>>>> Tianocore Stewards
>>>>> @@ -203,7 +202,7 @@ W:
>> https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg
>>>>> M: Ruiyu Ni <ruiyu.ni@intel.com>
>>>>>
>>>>> OvmfPkg
>>>>> -W: http://www.tianocore.org/ovmf/
>>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF
>>>>> M: Jordan Justen <jordan.l.justen@intel.com>
>>>>> M: Laszlo Ersek <lersek@redhat.com>
>>>>> M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>>>
>>>>
>>>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>>>
>>>> I can help push this change, but first let's wait for more feedback. I
>>>> think the only point that might see a bit of discussion is dropping
>>>> <git.code.sf.net> (as you highlight in your followup).
>>>>
>>>> Thanks!
>>>> Laszlo
>>
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
@ 2019-03-24 2:00 Rebecca Cran
2019-03-25 11:49 ` Laszlo Ersek
0 siblings, 1 reply; 12+ messages in thread
From: Rebecca Cran @ 2019-03-24 2:00 UTC (permalink / raw)
To: edk2-devel
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
---
Maintainers.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index be77898ee2..4c9adf802b 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -40,10 +40,9 @@ Descriptions of section entries:
EDK II
------
W: http://www.tianocore.org/edk2/
-L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
+L: https://lists.01.org/mailman/listinfo/edk2-devel
T: git - https://github.com/tianocore/edk2.git
T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
-T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
Tianocore Stewards
--
2.21.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
2019-03-24 2:00 [PATCH] Fix links in Maintainers.txt and remove slow " Rebecca Cran
@ 2019-03-25 11:49 ` Laszlo Ersek
2019-03-25 12:28 ` Gao, Liming
2019-03-25 13:30 ` Rebecca Cran
0 siblings, 2 replies; 12+ messages in thread
From: Laszlo Ersek @ 2019-03-25 11:49 UTC (permalink / raw)
To: Rebecca Cran, edk2-devel; +Cc: Gao, Liming
(+Liming)
OK, so the last comment on this patch was at:
http://mid.mail-archive.com/6800a51b-fa21-f325-bbc1-d17e3c8b62e2@redhat.com
Let's see the changes:
On 03/24/19 03:00, Rebecca Cran via edk2-devel wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
This looks good. (The contributed-under line will soon become
unnecessary, but for now it's still required & correct, AIUI.)
> ---
> Maintainers.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index be77898ee2..4c9adf802b 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -40,10 +40,9 @@ Descriptions of section entries:
> EDK II
> ------
> W: http://www.tianocore.org/edk2/
Any particular reason for dropping the website URL update?
<http://www.tianocore.org/edk2/> still redirects to
<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II>, and your
previous patch (correctly) included that new URL.
> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
> +L: https://lists.01.org/mailman/listinfo/edk2-devel
This is the same as before, and it's good (we'll change this soon to
groups.io, I reckon, but for now it's good).
> T: git - https://github.com/tianocore/edk2.git
> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
Same as before, and also good.
> T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
>
> Tianocore Stewards
>
So, if you dropped the "W:" change intentionally, I don't mind. After
all, the original link still works, and the patch is still a pure
improvement.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
If Liming too is OK with this patch (and you don't intend to update it),
I can help push it.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
2019-03-25 11:49 ` Laszlo Ersek
@ 2019-03-25 12:28 ` Gao, Liming
2019-03-25 13:30 ` Rebecca Cran
1 sibling, 0 replies; 12+ messages in thread
From: Gao, Liming @ 2019-03-25 12:28 UTC (permalink / raw)
To: Laszlo Ersek, Rebecca Cran, edk2-devel@lists.01.org
This change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, March 25, 2019 7:50 PM
> To: Rebecca Cran <rebecca@bluestop.org>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
>
> (+Liming)
>
> OK, so the last comment on this patch was at:
>
> http://mid.mail-archive.com/6800a51b-fa21-f325-bbc1-d17e3c8b62e2@redhat.com
>
> Let's see the changes:
>
>
> On 03/24/19 03:00, Rebecca Cran via edk2-devel wrote:
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Rebecca Cran <rebecca@bluestop.org>
>
> This looks good. (The contributed-under line will soon become
> unnecessary, but for now it's still required & correct, AIUI.)
>
> > ---
> > Maintainers.txt | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index be77898ee2..4c9adf802b 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -40,10 +40,9 @@ Descriptions of section entries:
> > EDK II
> > ------
> > W: http://www.tianocore.org/edk2/
>
> Any particular reason for dropping the website URL update?
> <http://www.tianocore.org/edk2/> still redirects to
> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II>, and your
> previous patch (correctly) included that new URL.
>
> > -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel
> > +L: https://lists.01.org/mailman/listinfo/edk2-devel
>
> This is the same as before, and it's good (we'll change this soon to
> groups.io, I reckon, but for now it's good).
>
> > T: git - https://github.com/tianocore/edk2.git
> > T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
> > -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2
>
> Same as before, and also good.
>
> > T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
> >
> > Tianocore Stewards
> >
>
> So, if you dropped the "W:" change intentionally, I don't mind. After
> all, the original link still works, and the patch is still a pure
> improvement.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> If Liming too is OK with this patch (and you don't intend to update it),
> I can help push it.
>
> Thanks
> Laszlo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
2019-03-25 11:49 ` Laszlo Ersek
2019-03-25 12:28 ` Gao, Liming
@ 2019-03-25 13:30 ` Rebecca Cran
2019-03-25 14:26 ` Laszlo Ersek
1 sibling, 1 reply; 12+ messages in thread
From: Rebecca Cran @ 2019-03-25 13:30 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel; +Cc: Gao, Liming
On 3/25/19 5:49 AM, Laszlo Ersek wrote:
>
> Any particular reason for dropping the website URL update?
> <http://www.tianocore.org/edk2/> still redirects to
> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II>, and your
> previous patch (correctly) included that new URL.
Stephano recently posted a message with a link tohttps://www.tianocore.org/monthly-meeting/ which redirects to https://github.com/tianocore/tianocore.github.io/wiki/Monthly-Meeting, so I think it makes sense to keep the shorter/nicer URLs since there are redirects in place.
--
Rebecca Cran
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Fix links in Maintainers.txt and remove slow outdated sourceforge git mirror
2019-03-25 13:30 ` Rebecca Cran
@ 2019-03-25 14:26 ` Laszlo Ersek
0 siblings, 0 replies; 12+ messages in thread
From: Laszlo Ersek @ 2019-03-25 14:26 UTC (permalink / raw)
To: Rebecca Cran, edk2-devel; +Cc: Gao, Liming
On 03/25/19 14:30, Rebecca Cran via edk2-devel wrote:
> On 3/25/19 5:49 AM, Laszlo Ersek wrote:
>>
>> Any particular reason for dropping the website URL update?
>> <http://www.tianocore.org/edk2/> still redirects to
>> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II>, and your
>> previous patch (correctly) included that new URL.
>
>
> Stephano recently posted a message with a link
> tohttps://www.tianocore.org/monthly-meeting/ which redirects to
> https://github.com/tianocore/tianocore.github.io/wiki/Monthly-Meeting,
> so I think it makes sense to keep the shorter/nicer URLs since there are
> redirects in place.
>
Pushed as commit b669adebd01d, with Liming's R-b, and mine.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-25 14:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-23 5:18 [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror Rebecca Cran
2019-02-23 5:21 ` Rebecca Cran
2019-02-25 10:06 ` Laszlo Ersek
2019-02-25 13:36 ` Gao, Liming
2019-02-25 19:36 ` Laszlo Ersek
2019-02-25 23:56 ` Gao, Liming
2019-02-26 12:28 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2019-03-24 2:00 [PATCH] Fix links in Maintainers.txt and remove slow " Rebecca Cran
2019-03-25 11:49 ` Laszlo Ersek
2019-03-25 12:28 ` Gao, Liming
2019-03-25 13:30 ` Rebecca Cran
2019-03-25 14:26 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox