From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1126D208AE2B8 for ; Tue, 26 Feb 2019 04:28:55 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DAB98B101; Tue, 26 Feb 2019 12:28:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-155.rdu2.redhat.com [10.10.120.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1028600C0; Tue, 26 Feb 2019 12:28:53 +0000 (UTC) To: Rebecca Cran Cc: "Gao, Liming" , "edk2-devel@lists.01.org" , "Kinney, Michael D" References: <20190223051829.75597-1-rebecca@bluestop.org> <02e1cef2-1e76-21a7-a517-00ffad9947c5@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E7454@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E7718@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <6800a51b-fa21-f325-bbc1-d17e3c8b62e2@redhat.com> Date: Tue, 26 Feb 2019 13:28:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E7718@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 26 Feb 2019 12:28:55 +0000 (UTC) Subject: Re: [PATCH] Fix links in Maintainers.txt and remove slow, outdated sourceforge git mirror X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 12:28:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Rebecca, On 02/26/19 00:56, Gao, Liming wrote: > Yes. This is a bug fix. I agree to push it for Q1 release. > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, February 26, 2019 3:36 AM >> To: Gao, Liming ; Rebecca Cran >> ; edk2-devel@lists.01.org >> Cc: Kinney, Michael D >> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, >> outdated sourceforge git mirror >> >> On 02/25/19 14:36, Gao, Liming wrote: >>> I can't clone edk2 code from http://git.code.sf.net/p/tianocore/edk2. >> Seemly, it doesn't work. So, I agree to remove it. >>> >>> Reviewed-by: Liming Gao >> >> Do we consider this a bugfix, suitable to be pushed during the soft >> feature freeze? >> >> I suggest that we do. I've tried applying this patch, and found two issues. First, you didn't add: Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Rebecca Cran Second, this patch is based on a very outdated state of the edk2 tree. I have to apply it on top of commit 2d4fd226da42 ("BaseTools GenFw: Fix XCODE5 build issue", 2019-01-15); otherwise it doesn't apply. It runs into a conflict with commit 1f7b74831544 ("Maintainers.txt: Update mail address", 2019-01-15). I could fix issue #2 with a rebase myself; however, issue #1 has to be fixed by you. Please post a v3, addressing both issues, and also picking up the feedback tags that you received in this thread (from Liming and myself). Thanks, Laszlo >>>> -----Original Message----- >>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Laszlo Ersek >>>> Sent: Monday, February 25, 2019 6:07 PM >>>> To: Rebecca Cran ; edk2-devel@lists.01.org >>>> Cc: Kinney, Michael D >>>> Subject: Re: [edk2] [PATCH] Fix links in Maintainers.txt and remove slow, >> outdated sourceforge git mirror >>>> >>>> On 02/23/19 06:18, Rebecca Cran via edk2-devel wrote: >>>>> --- >>>>> Maintainers.txt | 7 +++---- >>>>> 1 file changed, 3 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/Maintainers.txt b/Maintainers.txt >>>>> index 7f1061d6c1..d9d3d840c5 100644 >>>>> --- a/Maintainers.txt >>>>> +++ b/Maintainers.txt >>>>> @@ -31,11 +31,10 @@ Descriptions of section entries: >>>>> >>>>> EDK II >>>>> ------ >>>>> -W: http://www.tianocore.org/edk2/ >>>>> -L: https://lists.sourceforge.net/lists/listinfo/edk2-devel >>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II >>>>> +L: https://lists.01.org/mailman/listinfo/edk2-devel >>>>> T: git - https://github.com/tianocore/edk2.git >>>>> T: git (mirror) - https://bitbucket.org/tianocore/edk2.git >>>>> -T: git (mirror) - http://git.code.sf.net/p/tianocore/edk2 >>>>> T: svn (read-only, deprecated) - >> https://svn.code.sf.net/p/edk2/code/trunk/edk2 >>>>> >>>>> Tianocore Stewards >>>>> @@ -203,7 +202,7 @@ W: >> https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg >>>>> M: Ruiyu Ni >>>>> >>>>> OvmfPkg >>>>> -W: http://www.tianocore.org/ovmf/ >>>>> +W: https://github.com/tianocore/tianocore.github.io/wiki/OVMF >>>>> M: Jordan Justen >>>>> M: Laszlo Ersek >>>>> M: Ard Biesheuvel >>>>> >>>> >>>> Reviewed-by: Laszlo Ersek >>>> >>>> I can help push this change, but first let's wait for more feedback. I >>>> think the only point that might see a bit of discussion is dropping >>>> (as you highlight in your followup). >>>> >>>> Thanks! >>>> Laszlo >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >