From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web11.3092.1622061648277617313 for ; Wed, 26 May 2021 13:40:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=OwGXCx6Z; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=SEcd069t4zYpbxgf/kkNSIBq1c1ZQH1CjksYOOzW0iA=; b=OwGXCx6ZJiEswZ6qIw/TEnvghu sEzT+Oh5ET1wazFKTyFVveYKxADd/wtvLf6bXNlNRnGx1hr+0B0rPm+PV0IRvqWQxQKxeaKaV4BAP VtGGskACdRwAhFRytCS/f8s1xDsPInC1o8amtzZZtkN+MfzZSeehhNIs522Ye0L26J7Y=; Received: from in01.mta.xmission.com ([166.70.13.51]) by out01.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lm0Ka-00BTs4-E3; Wed, 26 May 2021 14:40:44 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1lm0KY-0002pw-P9; Wed, 26 May 2021 14:40:44 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 866171281707; Wed, 26 May 2021 14:40:42 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id nV5aXjm2_5Xj; Wed, 26 May 2021 14:40:42 -0600 (MDT) Received: from photon.int.bsdio.com (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 479CB1280AA2; Wed, 26 May 2021 14:40:42 -0600 (MDT) To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , Peter Grehan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-18-lersek@redhat.com> From: "Rebecca Cran" Message-ID: <68191aef-f774-90ff-b370-d7c7d6dcffe7@bsdio.com> Date: Wed, 26 May 2021 14:40:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-18-lersek@redhat.com> X-XM-SPF: eid=1lm0KY-0002pw-P9;;;mid=<68191aef-f774-90ff-b370-d7c7d6dcffe7@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa02.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,T_TM2_M_HEADER_IN_MSG,TooManyTo_001, XMNoVowels,XMSubLong,XM_B_Unicode,XM_B_Unicode3 autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 0.0 XM_B_Unicode3 BODY: Testing for specific types of unicode * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-DCC: XMission; sa02 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Laszlo Ersek , devel@edk2.groups.io X-Spam-Relay-Country: X-Spam-Timing: total 1129 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 4.7 (0.4%), b_tie_ro: 3.2 (0.3%), parse: 1.39 (0.1%), extract_message_metadata: 18 (1.6%), get_uri_detail_list: 1.79 (0.2%), tests_pri_-1000: 5 (0.4%), tests_pri_-950: 1.04 (0.1%), tests_pri_-900: 0.83 (0.1%), tests_pri_-90: 51 (4.5%), check_bayes: 50 (4.4%), b_tokenize: 6 (0.5%), b_tok_get_all: 7 (0.6%), b_comp_prob: 1.92 (0.2%), b_tok_touch_all: 32 (2.9%), b_finish: 0.68 (0.1%), tests_pri_0: 252 (22.3%), check_dkim_signature: 0.43 (0.0%), check_dkim_adsp: 36 (3.2%), poll_dns_idle: 800 (70.9%), tests_pri_10: 1.65 (0.1%), tests_pri_500: 791 (70.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 17/43] OvmfPkg/Bhyve/AcpiPlatformDxe: fix file path typo in comment X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 5/26/21 2:14 PM, Laszlo Ersek wrote: > The built-in ACPI tables for Bhyve are located in the > "OvmfPkg/Bhyve/AcpiTables" module, not in the "OvmfPkg/AcpiTables" module. > Correct the typo in a code comment. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > index d5c78c61d5ad..9ccdb4d91cd1 100644 > --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c > @@ -129,13 +129,13 @@ LocateFvInstanceWithTables ( > Find ACPI tables in an FV and install them. > > This is now a fall-back path. Normally, we will search for tables provided > by the VMM first. > > If that fails, we use this function to load the ACPI tables from an FV. The > - sources for the FV based tables is located under OvmfPkg/AcpiTables. > + sources for the FV based tables is located under OvmfPkg/Bhyve/AcpiTables. > > @param AcpiTable Protocol instance pointer > > **/ > EFI_STATUS > EFIAPI Reviewed-by: Rebecca Cran