From: Laszlo Ersek <lersek@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>, "Ye, Ting" <ting.ye@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.
Date: Mon, 21 Jan 2019 22:21:15 +0100 [thread overview]
Message-ID: <682a23fe-6e66-0f78-d5e3-37b375f2eeda@redhat.com> (raw)
In-Reply-To: <0b4e9578-9831-cc59-1dad-e53d44492fa0@redhat.com>
Hi Phil,
On 01/21/19 14:26, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 1/21/19 1:53 PM, Gao, Liming wrote:
>> Thanks Ard and Laszlo. For the minor change in single patch, the patch may be sent separately with the clear subject. Or, the patch set can be sent again.
>
> Since it is hard to follow technical discussion when top-posted (see
> https://www.caliburn.nl/topposting.html) without scrolling and sometime
> loosing context, can we gently suggest bottom-posting in edk2-devel
> etiquette? (No offence, this is a humble suggestion from a not very
> active reviewer to a highly active contributor, but this might ease the
> on-list review workflow).
top vs. bottom posting have been mentioned multiple times on edk2-devel;
it's just a fact that most corporate email environments don't support
bottom posting at all.
I'm unhappy about it (obviously), but it's an uphill battle. Sometimes
the poster would actually *like* to bottom post, but the tooling (which
may not be their own choice) gets in their way.
I suggest always scrolling to the bottom, or at least until you see a
signature.
Thanks,
Laszlo
next prev parent reply other threads:[~2019-01-21 21:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 5:16 [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check Jiaxin Wu
2019-01-18 5:22 ` Wu, Hao A
2019-01-18 5:29 ` Fu, Siyuan
2019-01-18 5:31 ` Wu, Jiaxin
2019-01-18 5:38 ` Gao, Liming
2019-01-18 11:09 ` Ard Biesheuvel
2019-01-19 1:17 ` Laszlo Ersek
2019-01-20 18:25 ` Wu, Jiaxin
2019-01-21 12:53 ` Gao, Liming
2019-01-21 13:26 ` Philippe Mathieu-Daudé
2019-01-21 21:21 ` Laszlo Ersek [this message]
2019-01-21 22:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682a23fe-6e66-0f78-d5e3-37b375f2eeda@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox