From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C967421A00AE6 for ; Mon, 21 Jan 2019 13:21:20 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D9FD12E50B; Mon, 21 Jan 2019 21:21:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-78.rdu2.redhat.com [10.10.121.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38C1D60CD1; Mon, 21 Jan 2019 21:21:16 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Gao, Liming" , Ard Biesheuvel Cc: "Wu, Hao A" , "Ye, Ting" , "Fu, Siyuan" , "Wu, Jiaxin" , "edk2-devel@lists.01.org" References: <20190118051612.9600-1-Jiaxin.wu@intel.com> <895558F6EA4E3B41AC93A00D163B727416EC67B5@SHSMSX107.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B4596@SHSMSX152.ccr.corp.intel.com> <70bb0ff8-09fe-42c9-0152-ffed039033bd@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3BF550@SHSMSX104.ccr.corp.intel.com> <0b4e9578-9831-cc59-1dad-e53d44492fa0@redhat.com> From: Laszlo Ersek Message-ID: <682a23fe-6e66-0f78-d5e3-37b375f2eeda@redhat.com> Date: Mon, 21 Jan 2019 22:21:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0b4e9578-9831-cc59-1dad-e53d44492fa0@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 21 Jan 2019 21:21:20 +0000 (UTC) Subject: Re: [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 21:21:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Phil, On 01/21/19 14:26, Philippe Mathieu-Daudé wrote: > Hi, > > On 1/21/19 1:53 PM, Gao, Liming wrote: >> Thanks Ard and Laszlo. For the minor change in single patch, the patch may be sent separately with the clear subject. Or, the patch set can be sent again. > > Since it is hard to follow technical discussion when top-posted (see > https://www.caliburn.nl/topposting.html) without scrolling and sometime > loosing context, can we gently suggest bottom-posting in edk2-devel > etiquette? (No offence, this is a humble suggestion from a not very > active reviewer to a highly active contributor, but this might ease the > on-list review workflow). top vs. bottom posting have been mentioned multiple times on edk2-devel; it's just a fact that most corporate email environments don't support bottom posting at all. I'm unhappy about it (obviously), but it's an uphill battle. Sometimes the poster would actually *like* to bottom post, but the tooling (which may not be their own choice) gets in their way. I suggest always scrolling to the bottom, or at least until you see a signature. Thanks, Laszlo