Re: [edk2-devel] ACPI table generator unit test

["PierreGondois via groups.io" <pierre.gondois=arm.com@groups.io>]

Hello Ard, Sophia,

On 4/10/25 08:58, Ard Biesheuvel wrote:
> cc Sami and Pierre
> 
> On Wed, 9 Apr 2025 at 21:17, Sophia Wang via groups.io
> <yodagump=google.com@groups.io> wrote:
>>
>> Gentle ping on this thread.
>>
>> As Paul mentioned, there are only two non-static functions for ACPI table generator - AcpiHmatLibConstructor() and
>> AcpiHmatLibDestructor()
>>
>> In order to do the unit test, we need to expose at least one STATIC to be non-STATIC.
>> CONST
>> ACPI_TABLE_GENERATOR  HmatGenerator.
>>
>> So we can use
>> https://github.com/tianocore/edk2/pull/10833/commits/4eeeb1434820718ace1670d9429a867fe5e8c9b7
>> to register HMAT generator (or other generators).
>>
>> Currently https://github.com/tianocore/edk2/pull/10833/commits/4eeeb1434820718ace1670d9429a867fe5e8c9b7 solution is not functional given no function call on RegisterAcpiTableGenerator().

I'm not sure I understand why the solution for the DBG2 is not functional.
It seems to work for me with the following command line:
$ stuart_ci_build -c .pytool/CISettings.py TOOL_CHAIN_TAG=GCC5 -a X64 -p DynamicTablesPkg GuidCheck=skip HostUnitTestDscCompleteCheck=skip CharEncodingCheck=skip CompilerPlugin=skip SpellCheck=skip LibraryClassCheck=skip LicenseCheck=skip DscCompleteCheck=skip DependencyCheck=skip EccCheck=skip

With Jeff's patch (i.e. the PR you linked), the RegisterAcpiTableGenerator() function is mocked to save a pointer to the generator.
Once the generator is registered, it is possible to call the BuildAcpiTableEx() callback for instace:
https://github.com/jbrasen/edk2/blob/4eeeb1434820718ace1670d9429a867fe5e8c9b7/DynamicTablesPkg/Library/Acpi/Common/AcpiDbg2Lib/GoogleTest/Dbg2GeneratorGoogleTest.cpp#L354

>>
>> I guess we all need to wait for upstream's decision on STATIC and NON_STATIC exposure for ACPI table generator unit test.
>> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121255): https://edk2.groups.io/g/devel/message/121255
Mute This Topic: https://groups.io/mt/111930977/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-