* Do BSPs only have to be logical thread 0 ? [not found] <686725847.17974924.1471378566839.JavaMail.yahoo.ref@mail.yahoo.com> @ 2016-08-16 20:16 ` Shubha Ramani 2016-08-23 3:04 ` Fan, Jeff 0 siblings, 1 reply; 4+ messages in thread From: Shubha Ramani @ 2016-08-16 20:16 UTC (permalink / raw) To: edk2-devel@lists.01.org In other words, suppose a BSP is running in hyperthreaded ON mode and it has 2 threads per physical core. Can the BSP be either thread 0 or thread 1 ?Is this documented somewhere ? Thanks, Shubha Shubha D. Ramanishubharamani@gmail.com shubharamani@yahoo.com >From jiaxin.wu@intel.com Tue Aug 16 18:41:24 2016 Return-Path: <jiaxin.wu@intel.com> X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ml01.01.org (Postfix) with ESMTP id B439A1A1DF4 for <edk2-devel@lists.01.org>; Tue, 16 Aug 2016 18:41:24 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 16 Aug 2016 18:41:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Do BSPs only have to be logical thread 0 ? 2016-08-16 20:16 ` Do BSPs only have to be logical thread 0 ? Shubha Ramani @ 2016-08-23 3:04 ` Fan, Jeff 2016-08-24 3:43 ` incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c wang xiaofeng 0 siblings, 1 reply; 4+ messages in thread From: Fan, Jeff @ 2016-08-23 3:04 UTC (permalink / raw) To: Shubha Ramani, edk2-devel@lists.01.org When system power on, one processor (usually, it is thread 0) will be selected to be BSP, it is descripted in IA32 Software Developer User Manual. On POST phase, PI MP PPI and Protocol service provide SwitchBSP() service to switch BSP to other enabled thread, it is descripted in PI specification. -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Shubha Ramani Sent: Wednesday, August 17, 2016 4:16 AM To: edk2-devel@lists.01.org Subject: [edk2] Do BSPs only have to be logical thread 0 ? In other words, suppose a BSP is running in hyperthreaded ON mode and it has 2 threads per physical core. Can the BSP be either thread 0 or thread 1 ?Is this documented somewhere ? Thanks, Shubha Shubha D. Ramanishubharamani@gmail.com shubharamani@yahoo.com _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c 2016-08-23 3:04 ` Fan, Jeff @ 2016-08-24 3:43 ` wang xiaofeng [not found] ` <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com> 0 siblings, 1 reply; 4+ messages in thread From: wang xiaofeng @ 2016-08-24 3:43 UTC (permalink / raw) To: Fan, Jeff; +Cc: edk2-devel@lists.01.org Hi Jeff, Not sure whether you owns SmmProfile.c. I found the following logic is incorrect. sizeof(mSmmProfileBase) is 8, we should use sizeof(SMM_PROFILE_HEADER). Otherwise the variable size is incorrect | gRT->SetVariable ( | | | SMM_PROFILE_NAME, | | | &gEfiCallerIdGuid, | | | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, | | | sizeof(mSmmProfileBase), | | | &mSmmProfileBase | | | ); | ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com>]
* Re: incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c [not found] ` <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com> @ 2016-08-24 4:27 ` wang xiaofeng 0 siblings, 0 replies; 4+ messages in thread From: wang xiaofeng @ 2016-08-24 4:27 UTC (permalink / raw) To: Yao, Jiewen; +Cc: Fan, Jeff, edk2-devel@lists.01.org Jiewen, Thanks for the information. At 2016-08-24 11:56:48, "Yao, Jiewen" <jiewen.yao@intel.com> wrote: >Hi >That is done by design. We just need save the *pointer* to variable region, not the *content*. >The content is in EfiReservedMemoryType memory. > >An OS application can get this pointer and parse the data pointed by mSmmProfileBase > >Thank you >Yao Jiewen > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of wang xiaofeng >Sent: Wednesday, August 24, 2016 11:43 AM >To: Fan, Jeff <jeff.fan@intel.com> >Cc: edk2-devel@lists.01.org >Subject: [edk2] incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c > >Hi Jeff, > Not sure whether you owns SmmProfile.c. I found the following logic is incorrect. > sizeof(mSmmProfileBase) is 8, we should use sizeof(SMM_PROFILE_HEADER). Otherwise the variable size is incorrect > > >| gRT->SetVariable ( | >| | SMM_PROFILE_NAME, | >| | &gEfiCallerIdGuid, | >| | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, | >| | sizeof(mSmmProfileBase), | >| | &mSmmProfileBase | >| | >); > > > > > > > > > > > > >| >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> >https://lists.01.org/mailman/listinfo/edk2-devel >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-24 4:27 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <686725847.17974924.1471378566839.JavaMail.yahoo.ref@mail.yahoo.com> 2016-08-16 20:16 ` Do BSPs only have to be logical thread 0 ? Shubha Ramani 2016-08-23 3:04 ` Fan, Jeff 2016-08-24 3:43 ` incorrected set variable size in InitSmmProfileCallBack of UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c wang xiaofeng [not found] ` <74D8A39837DF1E4DA445A8C0B3885C50028062B2@shsmsx102.ccr.corp.intel.com> 2016-08-24 4:27 ` wang xiaofeng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox