From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6513C941964 for ; Fri, 26 Jan 2024 17:56:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oH3c47Mo2Jev9lYYInqCXZjhMjKdQFcYWbpffThX8i0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:From:To:CC:References:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706291767; v=1; b=lr9/WEYIuTaArHQgCZxpW18jAKvkx+xpb/SbY6iLmuDbkqP8J+dKbpxXEYpLTxGTUriUA9Bo wM+Iy1o4FkbLL3ON2SDLB1WqNlfSynTW7i50p4HIc5IaVYCkxTR6dpOB4MgWWaOBCTIgp6XZ8vN jKSKZpizt6695vwKn5nRJsLU= X-Received: by 127.0.0.2 with SMTP id OXsyYY7687511xxIA3DmRiQG; Fri, 26 Jan 2024 09:56:07 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.84]) by mx.groups.io with SMTP id smtpd.web11.866.1706291766200097931 for ; Fri, 26 Jan 2024 09:56:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jswuyv10gSGX5+PICJogG2PxTSJ7yFhayn9pqPiBIdxzrsUyEthKMSabn39ksqk2oQhNoybY57wh8NRilqgcCfb0BCHEha9sNBA3S8CMHNmDuRLIuwi729Mo3tcDYl7s0fCUAypF3s/CzWuzzcyEvr9ye8yPlu9w8tP0bUdP68YjHUj4UvDlhQRI9gbx/yW/C5YcNMfcaqeB1/+0mLvg+yOS7KnmIloNX8gRypYSxCuK0WZoIGL0HdJKzLrbUiR6lpT5Mstl6LXNJFxQKe2hIhMcm+Ho7R5R/GbeR9EZrcLXEVxi2J9/lFDADnbt1u2UEkmht9TEK7Od7CFXBP30Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n/sZKkesn+aRUsE6/du9gpxroD6VaFJGrUPUjmfpN+I=; b=OZYl80nGJ6tBS1CwFCNamKnJYB1MoQHI4cGEILRWQA35qZ6v637a8xksDSrZND2H7Q4YmESsH50VADwe+iwvBlpoE+hpaXGF8/0zkDEFPsigz1TH3CYU42ispPZerWCHmBsLiRBA740PJAOFuEM3S0/JkYwaspjCoqImoCxLBJGLPRl8XjsCdCdrP4wObtm+xiXKiJF34RmHU0sCWG1oNQXKS38+w14S1SrW/XSpZAZNhH89m6O6rwVThSWmMOig4AZtNkwQfFcVj0B9/80HEEBggs0Cq8cNopkzXbVNQnqBe8eiquOsHp3Gm13FHZsEqHbw65qY5xdDlFFAvi5ZnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by IA0PR12MB8930.namprd12.prod.outlook.com (2603:10b6:208:481::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 17:56:04 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::200:c1d0:b9aa:e16c%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 17:56:04 +0000 Message-ID: <686c8bd7-c0de-9429-1577-f436c347c314@amd.com> Date: Fri, 26 Jan 2024 11:56:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Add feedback status for PciIoMap From: "Lendacky, Thomas via groups.io" To: devel@edk2.groups.io, w.sheng@intel.com, "Xu, Min M" CC: Ray Ni , Huang Jenny , Chiang Chris References: <20240122064706.2059-1-w.sheng@intel.com> In-Reply-To: X-ClientProxiedBy: SN7P222CA0026.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::24) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|IA0PR12MB8930:EE_ X-MS-Office365-Filtering-Correlation-Id: 897465c1-394e-496a-201d-08dc1e98108e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: V4h+JKc+pBTKrzZcSUT7KLjqV9bBUClNtz5LtQ2l1FZbxBVK8DWQ1enuEprSG+j6czsFkWQZ7dg0TphxFOl83di13RdcJ537qxAePMNqOCFvybmWjfQWsmISr/nbg9tpYjLNtj9faLYHwGbleIMX0ZvJoILdDl1KHVTRbhCH6cshMfzn7Ej3QRxhm6eKOPCNyy3FILsjWQKVBHXz4KlfKsDaBMlTapZGtzK8GZC7q2bKM+b9CBxaUf0AxIEv5l0PkQbLqUyqUz+zKPbeqrKJaahs4XE1oJJl9vmNRoDt37XZzs73CGiIbvF0HPq1XTxU2a9FGzbCbIKyl24ryf/bzxo/mNms628u9lzHQ+5BnXblsY2PF2kA+wzzvNFVSqTBlRcO04Rzqi0qv4zaw3jEKHmy0m1mrjXZ5PpaoEU2jn8jvZMURMRpYwlwlyGjiR0PGxknuXCTugrgPCBVKOpMc2GXTBhOvhjCrxuX7128lXoYDPHI26H+1bURN+0b1dqOFeU1gsy9G6FlbUON+eZHUeowbsE+4XE4M/MeCHAt6rQWsZVtoSTYxTjXj0LhdAbnPKOcsQTKvtI2wWp1JFuOp2pVH+lijNK7p6psTewa6I4cX9lSto5oDmMtPc0Aw0RndZYi7mMQUWts0tc+mhzgqw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RELr2Tt56bCbuxl9lWGii7kArFImBJj+HMJQ8gkVFbyy7bLSJzKkaaETuQ3s?= =?us-ascii?Q?yot60cfueEI5z75Du4YGwc+25TNuwdcRsFv7C4jQofkmyKyvhLY20wU3t77+?= =?us-ascii?Q?K3I7CDfm7ErBQo4Y6VeeOWBKL12DVQgpG7AyyYcOL0ofENRFRzeUy46KrDFO?= =?us-ascii?Q?tO6PSw6ee+qraNceYKgAukUgkcALwvS97fkkQl3amwbukfD1hByUwmNKWG4x?= =?us-ascii?Q?bnal/Q4D0yqk/o+WsrwutpU+OiNuN3TNA42GgsugD/a3OW+sT7Y5wJDiGkj3?= =?us-ascii?Q?hUekhGiw8DjLfs7ML0rxmhFikZ+vhhGnqGfJ/aDlESujZSEJnOiXZ1BGBScA?= =?us-ascii?Q?CTtjFVUKeWGcTQHW5TxI9BruUtQHzE11wX3/b7IAd7Gtzs1ESWRavktMQ9l8?= =?us-ascii?Q?CMLY/ngp4MzhLJmluVjI7WfAmhkGNLpg0iW7KMizWfzLe+nFoYokVV0yDS0p?= =?us-ascii?Q?s9EWjuFIzCMxheQHQkl4kYsq3mR1zk1bEjcuv51LBJeyV9uMhE2Aied+njAR?= =?us-ascii?Q?Nezkt4xurV55qlHZKcgEHrKVunBLezTkYoqXcvv1BR79AxLxT6yP4wUgTlaN?= =?us-ascii?Q?6l+UlzvzKjWqNJknSqV5m/c+nw2x5fsmkiAgNBfv0YcHU4LP9XPcvEcFXsM1?= =?us-ascii?Q?KX+KrVhyaBneRLtbBTmvhW/j0TR2D81Fmkcyh1gulFL6i8OK3u/5uFqZz7Iy?= =?us-ascii?Q?uOhuUtV1Y46MgxWBpITjyGXZkqlr52xG40rHo4g6tT4X19Rmy+KYsmSI1NAq?= =?us-ascii?Q?6jEuP5FQDu6aqA+VkaAA3a6bQAgotiXw1pIZg6zIk/T5G6yT49cOeUoy1GCo?= =?us-ascii?Q?Li8OKRuxMxVMB1SwOcOPeMGQJDfW2S8j/HzlO+TB/R4P6S48tkbV9J5lWFT2?= =?us-ascii?Q?AYEBovR7pQ7M/Nv7AWr1idiYgGvLw+5a+2QKHpcDrgdSvIG/Jz6RCowEe5Zx?= =?us-ascii?Q?90x/tSPE/j5F+58fFst96NUNYpURGLiwSOKI28wNr1mG4uC8MCrq8W/Y3gPg?= =?us-ascii?Q?5tVajXM636Ueny8nqwCUkUCVj5z7FXzFSDHeSdVVhxTZs+pTEVAFS2I1z5Wp?= =?us-ascii?Q?bj4vdKWEls5wWvHZ5vApIDN7thGVY0w1LsF+xyY3NL4+Cl99FAcelz6bFNyo?= =?us-ascii?Q?kWHuMFVCXP02PN8GNZ04za9hGQdOrgOCfEMU4afrJiPNRhes01/iEfyT8/Vj?= =?us-ascii?Q?v0asubCN72XjVocqBnMHGg3kTavs9Xe6eO+qPN+6fWBLSg/sJ19xLwbGMIcf?= =?us-ascii?Q?HiKUG0upLQ5YybKMBnSOhoH8wdr+XzVRH+gz9iPVOGr2vqwa8hHTVEddU4HG?= =?us-ascii?Q?TWPrY8SAbsQr+0O4ljfCxmVUb/UHG/Y4Cnz3OR+iEvAKZcS8gkGlC4aPnWvt?= =?us-ascii?Q?h+Mqe5MCh3bIYSOainAn+F1IqLl2oL5oKXH3UCLBwZKBse6uufry8/DeecBc?= =?us-ascii?Q?Sa9DzoMkog79C/fMxjAnaOx2zAAcMSZ2JIypfqs5R0Ye8MzxpmmchXQ0DIFZ?= =?us-ascii?Q?36JcgN7QFykdlI4sP6R+joNB0X9blhN808tNWYZgwnBXjtkGZ0GD+rMQTceE?= =?us-ascii?Q?7W7nCA9cNkD/f3seRrTi7718Eq355hpngKXALh6Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 897465c1-394e-496a-201d-08dc1e98108e X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 17:56:04.2721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hCvcWrmO733tswYXqTIDJcJDRWFzT0HHD3YJvJEijxPhCtqgLTB8PRYtZnJDWFK5Yf4mg1CHTy3s2IOZ5pn2kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8930 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: F0mZHJtqZhwbI7nBzm3hv62wx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="lr9/WEYI"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/26/24 11:38, Tom Lendacky wrote: > +Min >=20 > Adding Min to see if TDX is also experiencing issues around this recent= =20 > change. >=20 > Thanks, > Tom >=20 > On 1/26/24 11:21, Tom Lendacky wrote: >> On 1/22/24 00:47, Sheng Wei via groups.io wrote: >>> PciIoMap () need to feedback the status of >>> mIoMmuProtocol->SetAttribute () return value. >>> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4652 >> >> I'm still investigating, but this commit breaks booting all types of SEV= =20 >> guests. Without this patch, there is a boot device mapping and the Grub= =20 >> menu is displayed. But with this patch, I receive: >> >> map: No mapping found. >> Press ESC in 1 seconds to skip startup.nsh or any other key to continue. >> >> and then drop to the shell prompt. The IOMMU protocol is installed under OVMF when either SEV or TDX is=20 active. The SetAttribute() function of this implementation has always=20 returned EFI_UNSUPPORTED, which is now being passed pack to the caller of= =20 PciIoMap() and thus causing a failure. Should the SetAttribute() function in OvmfPkg/IoMmuDxe/CcIoMmu.c return=20 success by default? Thanks, Tom >> >> Thanks, >> Tom >> >>> >>> Cc: Ray Ni >>> Cc: Huang Jenny >>> Cc: Chiang Chris >>> Signed-off-by: Sheng Wei >>> --- >>> =C2=A0 MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 ++++++------ >>> =C2=A0 1 file changed, 6 insertions(+), 6 deletions(-) >>> >>> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c=20 >>> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >>> index 14bed54729..e85544d08d 100644 >>> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >>> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c >>> @@ -1024,12 +1024,12 @@ PciIoMap ( >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retu= rn EFI_INVALID_PARAMETER; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMmuProtocol->SetAttribute ( >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMm= uProtocol, >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PciIo= Device->Handle, >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *Mapp= ing, >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 IoMmu= Attribute >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ); >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D mIoMmuProtocol->SetAttribute= ( >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mIoMmuProtocol, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PciIoDevice->Handle, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 *Mapping, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 IoMmuAttribute >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> =C2=A0=C2=A0=C2=A0 } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114623): https://edk2.groups.io/g/devel/message/114623 Mute This Topic: https://groups.io/mt/103881889/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-