Re: [edk2-devel] [PATCH v1 1/1] DynamicTables: Fix DT PCI interrupt flags parsing

["PierreGondois" <pierre.gondois@arm.com>]

Hi Sami

On 7/18/22 14:27, Sami Mujawar wrote:
> Hi Pierre,
> 
> Please find my response inline marked [SAMI]
> 
> Regards,
> 
> Sami Mujawar
> 
> On Wed, Apr 27, 2022 at 07:49 AM, PierreGondois wrote:
> 
>     diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPci=
>     eGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtP=
>     cieGenerator.c
>     index a34018151f2d..d5b1c153e98f 100644
>     --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera=
>     tor.c
>     +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera=
>     tor.c
>     @@ -449,7 +449,7 @@ GeneratePrt (
>     if ((Index > 0) &&
>     (IrqMapInfo->IntcInterrupt.Interrupt >=3D 32) &&
>     (IrqMapInfo->IntcInterrupt.Interrupt < 1020) &&
>     - ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D BIT0))
>     + ((IrqMapInfo->IntcInterrupt.Flags & 0x3) !=3D 0))
> 
> [SAMI] The BSA 1.0 says "Each legacy interrupt SPI must be programmed as level-sensitive".
> Considering this, I think the above check should be ((IrqMapInfo->IntcInterrupt.Flags & 0xB) != 0).
> If you agree, please let me know I will make that change locally before pushing.
> [/SAMI]

[Pierre]
Yes indeed,
Thanks for the review and changing this without requiring a v2,

Regards,
Pierre

[/Pierre]

> 
>     {
>     Status =3D EFI_INVALID_PARAMETER;
>     ASSERT_EFI_ERROR (Status);
>     diff --git a/DynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h b/D=
>     ynamicTablesPkg/Library/FdtHwInfoParserLib/FdtUtility.h
>