Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Sami Mujawar <Sami.mujawar@arm.com>, Ray Ni <ray.ni@intel.com>,
	Pierre Gondois <pierre.gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
Date: Mon, 8 Jan 2024 09:48:44 +0100	[thread overview]
Message-ID: <6871157e-9adb-4a00-b068-58c572078712@arm.com> (raw)
In-Reply-To: <20240102172630.111466-1-pierre.gondois@...>

Hello MdePkg Maintainers,

I forgot to include Liming's Reviewed-by tag:
https://edk2.groups.io/g/devel/message/112348

Regards,
Pierre

On 1/2/24 18:26, PierreGondois wrote:
> Add definitions for:
> - _PSD version: added in ACPI 3.0
> - C-state Coordination Types: added in ACPI 3.0
> - _CPC version: added in ACPI 5.0
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@...>
> Reviewed-by: Sami Mujawar <sami.mujawar@...>
> ---
> 
> Notes:
>      v2:
>      - Correct EFI_ACPI_5_1_AML_CPC_REVISION value [Sami]
> 
>   MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++
>   MdePkg/Include/IndustryStandard/Acpi40.h |  5 +++++
>   MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++
>   MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++
>   10 files changed, 99 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h
> index 29f0d5535593..cb50b1d8f71a 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi30.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi30.h
> @@ -17,6 +17,20 @@
>   
>   #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR  0x8B
>   
> +///
> +/// C-state Coordination Types
> +/// See s8.4.2.2 _CSD (C-State Dependency)
> +///
> +#define ACPI_AML_COORD_TYPE_SW_ALL  0xFC
> +#define ACPI_AML_COORD_TYPE_SW_ANY  0xFD
> +#define ACPI_AML_COORD_TYPE_HW_ALL  0xFE
> +
> +///
> +/// _PSD Revision for ACPI 3.0
> +// See s8.4.4.5 _PSD (P-State Dependency)
> +///
> +#define EFI_ACPI_3_0_AML_PSD_REVISION  0
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h
> index a2da09346f1c..0e30f4f8417d 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi40.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi40.h
> @@ -10,6 +10,11 @@
>   
>   #include <IndustryStandard/Acpi30.h>
>   
> +///
> +/// _PSD Revision for ACPI 4.0
> +///
> +#define EFI_ACPI_4_0_AML_PSD_REVISION  0
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 76706aa640f8..a00b8259b8f7 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h
> @@ -23,6 +23,16 @@
>   #define ACPI_GPIO_CONNECTION_DESCRIPTOR                0x8C
>   #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR  0x8E
>   
> +///
> +/// _PSD Revision for ACPI 5.0
> +///
> +#define EFI_ACPI_5_0_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 5.0
> +///
> +#define EFI_ACPI_5_0_AML_CPC_REVISION  1
> +
>   #pragma pack(1)
>   
>   ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h
> index 01ef544c3a29..4241b8f198f1 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi51.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h
> @@ -13,6 +13,16 @@
>   
>   #include <IndustryStandard/Acpi50.h>
>   
> +///
> +/// _PSD Revision for ACPI 5.1
> +///
> +#define EFI_ACPI_5_1_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 5.1
> +///
> +#define EFI_ACPI_5_1_AML_CPC_REVISION  2
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
> index 5ac3be6ad71c..3757d3f82792 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -12,6 +12,16 @@
>   
>   #include <IndustryStandard/Acpi51.h>
>   
> +///
> +/// _PSD Revision for ACPI 6.0
> +///
> +#define EFI_ACPI_6_0_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.0
> +///
> +#define EFI_ACPI_6_0_AML_CPC_REVISION  2
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
> index 7af67d832bb2..c3facc6e376e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -12,6 +12,16 @@
>   
>   #include <IndustryStandard/Acpi60.h>
>   
> +///
> +/// _PSD Revision for ACPI 6.1
> +///
> +#define EFI_ACPI_6_1_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.1
> +///
> +#define EFI_ACPI_6_1_AML_CPC_REVISION  2
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index e27775a85ade..4dd3e21c2325 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -29,6 +29,16 @@
>   #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR       0x91
>   #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR  0x92
>   
> +///
> +/// _PSD Revision for ACPI 6.2
> +///
> +#define EFI_ACPI_6_2_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.2
> +///
> +#define EFI_ACPI_6_2_AML_CPC_REVISION  3
> +
>   #pragma pack(1)
>   
>   ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
> index 10bdf5fe5a57..7582dccf649b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -12,6 +12,16 @@
>   
>   #include <IndustryStandard/Acpi62.h>
>   
> +///
> +/// _PSD Revision for ACPI 6.3
> +///
> +#define EFI_ACPI_6_3_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.3
> +///
> +#define EFI_ACPI_6_3_AML_CPC_REVISION  3
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 575ca0430c13..faf069a0454e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -12,6 +12,16 @@
>   
>   #include <IndustryStandard/Acpi63.h>
>   
> +///
> +/// _PSD Revision for ACPI 6.4
> +///
> +#define EFI_ACPI_6_4_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.4
> +///
> +#define EFI_ACPI_6_4_AML_CPC_REVISION  3
> +
>   //
>   // Ensure proper structure formats
>   //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65.h
> index d79d0b2b5f9c..b9616a3e29c2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi65.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h
> @@ -18,6 +18,16 @@
>   //
>   #pragma pack(1)
>   
> +///
> +/// _PSD Revision for ACPI 6.5
> +///
> +#define EFI_ACPI_6_5_AML_PSD_REVISION  0
> +
> +///
> +/// _CPC Revision for ACPI 6.5
> +///
> +#define EFI_ACPI_6_5_AML_CPC_REVISION  3
> +
>   ///
>   /// ACPI 6.5 Generic Address Space definition
>   ///


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113372): https://edk2.groups.io/g/devel/message/113372
Mute This Topic: https://groups.io/mt/103485754/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

next      parent reply	other threads:[~2024-01-08  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240102172630.111466-1-pierre.gondois@...>
2024-01-08  8:48 ` PierreGondois [this message]
2024-01-12 14:36   ` [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions Sami Mujawar
2024-01-16 14:17     ` 回复: " gaoliming via groups.io
2024-01-20  3:27       ` Michael D Kinney
2024-01-02 17:26 PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6871157e-9adb-4a00-b068-58c572078712@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox