From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by mx.groups.io with SMTP id smtpd.web09.6678.1582079873287784517 for ; Tue, 18 Feb 2020 18:37:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DbEiMryl; spf=pass (domain: gmail.com, ip: 209.85.214.195, mailfrom: newexplorerj@gmail.com) Received: by mail-pl1-f195.google.com with SMTP id e8so8903069plt.9 for ; Tue, 18 Feb 2020 18:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=LjHFdX1y83Ij7IjGavEj8oIICY0fZ+o8JSRqFVO2F0Y=; b=DbEiMrylKRMoJTpEDzNlCTwGCf3nqqHxx8LuwKaYk2G82SUofRfWzAYxnXEBpg6SUM 0YdSXLejx62cmAzzE2R6s6+IhgS4y65+o3nOlkDIbvfwefSI3JXpttBwTc1+yikEhOEt McDGtl+e5TumMkvG/ncopxZedqOo+GvKm2TVusx4MgLTh2sZzSzPURNt5nCoCKmiqOKy xcFYwGukOejevGS+wd31CZBS6M86ZKLkHCCgoXHjVf0TlH6bFx5/mFKq6WjROjW1CxPK FWGuTW63B5k+qHdjW7n0aFtoFQmGjkPk6NQ83H4hXE5WaQvOmOw+8Iuma8PsgfPLRo1i TvtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LjHFdX1y83Ij7IjGavEj8oIICY0fZ+o8JSRqFVO2F0Y=; b=qwI4fgr8sVyRQLccOYdzigP9u3HKEcg/vEM+uYWF6JduZJH2IrmR7V067DRqouDtT+ Hxt9NGiy+gYnpvM0kWMY07ADCe9rhKJC/AeVgHZA3PUHRyRrLn8XjN32vhXm80Ej31D2 sH9m/IXb0pLQ8OgKBjLeQ86rUbm8+AeoZeMPCdDu9rU25/xG+HM8WTHNhtABvEWRxGqj oRYXu9RzQtHFYji9VbQzp1q36eeGbFFyPehwrGE7+Y/s1vnud8UXV4a3gIXJE7/apS2Q X+ggEFaOB3sU2fNgC+4g2sLxi0gMVh5rUDkBQmly94USeHthwJjhUWzlucxTLr1Sex7N a5Tw== X-Gm-Message-State: APjAAAV9geOfnAJsnEMt0SQSuOrSlZAd1BRRqTay1ant2wszHtoujQTy itbxMSqgEWV6bMpHgzozZ79I8t0Ts2jpsw== X-Google-Smtp-Source: APXvYqzL6Nf9ARHxNMVAmf6IfiSwOu2Lm5X4JMeWqenPybQq2oVIMG8gFdKOX70DtRYAGfgPSoViDA== X-Received: by 2002:a17:902:7c05:: with SMTP id x5mr24355964pll.236.1582079872237; Tue, 18 Feb 2020 18:37:52 -0800 (PST) Return-Path: Received: from localhost.localdomain ([117.136.46.20]) by smtp.gmail.com with ESMTPSA id z5sm366987pfq.3.2020.02.18.18.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 18:37:51 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH] UnitTestFrameworkPkg: Suspicious check for pointer Suite Date: Wed, 19 Feb 2020 10:34:49 +0800 Message-Id: <688166e8ec46f20a29ffedb8703ca7d94059b483.1582079674.git.newexplorerj@gmail.com> X-Mailer: git-send-email 2.17.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2530 The Suite pointer is used before check if it is valid, correct it to check the validation before use. Signed-off-by: GuoMinJ --- UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c b/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c index fb247c59e7..b053e04959 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c @@ -33,13 +33,13 @@ RunTestSuite ( UNIT_TEST *Test; UNIT_TEST_FRAMEWORK *ParentFramework; - TestEntry = NULL; - ParentFramework = (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; - if (Suite == NULL) { return EFI_INVALID_PARAMETER; } + TestEntry = NULL; + ParentFramework = (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; + DEBUG ((DEBUG_VERBOSE, "---------------------------------------------------------\n")); DEBUG ((DEBUG_VERBOSE, "RUNNING TEST SUITE: %a\n", Suite->Title)); DEBUG ((DEBUG_VERBOSE, "---------------------------------------------------------\n")); -- 2.17.1