Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

["Desai, Imran" <imran.desai@intel.com>]

Hello Jiewen,

I tested SM3 PCR extensions on the OvmfPkg using swTPM (and TPM2 simulator).
The validation was done comparing PCR extensions from the TCG2 EventLog and SM3 PCR Bank data from the simulator at every extension.
Additionally each SM3 extension and resulting values were compared and contrasted against OpenSSL_1_1_1b on a linux dev machine to ensure the accuracy of the digest values being produced, extended and realized as a final value in the PCR.

Thanks and Regards,

Imran Desai
________________________________________
From: Yao, Jiewen
Sent: Monday, May 20, 2019 9:30 AM
To: devel@edk2.groups.io; Desai, Imran
Subject: Re: [edk2-devel] [Enable measured boot with SM3 digest algorithm 0/4]

hi
thanks for this contribution
Besides the comment from Laszlo, would you please also share your unit test result?
What test you have done for this patch?

thank you!
Yao, Jiewen


> 在 2019年5月17日，下午2:43，Imran Desai <imran.desai@intel.com> 写道：
>
> https://github.com/idesai/edk2/tree/enable_sm3_measured_boot
>
> Support for SM3 digest algorithm is needed for TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. Support for these algorithms is needed to enable platforms for the PRC market.
> This integration has dependency on the openssl_1_1_1b integration into edk2.
>
> Imran Desai (4):
>  sm3_enabling: Augment crypt interface with calls into openssl to
>    calculate sm3 digest prior to exercising TPM2 calls for PCR extend
>  sm3-enabling: Add SM3 TCG algorithm registry value to the
>    PcdTpm2HashMask
>  sm3-enabling: Add SM3 guid reference in the TPM2 hash mask  structure
>    in HashLibBaseCryptoRouterCommon.c
>  sm3-enabling: Add SM3 hashinstance library information to all OvmfPkg
>    and SecurityPkg
>
> SecurityPkg/SecurityPkg.dec                   |   5 +-
> OvmfPkg/OvmfPkgIa32.dsc                       |   2 +
> OvmfPkg/OvmfPkgIa32X64.dsc                    |   2 +
> OvmfPkg/OvmfPkgX64.dsc                        |   2 +
> SecurityPkg/SecurityPkg.dsc                   |   3 +
> .../HashInstanceLibSm3/HashInstanceLibSm3.inf |  46 ++++++
> MdePkg/Include/Protocol/Hash.h                |   5 +
> SecurityPkg/Include/Library/HashLib.h         |   1 +
> .../HashInstanceLibSm3/HashInstanceLibSm3.c   | 155 ++++++++++++++++++
> .../HashLibBaseCryptoRouterCommon.c           |   1 +
> .../HashInstanceLibSm3/HashInstanceLibSm3.uni |  21 +++
> 11 files changed, 241 insertions(+), 2 deletions(-)
> create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
> create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
> create mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
>
> --
> 2.17.0
>
>
> 
>