From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: imran.desai@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Wed, 03 Jul 2019 15:48:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 15:48:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,448,1557212400"; d="scan'208";a="191194039" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2019 15:48:34 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 15:48:33 -0700 Received: from fmsmsx104.amr.corp.intel.com ([169.254.3.66]) by FMSMSX109.amr.corp.intel.com ([169.254.15.43]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 15:48:33 -0700 From: "Imran Desai" To: Leif Lindholm , "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Wang, Jian J" , "Justen, Jordan L" , Ard Biesheuvel , =?iso-8859-1?Q?Marc-Andr=E9_Lureau?= , "Stefan Berger" , "Cetola, Stephano" , "Kinney, Michael D" , Andrew Fish Subject: Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe Thread-Topic: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe Thread-Index: AQHVMd8zwj/wkWiCZUCekLGCnO/ABaa52zIA//+aJiU= Date: Wed, 3 Jul 2019 22:48:33 +0000 Message-ID: <688D07BB9E3A9E4A852BA1336D1910FF83FE9869@fmsmsx104.amr.corp.intel.com> References: <20190528204049.86463-1-imran.desai@intel.com> <20190528204049.86463-6-imran.desai@intel.com> <9c92afaf-b368-628e-f686-64257831343b@redhat.com>,<20190703211802.3wieoi5imbg76v6i@bivouac.eciton.net> In-Reply-To: <20190703211802.3wieoi5imbg76v6i@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.19.9.41] MIME-Version: 1.0 Return-Path: imran.desai@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hello Lersek/ Leif,=0A= =0A= Like Lersek hinted, this in fact was an inadvertent issue with the git conf= iguration. =0A= I suspect the suppresscc in my configuration may have been the source of a= ll confusion. My apologies.=0A= =0A= I will send in a new version v5 of the full series of the patches.=0A= =0A= I appreciate all the help and comments. Thanks.=0A= =0A= PS:=0A= =0A= Being used to GitHub pull request methods where in all reviews and conversa= tion happen on the same page i was a little thrown by this process to be ho= nest. In any case as a first time contributor this was a hard way to find o= ut. Perhaps it could be helpful to update the https://github.com/tianocore/= tianocore.github.io/wiki/EDK-II-Development-Process. Particularly the line = "git send-email *.patch" could use further commentary regarding CC list.=0A= =0A= Thanks and Regards,=0A= =0A= Imran Desai=0A= ________________________________________=0A= From: Leif Lindholm [leif.lindholm@linaro.org]=0A= Sent: Wednesday, July 03, 2019 2:18 PM=0A= To: devel@edk2.groups.io; lersek@redhat.com=0A= Cc: Desai, Imran; Wang, Jian J; Justen, Jordan L; Ard Biesheuvel; Marc-Andr= =E9 Lureau; Stefan Berger; Cetola, Stephano; Kinney, Michael D; Andrew Fish= =0A= Subject: Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg= 2Pei and Tcg2Dxe=0A= =0A= On Wed, Jul 03, 2019 at 10:37:40PM +0200, Laszlo Ersek wrote:=0A= > On 05/28/19 22:40, Imran Desai wrote:=0A= > >=0A= > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781=0A= > >=0A= > > EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 = PCR=0A= > > banks. This digest algorithm is part of the China Crypto algorithm suit= e.=0A= > > This integration has dependency on the openssl_1_1_1b integration into= =0A= > > edk2.=0A= > > This patch links SM3 support into Tcg2Pei and Tcg2Dxe.=0A= > >=0A= > >=0A= > > Signed-off-by: Imran Desai =0A= > > Cc: Jordan Justen =0A= > > Cc: Laszlo Ersek =0A= > > Cc: Ard Biesheuvel =0A= > > Cc: Marc-Andr=E9 Lureau =0A= > > Cc: Stefan Berger =0A= > > ---=0A= > > OvmfPkg/OvmfPkgIa32.dsc | 2 ++=0A= > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++=0A= > > OvmfPkg/OvmfPkgX64.dsc | 2 ++=0A= > > 3 files changed, 6 insertions(+)=0A= >=0A= > Wow, what just happened here?=0A= >=0A= > I'm noticing now that this patch has been pushed to the master branch as= =0A= > commit a7c7d21ffa9a.=0A= >=0A= > However, *NONE* of the OvmfPkg co-maintainers or reviewers have reviewed= =0A= > this patch!=0A= =0A= Nor has Jian, or Jiewen, on-list - there is only the tags in the commit.=0A= Other patches in the set have R-b: from Jiewen in the commit, but never=0A= on the list.=0A= =0A= Not that it would matter. Patches do not go in without package=0A= maintainer review. Unless there is a *really* good reason, at which=0A= point I expect at least one steward to Ack/R-b:.=0A= =0A= > The commit message includes "Cc:" lines, but that's a lie. Probably not= =0A= > an intentional lie, but a lie nonetheless. These patches have *never*=0A= > been delivered to my inbox, and if I look at the address list on the=0A= > message instance that was reflected by the mailing list, that address=0A= > list confirms the same. I'm pretty sure Imran's git configuration has a= =0A= > bug related to CC's. (I've extended the address list now, manually.)=0A= >=0A= > Jian: please revert this patch immediately, stating, as reason, that the= =0A= > patch review process was not honored. I'm sorry but I cannot let this=0A= > slide -- if you look at commit a7c7d21ffa9a now, it suggests that the=0A= > OvmfPkg maintainers / reviewers were CC'd (they weren't), but they=0A= > ignored the patch (they didn't -- they couldn't see it), and that=0A= > another maintainer pushed the patch just the same (which is factual, but= =0A= > *wrong*).=0A= =0A= Based on the included Reviewed-by tags from Jiewen that never appeared=0A= on the list, this entire series need to be reverted.=0A= =0A= 1/5 then needs Reviewed-by: from an MdePkg maintainer, after which=0A= 2-4/5 can be pushed again if the commit messages are updated to=0A= contain only the Reviewed-by: and Cc: that have actually happened=0A= on-list.=0A= =0A= /=0A= Leif=