From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by mx.groups.io with SMTP id smtpd.web09.388.1606858010893385072 for ; Tue, 01 Dec 2020 13:26:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uk4qWS6g; spf=pass (domain: nuviainc.com, ip: 209.85.216.66, mailfrom: rebecca@nuviainc.com) Received: by mail-pj1-f66.google.com with SMTP id ms7so2093915pjb.4 for ; Tue, 01 Dec 2020 13:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=1Au2xcwIiukpF20o2Ss+x+rR8BoTgARizj5RSgSSJaA=; b=uk4qWS6g0OcyKL+b1V2Ti5ggIqVoHuybXCvXiiFjpUQbAajH4P3C54cm1sfYSSelyD ph7CSobN6IdUY5VfX9FjBLcINdJ63io1H2eMfD3eO8lAlGRdiFGf26oCk6XLk9ceG4t+ VIVgzTktYoO0bJqFy3HdcSnsVRacA/mt0rZrAguHrXf2JhwG4E9EH3edV0MaDbqcW7aC mIzKu9ZYk7eRwkRnxAfU67GQ+V7XjyNGVpN58UU2sqXQWxvFJ2vupyAwKo2OJCGhVoeK 7frTJpvr167+Dc0s3fiMScRftQuk+P/v/SvJXv/3mzG/S0gol4PxPvOkbKC8HYJPHFed 0Szw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1Au2xcwIiukpF20o2Ss+x+rR8BoTgARizj5RSgSSJaA=; b=q+mwZubrrnxPkdgxZf3mj/tn1JrgRmHEchMrTfWOWZVwq3dcUIGAaHj+ONhy6khvP0 rSIxkvcrqMXdb6o4Elyqs5GRqTa7zlsNBslcalJexKhu9ET7JEODHs2NgiLBUj+kuDrC tPYcvxOMEAWf5iVnF8PFwfsHZM2c/UJ4MnLWV9vON+/0UsxvKYosOp3Ew9/4I1TxcNQw /CZ/XodLXeJNzxSUx36JjRtr2T2AOR1q5u46kY95Y3QH+QqyhcwBFs6f7Pettq3MrKhY ZRx5MjGY+RkqegFBa6xgsVF8TrddxVUFTUtNmXmamg6w4yZLHyEATh0cZu4HzJEKOK7k JZ4Q== X-Gm-Message-State: AOAM530lR43hs55MEbS5oBYaTGkeHM/2UmM7ssV+GFwNJXu+EYROFXpk fMvsw3GrVcJXIVwwNTF7dlwtBA== X-Google-Smtp-Source: ABdhPJx0Qy6ajLNAskk9WkL1UczPQo0ypTDNSjF132MJXUVM9XS9A27OrEfP3CXOH5Pi9EQ4MwzgTQ== X-Received: by 2002:a17:90a:ea92:: with SMTP id h18mr4753691pjz.200.1606858010316; Tue, 01 Dec 2020 13:26:50 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id 23sm636887pfx.210.2020.12.01.13.26.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 13:26:49 -0800 (PST) Subject: Re: [PATCH v4 00/11] ArmPkg,MdePkg: Add Universal/Smbios and Drivers/FirmwareVersionInfoPeim To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20201201003358.8780-1-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: <68a8bdbf-5160-1583-0a8b-07260ccce193@nuviainc.com> Date: Tue, 1 Dec 2020 14:26:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201201003358.8780-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sorry, there are a few problems with this series, including stuff that got broken as I was shuffling things around yesterday. I'll send out another series. -- Rebecca Cran On 11/30/20 5:33 PM, Rebecca Cran wrote: > Much of the data for the SMBIOS tables is generic, and need not be > duplicated for each platform. This patch series introduces > ArmPkg/Universal/Smbios, which is largely copied from > edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS > tables 0,1,2,3,4,7,13,32 and uses a combination of PCDs and calls into a > new OemMiscLib to get information which varies between platforms. > > I plan to submit a patch against SbsaQemu to update it to use this new > functionality. > > Changes from v3 to v4: > > - Split changes up into many more patches. > - Renamed VersionInfoHob to FirmwareVersionInfoHob. > - Refactored ProcessorSubClass.c to reduce function complexity. > - Removed BOM from .uni files. > - Added comment to OemMiscLib.h to clarify that the functions listed are > to be implemented by the individual platforms. > - Added Doxygen comments in many places. > - Moved definition of MAX_ARM_CACHE_LEVEL to ArmPkg/Include/Library/ArmLib.h > - Addressed other review feedback. > > Leif: I decided not to rename Smbios to SmBios because that capitalization doesn't > appear to be common. "SMBIOS" or "Smbios" seem more common, so I plan to submit a > patch to rename MdePkg/Include/IndustryStandard/SmBios to Smbios.h. > > Rebecca Cran (11): > ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h > MdePkg: Update IndustryStandard/SmBios.h with processor status data > ArmPkg: Add register encoding definition for MMFR2 > ArmPkg: Add helper to read the Memory Model Features Register 2 > ArmPkg: Add helper function to read the Memory Model Feature Register 4 > ArmPkg: Add helper to read CCIDX status > ArmPkg: Fix the return type of the ReadCCSIDR function > ArmPkg: Update ArmLibPrivate.h with cache register definitions > ArmPkg: Add FirmwareVersionInfoPeim > ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM > ArmPkg: Add definition of the maximum cache level in ARMv8-A > > ArmPkg/ArmPkg.dec | 3 + > ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.inf | 47 ++ > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 55 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 90 +++ > ArmPkg/Include/Chipset/AArch64.h | 4 + > ArmPkg/Include/Guid/FirmwareVersionInfoHobGuid.h | 29 + > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 13 + > ArmPkg/Include/Library/ArmLib.h | 10 + > ArmPkg/Include/Library/OemMiscLib.h | 91 +++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 6 + > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 6 + > ArmPkg/Library/ArmLib/ArmLibPrivate.h | 93 ++- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h | 34 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 217 ++++++ > MdePkg/Include/IndustryStandard/SmBios.h | 13 + > ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.c | 91 +++ > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 12 + > ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 12 + > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 798 ++++++++++++++++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 68 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 167 ++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 100 +++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 238 ++++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 43 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 181 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 51 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 194 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 58 ++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 192 +++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 39 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 155 ++++ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 41 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 67 ++ > ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + > ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 4 + > ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 6 +- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 23 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibString.uni | 21 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 18 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 21 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 21 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 18 + > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 43 ++ > 44 files changed, 3395 insertions(+), 3 deletions(-) > create mode 100644 ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.inf > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > create mode 100644 ArmPkg/Include/Guid/FirmwareVersionInfoHobGuid.h > create mode 100644 ArmPkg/Include/Library/OemMiscLib.h > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h > create mode 100644 ArmPkg/Drivers/FirmwareVersionInfoPeim/FirmwareVersionInfoPeim.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c > create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscLibString.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni > create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni >