From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [PATCH 2/2] ShellPkg: Fix typo of 'Controller' in acpiview MadtParser.c
Date: Wed, 3 May 2023 21:44:36 -0600 [thread overview]
Message-ID: <68ebad31-e8d4-1e0b-c8fa-52d89731c101@bsdio.com> (raw)
In-Reply-To: <20230503215023.1176725-3-rebecca@bsdio.com>
Sorry, I made Uncrustify fixes in the wrong commit. I'll send out a v2.
On 5/3/23 15:50, Rebecca Cran wrote:
> Fix typos of 'Controller' in acpiview MadtParser.c.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 50 ++++++++++----------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
> index 9d33ad2606e8..0197b4bd9a66 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c
> @@ -214,9 +214,9 @@ STATIC CONST ACPI_PARSER LocalApicFlags[] = {
> };
>
> STATIC CONST ACPI_PARSER MpsIntiFlags[] = {
> - { L"Polarity", 2, 0, L"%d", NULL, NULL, NULL, NULL },
> - { L"Trigger Mode", 2, 2, L"%d", NULL, NULL, NULL, NULL },
> - { L"Reserved", 12, 4, L"%d", NULL, NULL, NULL, NULL }
> + { L"Polarity", 2, 0, L"%d", NULL, NULL, NULL, NULL },
> + { L"Trigger Mode", 2, 2, L"%d", NULL, NULL, NULL, NULL },
> + { L"Reserved", 12, 4, L"%d", NULL, NULL, NULL, NULL }
> };
>
> /**
> @@ -295,12 +295,12 @@ STATIC CONST ACPI_PARSER ProcessorLocalApic[] = {
> An ACPI_PARSER array describing the Local APIC NMI Structure.
> **/
> STATIC CONST ACPI_PARSER LocalApicNmi[] = {
> - { L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL },
> - { L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL },
> + { L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL },
> + { L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL },
>
> - { L"ACPI Processor UID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL },
> - { L"Flags", 2, 3, NULL, DumpMpsIntiBitFlags, NULL, NULL, NULL },
> - { L"Local APIC LINT#", 1, 5, L"%d", NULL, NULL, NULL, NULL }
> + { L"ACPI Processor UID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL },
> + { L"Flags", 2, 3, NULL, DumpMpsIntiBitFlags, NULL, NULL, NULL },
> + { L"Local APIC LINT#", 1, 5, L"%d", NULL, NULL, NULL, NULL }
> };
>
> /**
> @@ -379,7 +379,7 @@ ParseAcpiMadt (
> )
> {
> UINT32 Offset;
> - UINT8 *InterruptContollerPtr;
> + UINT8 *InterruptControllerPtr;
> UINT32 GICDCount;
>
> GICDCount = 0;
> @@ -396,7 +396,7 @@ ParseAcpiMadt (
> AcpiTableLength,
> PARSER_PARAMS (MadtParser)
> );
> - InterruptContollerPtr = Ptr + Offset;
> + InterruptControllerPtr = Ptr + Offset;
>
> while (Offset < AcpiTableLength) {
> // Parse Interrupt Controller Structure to obtain Length.
> @@ -404,7 +404,7 @@ ParseAcpiMadt (
> FALSE,
> 0,
> NULL,
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> AcpiTableLength - Offset,
> PARSER_PARAMS (MadtInterruptControllerHeaderParser)
> );
> @@ -445,7 +445,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "GICC",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (GicCParser)
> );
> @@ -467,7 +467,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "GICD",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (GicDParser)
> );
> @@ -480,7 +480,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "GIC MSI Frame",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (GicMSIFrameParser)
> );
> @@ -493,7 +493,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "GICR",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (GicRParser)
> );
> @@ -506,7 +506,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "GIC ITS",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (GicITSParser)
> );
> @@ -519,7 +519,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "IO APIC",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (IoApic)
> );
> @@ -532,7 +532,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "INTERRUPT SOURCE OVERRIDE",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (InterruptSourceOverride)
> );
> @@ -544,7 +544,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "PROCESSOR LOCAL APIC",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (ProcessorLocalApic)
> );
> @@ -556,11 +556,11 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "LOCAL APIC NMI",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (LocalApicNmi)
> );
> - break;
> + break;
> }
> case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC:
> {
> @@ -568,7 +568,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "PROCESSOR LOCAL X2APIC",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (ProcessorLocalX2Apic)
> );
> @@ -581,7 +581,7 @@ ParseAcpiMadt (
> TRUE,
> 2,
> "LOCAL x2APIC NMI",
> - InterruptContollerPtr,
> + InterruptControllerPtr,
> *MadtInterruptControllerLength,
> PARSER_PARAMS (LocalX2ApicNmi)
> );
> @@ -600,7 +600,7 @@ ParseAcpiMadt (
> }
> } // switch
>
> - InterruptContollerPtr += *MadtInterruptControllerLength;
> - Offset += *MadtInterruptControllerLength;
> + InterruptControllerPtr += *MadtInterruptControllerLength;
> + Offset += *MadtInterruptControllerLength;
> } // while
> }
prev parent reply other threads:[~2023-05-04 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 21:50 [PATCH 0/2] ShellPkg: UefiShellAcpiViewCommandLib: Add support for parsing Local APIC NMI structure Rebecca Cran
2023-05-03 21:50 ` [PATCH 1/2] ShellPkg: acpiview: add support for parsing the " Rebecca Cran
2023-05-03 21:50 ` [PATCH 2/2] ShellPkg: Fix typo of 'Controller' in acpiview MadtParser.c Rebecca Cran
2023-05-04 3:44 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ebad31-e8d4-1e0b-c8fa-52d89731c101@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox