From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Jared McNeill <jmcneill@invisible.ca>,
Andrei Warkentin <awarkentin@vmware.com>,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Pete Batard <pete@akeo.ie>,
Jeremy Linton <lintonrjeremy@gmail.com>
Subject: Re: [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected
Date: Thu, 4 Jun 2020 16:57:00 +0200 [thread overview]
Message-ID: <68f182be-29ab-7ea7-46ff-1a4eac8f62f4@arm.com> (raw)
In-Reply-To: <20200604145339.GX28566@vanye>
On 6/4/20 4:53 PM, Leif Lindholm wrote:
> On Thu, Jun 04, 2020 at 11:50:05 +0200, Ard Biesheuvel wrote:
>> In preparation of removing the EfiBootManagerConnectAll() from the
>> ordinary boot path, ensure that the MAC programming of the GENET
>> occurs even if the SNP driver for it is never invoked by the BDS.
>
> Does this not cause a behaviour change if the driver *has* been
> invoked, and the MAC address has been modified with
> SNP.StationAddress()?
>
No, the MAC is programmed when the device is registered. If SNP takes
control, it does so afterwards, and will be able to supersede the MAC as
before.
next prev parent reply other threads:[~2020-06-04 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 9:50 [PATCH edk2-platforms 0/3] Platform/RaspberryPi: omit ConnectAll() on regular boot Ard Biesheuvel
2020-06-04 9:50 ` [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected Ard Biesheuvel
2020-06-04 12:27 ` Pete Batard
2020-06-04 14:53 ` Leif Lindholm
2020-06-04 14:57 ` Ard Biesheuvel [this message]
2020-06-04 15:00 ` Leif Lindholm
2020-06-04 9:50 ` [PATCH edk2-platforms 2/3] Platform/RaspberryPi: add UEFI Shell to boot manager menu Ard Biesheuvel
2020-06-04 12:27 ` Pete Batard
2020-06-04 9:50 ` [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot Ard Biesheuvel
2020-06-04 12:27 ` Pete Batard
2020-06-05 8:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f182be-29ab-7ea7-46ff-1a4eac8f62f4@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox