From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.15889.1591282625381010831
 for <devel@edk2.groups.io>;
 Thu, 04 Jun 2020 07:57:05 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3E431FB;
	Thu,  4 Jun 2020 07:57:03 -0700 (PDT)
Received: from [192.168.1.69] (unknown [10.37.8.209])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84CFE3F305;
	Thu,  4 Jun 2020 07:57:02 -0700 (PDT)
Subject: Re: [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Jared McNeill <jmcneill@invisible.ca>,
 Andrei Warkentin <awarkentin@vmware.com>,
 Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
 Pete Batard <pete@akeo.ie>, Jeremy Linton <lintonrjeremy@gmail.com>
References: <20200604095007.45693-1-ard.biesheuvel@arm.com>
 <20200604095007.45693-2-ard.biesheuvel@arm.com>
 <20200604145339.GX28566@vanye>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <68f182be-29ab-7ea7-46ff-1a4eac8f62f4@arm.com>
Date: Thu, 4 Jun 2020 16:57:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200604145339.GX28566@vanye>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/4/20 4:53 PM, Leif Lindholm wrote:
> On Thu, Jun 04, 2020 at 11:50:05 +0200, Ard Biesheuvel wrote:
>> In preparation of removing the EfiBootManagerConnectAll() from the
>> ordinary boot path, ensure that the MAC programming of the GENET
>> occurs even if the SNP driver for it is never invoked by the BDS.
> 
> Does this not cause a behaviour change if the driver *has* been
> invoked, and the MAC address has been modified with
> SNP.StationAddress()?
> 

No, the MAC is programmed when the device is registered. If SNP takes 
control, it does so afterwards, and will be able to supersede the MAC as 
before.