Re: [edk2-devel] [Patch V3 5/8] UefiCPuPkg/CpuMpPei: Add missing CpuLib class

["Laszlo Ersek" <lersek@redhat.com>]

On 04/30/19 21:31, Michael D Kinney wrote:
> The CpuMpPei module uses a services from the CpuLib class,
> but the CpuLib class is missing from the INF file.  This
> update is required to use the new MpInitLibUp instance that
> does not use the CpuLib class.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> index 14ec75f254..4fc4ea77ba 100644
> --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  CPU driver installs CPU PI Multi-processor PPI.
>  #
> -#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> @@ -43,6 +43,7 @@ [LibraryClasses]
>    CpuExceptionHandlerLib
>    MpInitLib
>    BaseMemoryLib
> +  CpuLib
>  
>  [Ppis]
>    gEfiPeiMpServicesPpiGuid                      ## PRODUCES
> 

Right, CpuMpPei calls CpuFlushTlb(), but its INF file doesn't require
CpuLib. And this issue has been masked thus far because both
DxeMpInitLib and PeiMpInitLib depend on CpuLib.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo