From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 30 Apr 2019 13:31:06 -0700
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 46C8BC059B9F;
	Tue, 30 Apr 2019 20:31:06 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-42.rdu2.redhat.com [10.10.121.42])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 12BBC4526;
	Tue, 30 Apr 2019 20:31:04 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch V3 5/8] UefiCPuPkg/CpuMpPei: Add missing CpuLib class
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
References: <20190430193108.8544-1-michael.d.kinney@intel.com>
 <20190430193108.8544-6-michael.d.kinney@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <68fccc04-c3c9-3115-edfe-23d29f07a0d2@redhat.com>
Date: Tue, 30 Apr 2019 22:31:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190430193108.8544-6-michael.d.kinney@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 30 Apr 2019 20:31:06 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/30/19 21:31, Michael D Kinney wrote:
> The CpuMpPei module uses a services from the CpuLib class,
> but the CpuLib class is missing from the INF file.  This
> update is required to use the new MpInitLibUp instance that
> does not use the CpuLib class.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> index 14ec75f254..4fc4ea77ba 100644
> --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  CPU driver installs CPU PI Multi-processor PPI.
>  #
> -#  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> @@ -43,6 +43,7 @@ [LibraryClasses]
>    CpuExceptionHandlerLib
>    MpInitLib
>    BaseMemoryLib
> +  CpuLib
>  
>  [Ppis]
>    gEfiPeiMpServicesPpiGuid                      ## PRODUCES
> 

Right, CpuMpPei calls CpuFlushTlb(), but its INF file doesn't require
CpuLib. And this issue has been masked thus far because both
DxeMpInitLib and PeiMpInitLib depend on CpuLib.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo