Re: [PATCH 1/2] ArmVirtPkg/ArmVirtQemuKernel ARM: make some PCD settings apply to ARM

[Laszlo Ersek <lersek@redhat.com>]

On 12/11/18 13:19, Ard Biesheuvel wrote:
> Move some PCD settings outs of the [PcdsFixedAtBuild.AARCH64] block,
> so that they apply to 32-bit ARM as well. Without this change, the
> ARM build doesn't work.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index d8fbf14e8f4e..9928919bf5b0 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -130,6 +130,15 @@ [PcdsFixedAtBuild.common]
>    gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
>  !endif
>  
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
> +
> +  #
> +  # The maximum physical I/O addressability of the processor, set with
> +  # BuildCpuHob().
> +  #
> +  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
> +
>  [PcdsPatchableInModule.common]
>    #
>    # This will be overridden in the code
> @@ -146,17 +155,6 @@ [PcdsPatchableInModule.common]
>    gArmTokenSpaceGuid.PcdFdBaseAddress|0x0
>    gArmTokenSpaceGuid.PcdFvBaseAddress|0x0
>  
> -[PcdsFixedAtBuild.AARCH64]
> -
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
> -
> -  #
> -  # The maximum physical I/O addressability of the processor, set with
> -  # BuildCpuHob().
> -  #
> -  gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
> -
>  [PcdsDynamicDefault.common]
>    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>