From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.2465.1573123375829037142 for ; Thu, 07 Nov 2019 02:42:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gvqiqUeR; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573123374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eReonLzh/h9xWvGKxHfwpOlBLHJ1cU6ZTHycc7My4G8=; b=gvqiqUeRfNpofNzCykON4sGqmOWihzw7VHZWMZgjAIMUIBEblNtWbBYfmoBQZOnqr+Aese jsvWq1hCkno0htQweI4J3+zWeTiYd5Qi0BdVf1hbdHpg3Dr61WGHHCAW8gmnqQDKcJ1Jii d/+OnqKK/MGO1EH0G3ScgjfgZTsFMng= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-tz7iB85MOISuiExoj31KuA-1; Thu, 07 Nov 2019 05:42:52 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B78A91005500; Thu, 7 Nov 2019 10:42:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id C516C1001DE0; Thu, 7 Nov 2019 10:42:50 +0000 (UTC) Subject: Re: [Patch v4 17/22] UefiCpuPkg: Add YAML file for CI builds To: Michael D Kinney , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-18-michael.d.kinney@intel.com> From: "Laszlo Ersek" Message-ID: <6925ef4e-98dd-8634-1cbc-d177f1faa772@redhat.com> Date: Thu, 7 Nov 2019 11:42:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191107011349.16524-18-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: tz7iB85MOISuiExoj31KuA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/19 02:13, Michael D Kinney wrote: > Add YAML file to the package directory with the > configuration of the checks to perform during a > CI build. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > Acked-by: Laszlo Ersek > --- > UefiCpuPkg/UefiCpuPkg.ci.yaml | 51 +++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 UefiCpuPkg/UefiCpuPkg.ci.yaml >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yam= l > new file mode 100644 > index 0000000000..81da29b878 > --- /dev/null > +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml > @@ -0,0 +1,51 @@ > +## > +# CI configuration for UefiCpuPkg > +# > +# Copyright (c) Microsoft Corporation > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +{ > + "CompilerPlugin": { > + "DscPath": "UefiCpuPkg.dsc" > + }, > + "CharEncodingCheck": { > + "IgnoreFiles": [] > + }, > + "DependencyCheck": { > + "AcceptableDependencies": [ > + "MdePkg/MdePkg.dec", > + "MdeModulePkg/MdeModulePkg.dec", > + "UefiCpuPkg/UefiCpuPkg.dec" > + ], > + # For host based unit tests > + "AcceptableDependencies-HOST_APPLICATION":[], > + # For UEFI shell based apps > + "AcceptableDependencies-UEFI_APPLICATION":[], > + "IgnoreInf": [] > + }, > + "DscCompleteCheck": { > + "DscPath": "UefiCpuPkg.dsc", > + "IgnoreInf": [ > + "UefiCpuPkg/ResetVector/FixupVtf/Vtf.inf", > + "UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf" > + ] > + }, > + "GuidCheck": { > + "IgnoreGuidName": ["SecCore", "ResetVector"], # Expected duplica= tion for gEfiFirmwareVolumeTopFileGuid > + "IgnoreGuidValue": [], > + "IgnoreFoldersAndFiles": [], > + "IgnoreDuplicates": [] > + }, > + "LibraryClassCheck": { > + "IgnoreHeaderFile": [] > + }, > + > + ## options defined ci/Plugin/SpellCheck > + "SpellCheck": { > + "AuditOnly": True, # Fails test but run in AuditOnly m= ode to collect log > + "IgnoreFiles": [], # use gitignore syntax to ignore er= rors in matching files > + "ExtendWords": [], # words to extend to the dictionary= for this package > + "IgnoreStandardPaths": [], # Standard Plugin defined paths tha= t should be ignore > + "AdditionalIncludePaths": [] # Additional paths to spell check (= wildcards supported) > + } > +} >=20 This is a very nice patch: good commit message (subjet and body both), and good file comment. One suggestion: I'd recommend adding "@file" to the comment block at the top. With that: Acked-by: Laszlo Ersek (Of course, should "@file" confuse the YAML parser, then I won't insist, and my ACK still applies.) Thanks! Laszlo