From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.2690.1578380977170969814 for ; Mon, 06 Jan 2020 23:09:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=itQ6K1q7; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578380976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIwHptf7FieDyntF2d36aYef9yRm/zoVSyUqOJ4dwms=; b=itQ6K1q7NoN6xIu/2qhVGYlC3M0JdkEwMeuWvY604/pNkb+N05W74eA59oGqEOWMN7/eEZ KNdSDL+8rJA6HJ7J0dneo+Big4WTzmEOe2BvlwNsw9xFhb+XDxCu+51jXNM/eQexebFBSL UaBRi3oR25/HsfMbEBxSM+pAL3mFMcY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-9zUzwUpZPReHzZbBelHPLA-1; Tue, 07 Jan 2020 02:09:32 -0500 Received: by mail-wr1-f70.google.com with SMTP id z10so24022208wrt.21 for ; Mon, 06 Jan 2020 23:09:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nIwHptf7FieDyntF2d36aYef9yRm/zoVSyUqOJ4dwms=; b=DfeFynPVw3H2xGL4sV+x+QR+FHJsII9EjSz0rmjpRNfzn7E/L8kwc85Gnkhw9LLwQL prPrxIhIbutrqqPIq5V/wwKWZ3JqvZawg8T3nJG5q2UWJgBieRt+rRGcOwVEnERKbatv EgEEn+hA6iaIaC+PRomvtodMMhMAvCXCWnhzloNI89Hu0f0tRDlI75oyRYmUx/v3n8ZX td+6CexzQKj65GfIpV6+h91ZwlwIrrnwCqzVM/Ln+Bg/b2UfzxQ5rgNxWgZ9u/JGrlXT QXV3PkJ52MAj11DFUiku8o1Lb1a5y+qbF3J9DvTTqUUH6JjhCndWhrVJi886NYjMM3AD d/ng== X-Gm-Message-State: APjAAAXvpQc+lYD18X1ajC++DZbuHjm41+SKt0ixvjCyhBAFhHCFmahE 3azYmysM8k3YRCFYvRXkGBrLdbFUNOSvinS7VVZ9SFn3/2KLElnlLFX2Q1w7BJFZW23uzrVIu/d /Flcm4HK9zMIAEw== X-Received: by 2002:a1c:99ce:: with SMTP id b197mr38534566wme.108.1578380971665; Mon, 06 Jan 2020 23:09:31 -0800 (PST) X-Google-Smtp-Source: APXvYqz/fKSnL75WxnlCaHkIkVnNcOkwwa0TmuKxEhzISJfbXQvEmDY/Y/NoHslFxc/qW+3r8BddDA== X-Received: by 2002:a1c:99ce:: with SMTP id b197mr38534548wme.108.1578380971476; Mon, 06 Jan 2020 23:09:31 -0800 (PST) Return-Path: Received: from [192.168.1.35] (34.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.34]) by smtp.gmail.com with ESMTPSA id w8sm26907312wmd.2.2020.01.06.23.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2020 23:09:30 -0800 (PST) Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <20191219140932.25428-1-philmd@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <692bf71f-dd33-d8db-914c-2867845434ac@redhat.com> Date: Tue, 7 Jan 2020 08:09:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> X-MC-Unique: 9zUzwUpZPReHzZbBelHPLA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Zhichao, On 1/7/20 8:01 AM, Gao, Zhichao wrote: > Sorry for late response: > >> -----Original Message----- >> From: Philippe Mathieu-Daude >> Sent: Thursday, December 19, 2019 10:10 PM >> To: devel@edk2.groups.io >> Cc: Ni, Ray ; Gao, Zhichao ; >> Philippe Mathieu-Daude >> Subject: [PATCH v2 0/2] ShellPkg: Document the use of >> EFI_INVALID_PARAMETER by two functions >> >> Complete the list of values the functios ParseCommandLineToArgs() and >> UpdateArgcArgv() can return. >> >> The documentation was found to be incomplete while reviewing BZ#2395: >> https://edk2.groups.io/g/devel/message/51512 >> >> v2: >> - Shortened patch #1 subject to fit 72 chars > > The subject should be less than 72 chars (do not include 72 chars). What is the rationale for this restriction? Some tool limitation?