From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C73A87803EA for ; Thu, 25 Apr 2024 08:16:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EHJhCs3hDpDvMAavOn++k1l5QEC7+7by3r4qv+XYNTo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1714033018; v=1; b=Se8mvqWLl3rQL2XnkC6+hr1gDqTJ3uIwK0doZ++FjS4GYHGHk0Q8ObmLZf8oQUrKbIgpiisz S/waFCvJpXEmtYArOl4IdC0Y0RPs3Mmz0MOUH32eA59TbHp+O7HMBSnRKhGrj7gSjQyt7gOHSiN p6rxb+SzTEp8Lw9mbyT4hnlSXsahk8fqFJJ/rBv3v3BwNJJuQudt5ouvXSjhe1/C+SP8JrGeMBJ Bv9sHsVCXCV+dJWhSVy9/GusxyBcw8/1lMurIXYXRrXY1dq0WUvm8FMvrrKATRJyLZ+RAmjhTdR 2qsAxD/otpd2iUvPlX0i0MbdkLNnH3SCeKcZZiWRdV1xg== X-Received: by 127.0.0.2 with SMTP id TEMwYY7687511xPmvltVW7P2; Thu, 25 Apr 2024 01:16:58 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.11915.1714033015327191150 for ; Thu, 25 Apr 2024 01:16:57 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxSfF1ESpmFLYCAA--.12967S3; Thu, 25 Apr 2024 16:16:53 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxwVV0ESpmh+QEAA--.1060S3; Thu, 25 Apr 2024 16:16:52 +0800 (CST) Message-ID: <694826ce-2ad7-4b0a-b457-df1f0010fec9@loongson.cn> Date: Thu, 25 Apr 2024 16:16:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 2/7] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio To: devel@edk2.groups.io, ardb@kernel.org Cc: kraxel@redhat.com, Ard Biesheuvel , Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin References: <20240425041728.1385891-1-lichao@loongson.cn> <20240425041816.1386268-1-lichao@loongson.cn> <5boqyu5erbhftofbobyknwg4i4ngbm4igybx554whbtqnn4hh6@3zl5bgcskxkj> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxwVV0ESpmh+QEAA--.1060S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQASCGYpxJMEXwAHsf X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Apr 2024 01:16:57 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dSy8Lt58WZfGlozI53ikWWAYx7686176AA= Content-Type: multipart/alternative; boundary="------------X6nktsVlq5VyaRmQ2sKclpAG" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Se8mvqWL; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------X6nktsVlq5VyaRmQ2sKclpAG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard and Gerd, Thanks, Chao On 2024/4/25 16:11, Ard Biesheuvel wrote: > On Thu, 25 Apr 2024 at 10:10, Chao Li wrote: >> Hi Gerd, >> >> >> Thanks, >> Chao >> On 2024/4/25 15:40, Gerd Hoffmann wrote: >> >> Hi, >> >> +EFI_GUID mFwCfgSelectorAddressGuid =3D FW_CONFIG_SELECTOR_ADDRESS_HOB_= GUID; >> +EFI_GUID mFwCfgDataAddressGuid =3D FW_CONFIG_DATA_ADDRESS_HOB_GUID= ; >> +EFI_GUID mFwCfgDmaAddressGuid =3D FW_CONFIG_DMA_ADDRESS_HOB_GUID; >> >> Oh. I assumed that would be obvious (because it's common practice for >> HOBs), but I was thinking about a single HOB containing a struct with >> all three values instead of a separate HOB for each value. >> >> If uses a single HOB, it must define a structure in this library, and it= may be more complicated to build and parse the HOB. >> > Please use a single HOB, and avoid global variables in PEI (PEI > modules may execute in place from read-only NOR flash, so global > variables are not allowed in PEI) OK, I will adjust it now, and send the V3. > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118281): https://edk2.groups.io/g/devel/message/118281 Mute This Topic: https://groups.io/mt/105724969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------X6nktsVlq5VyaRmQ2sKclpAG Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ard and Gerd,


=
Thanks,
Chao
On 2024/4/25 16:11, Ard Biesheuvel wrote:
On Thu, 25 Apr 2024 at 10:10, =
Chao Li <lichao@loongson.cn> wrote:

Hi Gerd,


Thanks,
Chao
On 2024/4/25 15:40, Gerd Hoffmann wrote:

  Hi,

+EFI_GUID  mFwCfgSelectorAddressGuid =3D FW_CONFIG_SELECTOR_ADDRESS_HOB_GUI=
D;
+EFI_GUID  mFwCfgDataAddressGuid     =3D FW_CONFIG_DATA_ADDRESS_HOB_GUID;
+EFI_GUID  mFwCfgDmaAddressGuid      =3D FW_CONFIG_DMA_ADDRESS_HOB_GUID;

Oh.  I assumed that would be obvious (because it's common practice for
HOBs), but I was thinking about a single HOB containing a struct with
all three values instead of a separate HOB for each value.

If uses a single HOB, it must define a structure in this library, and it ma=
y be more complicated to build and parse the HOB.


Please use a single HOB, and avoid global variables in PEI (PEI
modules may execute in place from read-only NOR flash, so global
variables are not allowed in PEI)
OK, I will adjust it now, and send the V3.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118281) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------X6nktsVlq5VyaRmQ2sKclpAG--