From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.25692.1574352219312854265 for ; Thu, 21 Nov 2019 08:03:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Xb6fZbtq; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574352218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6cN24W1ygbGeSk058nRvqAwa0QIBAJYwfX79P3D+GvE=; b=Xb6fZbtq0RDpthr9cR2Yf37TNL7/zn5LVflpujQmKEVLehdTnyoE+vc0km6lTsLfiN+CMn nM7rFSKIpC8AoXxSHsBLRJfOHnm2y9toM6xToc8O2nUB33srejcEluj5iDW+JzihxcvxkE 1Au+Eroa2RCGrmFAr06k4WYaVhDbJZ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-qGy3DOSFPAqbXvos2c_x1Q-1; Thu, 21 Nov 2019 11:03:34 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 207CE8024D9; Thu, 21 Nov 2019 16:03:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-197.ams2.redhat.com [10.36.116.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8AC05D72B; Thu, 21 Nov 2019 16:03:30 +0000 (UTC) Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 To: Sami Mujawar , devel@edk2.groups.io Cc: achin.gupta@arm.com, jiewen.yao@intel.com, supreeth.venkatesh@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com, Liming Gao , Leif Lindholm References: <20191121150631.20096-1-sami.mujawar@arm.com> From: "Laszlo Ersek" Message-ID: <69536bde-e2e7-ae34-79ac-09768a835e06@redhat.com> Date: Thu, 21 Nov 2019 17:03:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191121150631.20096-1-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: qGy3DOSFPAqbXvos2c_x1Q-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable On 11/21/19 16:06, Sami Mujawar wrote: > The StandaloneMmPkg currently has code for supporting > Arm architecture only. Support for X64 and IA32 is > currently under development on a separate branch. >=20 > However, StandaloneMmPkg/StandaloneMmPkg.dsc is > indicating that support for X64 and IA32 is > available which is causing build failures. > This has been reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253 >=20 > This issue has been discussed earlier on the list: > (1) https://edk2.groups.io/g/devel/message/47276 >=20 > (2) https://edk2.groups.io/g/devel/message/47283 >=20 > In light of the above, this patch removes IA32 and X64 > from SUPPORTED_ARCHITECTURES, until support for the > respective architectures is merged into StandaloneMmPkg. >=20 > CC: Achin Gupta > CC: Jiewen Yao > CC: Supreeth Venkatesh > CC: Laszlo Ersek > Signed-off-by: Sami Mujawar >=20 > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arc= h_v1 >=20 > Notes: > v1: > - Fix for Bug 2253 [SAMI= ] > (https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253) >=20 > StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/Standa= loneMmPkg.dsc > index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986= a1bb554dae1e975 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -2,7 +2,7 @@ > # Standalone MM Platform. > # > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -19,7 +19,7 @@ [Defines] > PLATFORM_VERSION =3D 1.0 > DSC_SPECIFICATION =3D 0x00010011 > OUTPUT_DIRECTORY =3D Build/StandaloneMm > - SUPPORTED_ARCHITECTURES =3D IA32|X64|AARCH64 > + SUPPORTED_ARCHITECTURES =3D AARCH64 > BUILD_TARGETS =3D DEBUG|RELEASE > SKUID_IDENTIFIER =3D DEFAULT > =20 >=20 Reviewed-by: Laszlo Ersek This should be included in edk2-stable201911 -- it fixes obscure build failures. Thanks Laszlo